From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 263F8429B1 for ; Mon, 10 Jan 2022 17:52:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A4D768AC4D; Mon, 10 Jan 2022 19:52:00 +0200 (EET) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A1A6687FCE for ; Mon, 10 Jan 2022 19:51:52 +0200 (EET) Received: by mail-qv1-f42.google.com with SMTP id hu2so15166264qvb.8 for ; Mon, 10 Jan 2022 09:51:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=j7mk9K5u0M2Q/8Nlh2CBIrt+q0x/j/sUDVC7s41lbN8=; b=LMfXr7FzZz/wMi419VTSWj+evUJ5NtIAOqt4oeP5lySrDMkfuyohd6xqzkj9CYTUBu EI9sc3jlKeTdpvVmTkTglneyrV57HZ/W5x7aOnjsRNM5uYv5SC1EctvIZ3ZRn5OBGQLP RG8LKPGcZUBSTUqGZGAQvLsxDeC4ltq7ztJBg12dGooAn2ZHn7oy8YxSyDvb+/dCJvf5 CXr7n6HD1e7umnCDEvRgScfiZPf4tPXoVrR9x3aPCd9Ky2J04yZq6nhMvkXA/oGz5+03 qIa6jpzn99YBoIFUuqMjU1AWle5q8F/sTQJ2e4R25eLCyk3Pmo2oBGNinHB6E/OjxWfw bpmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=j7mk9K5u0M2Q/8Nlh2CBIrt+q0x/j/sUDVC7s41lbN8=; b=gpYXFwCdik4CH8AElkvYj3bcwzO5Dj6fCIU1QUogpwXud121r3Ymz5Ugz+1ojO3OtJ C1tMz38ge14kyyjPX5ZqGuM/vYUEfK2RROILS2eY2OV76haITYdVlLkewmUc2SbXp1Dm ZeiCUAG6A2Y5kFMQeJJ7WuE3/QrticmrlLLcOJvm4WbwFSYewFBHxVWyv2euZTkPERnx kOeq1bZVFEcRcjSQrHUJKP7Dl06TLTqCpNp8TxkPKARh58LYEyaJCtA3DFAOtH1WbBdm C5hemIavfLQ+xEttlLAXxCVUZQFJux5Ero2cndv1WoFHVPI3ebuIJlXQdWqypZF57Iuu ltaA== X-Gm-Message-State: AOAM532hQf+3pk66r0bVQGAXgGEf3V+iVriniCoHljUyEiiyu+GU9Y0q XDCpOY/jBOBfPclXeP3SyomMcfZxpMU= X-Google-Smtp-Source: ABdhPJxBSGeL3qwTRhnOWfBuD2Cynlx1o9UWGPYHF9/YPDBpyDN/LbpBpXFUqMHL7k1xUgx1OG04+Q== X-Received: by 2002:a05:6214:c69:: with SMTP id t9mr495041qvj.100.1641837110067; Mon, 10 Jan 2022 09:51:50 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id s27sm5545505qtc.0.2022.01.10.09.51.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 09:51:49 -0800 (PST) Message-ID: <18b09a7f-3014-b22e-0fc6-b78266b29c33@gmail.com> Date: Mon, 10 Jan 2022 14:51:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220110165143.2292-1-anton@khirnov.net> From: James Almer In-Reply-To: <20220110165143.2292-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavf/udp: do not return an uninitialized value from udp_open() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/10/2022 1:51 PM, Anton Khirnov wrote: > --- > libavformat/udp.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/udp.c b/libavformat/udp.c > index b8b0e19609..180d96a988 100644 > --- a/libavformat/udp.c > +++ b/libavformat/udp.c > @@ -739,8 +739,10 @@ static int udp_open(URLContext *h, const char *uri, int flags) > /* XXX: fix av_url_split */ > if (hostname[0] == '\0' || hostname[0] == '?') { > /* only accepts null hostname if input */ > - if (!(flags & AVIO_FLAG_READ)) > + if (!(flags & AVIO_FLAG_READ)) { > + ret = AVERROR(EINVAL); > goto fail; > + } > } else { > if ((ret = ff_udp_set_remote_url(h, uri)) < 0) > goto fail; > @@ -750,8 +752,10 @@ static int udp_open(URLContext *h, const char *uri, int flags) > s->local_port = port; > > udp_fd = udp_socket_create(h, &my_addr, &len, s->localaddr); > - if (udp_fd < 0) > + if (udp_fd < 0) { > + ret = AVERROR(EIO); > goto fail; > + } > > s->local_addr_storage=my_addr; //store for future multicast join LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".