Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang@intel.com>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "zhongli_dev@126.com" <zhongli_dev@126.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: specify codec name when print profile
Date: Thu, 23 Dec 2021 08:38:09 +0000
Message-ID: <189d84962234505d1a71700faa95e345773d67f2.camel@intel.com> (raw)
In-Reply-To: <20211221151806.23772-1-zhongli_dev@126.com>

On Tue, 2021-12-21 at 23:18 +0800, Zhong Li wrote:
> It is more clear and easily to detect the issues similar to commit
> 3857ecbe70e81cb6ad7a7f155c311e8522b93b3e
> 
> Signed-off-by: Zhong Li <zhongli_dev@126.com>
> ---
>  libavcodec/qsvenc.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 92a8b49fe3..be5a541409 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -47,41 +47,41 @@ struct profile_names {
>  };
>  
>  static const struct profile_names avc_profiles[] = {
> -    { MFX_PROFILE_AVC_BASELINE,                 "baseline"              },
> -    { MFX_PROFILE_AVC_MAIN,                     "main"                  },
> -    { MFX_PROFILE_AVC_EXTENDED,                 "extended"              },
> -    { MFX_PROFILE_AVC_HIGH,                     "high"                  },
> +    { MFX_PROFILE_AVC_BASELINE,                 "avc
> baseline"              },
> +    { MFX_PROFILE_AVC_MAIN,                     "avc
> main"                  },
> +    { MFX_PROFILE_AVC_EXTENDED,                 "avc
> extended"              },
> +    { MFX_PROFILE_AVC_HIGH,                     "avc
> high"                  },
>  #if QSV_VERSION_ATLEAST(1, 15)
> -    { MFX_PROFILE_AVC_HIGH_422,                 "high 422"              },
> +    { MFX_PROFILE_AVC_HIGH_422,                 "avc high
> 422"              },
>  #endif
>  #if QSV_VERSION_ATLEAST(1, 4)
> -    { MFX_PROFILE_AVC_CONSTRAINED_BASELINE,     "constrained baseline"  },
> -    { MFX_PROFILE_AVC_CONSTRAINED_HIGH,         "constrained high"      },
> -    { MFX_PROFILE_AVC_PROGRESSIVE_HIGH,         "progressive high"      },
> +    { MFX_PROFILE_AVC_CONSTRAINED_BASELINE,     "avc constrained
> baseline"  },
> +    { MFX_PROFILE_AVC_CONSTRAINED_HIGH,         "avc constrained
> high"      },
> +    { MFX_PROFILE_AVC_PROGRESSIVE_HIGH,         "avc progressive
> high"      },
>  #endif
>  };
>  
>  static const struct profile_names mpeg2_profiles[] = {
> -    { MFX_PROFILE_MPEG2_SIMPLE,                 "simple"                },
> -    { MFX_PROFILE_MPEG2_MAIN,                   "main"                  },
> -    { MFX_PROFILE_MPEG2_HIGH,                   "high"                  },
> +    { MFX_PROFILE_MPEG2_SIMPLE,                 "mpeg2
> simple"                },
> +    { MFX_PROFILE_MPEG2_MAIN,                   "mpeg2
> main"                  },
> +    { MFX_PROFILE_MPEG2_HIGH,                   "mpeg2
> high"                  },
>  };
>  
>  static const struct profile_names hevc_profiles[] = {
>  #if QSV_VERSION_ATLEAST(1, 8)
> -    { MFX_PROFILE_HEVC_MAIN,                    "main"                  },
> -    { MFX_PROFILE_HEVC_MAIN10,                  "main10"                },
> -    { MFX_PROFILE_HEVC_MAINSP,                  "mainsp"                },
> -    { MFX_PROFILE_HEVC_REXT,                    "rext"                  },
> +    { MFX_PROFILE_HEVC_MAIN,                    "hevc
> main"                  },
> +    { MFX_PROFILE_HEVC_MAIN10,                  "hevc
> main10"                },
> +    { MFX_PROFILE_HEVC_MAINSP,                  "hevc
> mainsp"                },
> +    { MFX_PROFILE_HEVC_REXT,                    "hevc
> rext"                  },
>  #endif
>  };
>  
>  static const struct profile_names vp9_profiles[] = {
>  #if QSV_VERSION_ATLEAST(1, 19)
> -    { MFX_PROFILE_VP9_0,                        "0"                     },
> -    { MFX_PROFILE_VP9_1,                        "1"                     },
> -    { MFX_PROFILE_VP9_2,                        "2"                     },
> -    { MFX_PROFILE_VP9_3,                        "3"                     },
> +    { MFX_PROFILE_VP9_0,                        "vp9
> 0"                     },
> +    { MFX_PROFILE_VP9_1,                        "vp9
> 1"                     },
> +    { MFX_PROFILE_VP9_2,                        "vp9
> 2"                     },
> +    { MFX_PROFILE_VP9_3,                        "vp9
> 3"                     },
>  #endif
>  };
>  

Applied, thx!

-Haihao

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2021-12-23  8:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 15:18 Zhong Li
2021-12-23  8:38 ` Xiang, Haihao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=189d84962234505d1a71700faa95e345773d67f2.camel@intel.com \
    --to=haihao.xiang@intel.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhongli_dev@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git