From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id C71114204C
	for <ffmpegdev@gitmailbox.com>; Fri, 25 Mar 2022 22:44:11 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9224F68B1C1;
	Sat, 26 Mar 2022 00:44:07 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C0CB668AF91
 for <ffmpeg-devel@ffmpeg.org>; Sat, 26 Mar 2022 00:44:00 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 22PMi0MB010116-22PMi0MC010116;
 Sat, 26 Mar 2022 00:44:00 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id E1CA2A143A;
 Sat, 26 Mar 2022 00:43:59 +0200 (EET)
Date: Sat, 26 Mar 2022 00:43:59 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: Kevin Wang <kevin@muxable.com>
In-Reply-To: <20220322182511.7747-1-kevin@muxable.com>
Message-ID: <18873037-6543-a9e5-86fc-791e5cef5aaa@martin.st>
References: <20220322182511.7747-1-kevin@muxable.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] rtpenc_vp8: Use 15-bit PictureIDs
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Kevin Wang <kevmo314@gmail.com>, ffmpeg-devel@ffmpeg.org
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/18873037-6543-a9e5-86fc-791e5cef5aaa@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Tue, 22 Mar 2022, kevin@muxable.com wrote:

> From: Kevin Wang <kevmo314@gmail.com>
>
> 7-bit PictureIDs are not supported by WebRTC:
> https://groups.google.com/g/discuss-webrtc/c/333-L02vuWA
>
> In practice, 15-bit PictureIDs offer better compatibility.
>
> Signed-off-by: Kevin Wang <kevin@muxable.com>
> ---
> libavformat/rtpenc_vp8.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/rtpenc_vp8.c b/libavformat/rtpenc_vp8.c
> index 671d245758..655d44517e 100644
> --- a/libavformat/rtpenc_vp8.c
> +++ b/libavformat/rtpenc_vp8.c
> @@ -35,7 +35,8 @@ void ff_rtp_send_vp8(AVFormatContext *s1, const uint8_t *buf, int size)
>     // partition id 0
>     *s->buf_ptr++ = 0x90;
>     *s->buf_ptr++ = 0x80; // Picture id present
> -    *s->buf_ptr++ = s->frame_count++ & 0x7f;
> +    *s->buf_ptr++ = ((s->frame_count & 0x7f00) >> 8) | 0x80;
> +    *s->buf_ptr++ = s->frame_count++ & 0xff;
>     // Calculate the number of remaining bytes
>     header_size     = s->buf_ptr - s->buf;
>     max_packet_size = s->max_payload_size - header_size;
> -- 
> 2.34.1

LGTM, thanks!

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".