From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C72EE42248 for ; Tue, 1 Mar 2022 10:15:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B85C168B20E; Tue, 1 Mar 2022 12:15:00 +0200 (EET) Received: from mail1.trendhosting.net (mail1.trendhosting.net [195.8.117.5]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DC8AA68B1CA for ; Tue, 1 Mar 2022 12:14:53 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by mail1.trendhosting.net (Postfix) with ESMTP id 59E92150DC for ; Tue, 1 Mar 2022 10:14:53 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pocock.pro; s=mail; t=1646129693; bh=7AJQISfaa++Ndkf4NA4sFMIQkYjWoPs53dgcJoxYe8Q=; h=Subject:To:References:From:Date:In-Reply-To:From; b=ASeUQkIW7U9N9VmIZVajecMWSyIkXpITDT1rfZshja51qj1lT6gOU3GiG4TY5ztrs 2xlrrpds1nbdK+Duv6cVDF1j4ELrQerE9koc3al8cHiLAIbCm+rvM7vEgLgEExi+Lg zAwtVtL37sz4CiHBYu+GJCGTwe75Ky3gQJWbnhSg= Received: from mail1.trendhosting.net ([127.0.0.1]) by localhost (thp003.trendhosting.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PVawYHu5f8Yw for ; Tue, 1 Mar 2022 10:14:50 +0000 (GMT) Received: from [IPv6:2001:1620:e61:0:ec02:598c:9d65:511b] (unknown [IPv6:2001:1620:e61:0:ec02:598c:9d65:511b]) by mail1.trendhosting.net (Postfix) with ESMTPSA id 62B8D150D2 for ; Tue, 1 Mar 2022 10:14:50 +0000 (GMT) To: ffmpeg-devel@ffmpeg.org References: <752868c0-25e3-8801-67fa-0a4ec1adb0c4@pocock.pro> From: Daniel Pocock Message-ID: <18377e32-9223-6cec-3deb-5759d9b555fd@pocock.pro> Date: Tue, 1 Mar 2022 11:14:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [FFmpeg-devel] [PATCH] fix build, avcodec: update OpenH264 header path X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 01/03/2022 10:19, Hendrik Leppkes wrote: > On Tue, Mar 1, 2022 at 9:16 AM Daniel Pocock wrote: >> >> >> This updates the locations searched for the OpenH264 headers to be >> consistent with upstream >> >> Discussed here: >> https://github.com/cisco/openh264/pull/3415 >> >> Due to the change in the pkgconfig file, it is possible to compile with >> either: >> >> #include >> >> OR >> >> #include >> >> but in this patch, I used the former. >> > > Which releases of the library have the updated location? Will older > releases still work, if so, which? This patch is very trivial and doesn't attempt to support older releases of OpenH264. Please keep in mind the OpenH264 code is patented and not widely installed in Linux distributions. Developers have to download it directly each time they include it in a project. So there doesn't appear to be a compelling case to support many versions concurrently. > As far as I can see, the change is days old and not in any release, so > committing this now would break compatibility with anything but > OpenH264 git master? Is that correct? Yes, that is correct Jeff made a comment in Github about this change breaking the ffmpeg build. I don't know which combination of ffmpeg and OpenH264 he is aiming to build. It would be a good idea to commit in ffmpeg whenever OpenH264 makes another tag. Their last tag was v2.2.0 on 28 January and the next one will eventually appear on this page: https://github.com/cisco/openh264/tags Regards, Daniel -- Debian Developer https://danielpocock.com _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".