From: Daniel Pocock <daniel@pocock.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fix build, avcodec: update OpenH264 header path
Date: Tue, 1 Mar 2022 11:14:50 +0100
Message-ID: <18377e32-9223-6cec-3deb-5759d9b555fd@pocock.pro> (raw)
In-Reply-To: <CA+anqdyYra-ih+-Q9+mt9wws7_MGApFgySEG3BKeV_HkY73Jkw@mail.gmail.com>
On 01/03/2022 10:19, Hendrik Leppkes wrote:
> On Tue, Mar 1, 2022 at 9:16 AM Daniel Pocock <daniel@pocock.pro> wrote:
>>
>>
>> This updates the locations searched for the OpenH264 headers to be
>> consistent with upstream
>>
>> Discussed here:
>> https://github.com/cisco/openh264/pull/3415
>>
>> Due to the change in the pkgconfig file, it is possible to compile with
>> either:
>>
>> #include <openh264/codec_api.h>
>>
>> OR
>>
>> #include <codec_api.h>
>>
>> but in this patch, I used the former.
>>
>
> Which releases of the library have the updated location? Will older
> releases still work, if so, which?
This patch is very trivial and doesn't attempt to support older releases
of OpenH264. Please keep in mind the OpenH264 code is patented and not
widely installed in Linux distributions. Developers have to download it
directly each time they include it in a project. So there doesn't
appear to be a compelling case to support many versions concurrently.
> As far as I can see, the change is days old and not in any release, so
> committing this now would break compatibility with anything but
> OpenH264 git master? Is that correct?
Yes, that is correct
Jeff made a comment in Github about this change breaking the ffmpeg
build. I don't know which combination of ffmpeg and OpenH264 he is
aiming to build.
It would be a good idea to commit in ffmpeg whenever OpenH264 makes
another tag. Their last tag was v2.2.0 on 28 January and the next one
will eventually appear on this page:
https://github.com/cisco/openh264/tags
Regards,
Daniel
--
Debian Developer
https://danielpocock.com
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-01 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 8:16 Daniel Pocock
2022-03-01 9:19 ` Hendrik Leppkes
2022-03-01 10:14 ` Daniel Pocock [this message]
2022-03-01 13:27 ` Martin Storsjö
2022-03-01 15:13 ` Daniel Pocock
2022-03-01 15:29 ` Martin Storsjö
2022-03-01 21:50 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18377e32-9223-6cec-3deb-5759d9b555fd@pocock.pro \
--to=daniel@pocock.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git