From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff
Date: Sat, 08 Jun 2024 09:43:40 +0300
Message-ID: <1800206.TmaS38HnFp@basile.remlab.net> (raw)
In-Reply-To: <AS8P250MB0744A51D65CDB8C28B5CF31A8FC42@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Le lauantaina 8. kesäkuuta 2024, 9.23.48 EEST Andreas Rheinhardt a écrit :
> Rémi Denis-Courmont:
> > Le lauantaina 8. kesäkuuta 2024, 0.26.21 EEST Andreas Rheinhardt a écrit :
> >> (Also: IIRC Clang actually parses inline assembler and optimize it;
> >
> > That sounds sketchy. While FFmpeg only uses inline assembler as intrinsic
> > ersatz, other projects can and definitely do use them for weirder stuff.
> > That will fail miserably if the compiler modifies the sequence.
>
> See https://godbolt.org/z/ozeGoWzK7: Clang is smart enough to know that
> the x86-inline asm version of av_bswap32 is self-inverse. (It can also
> evaluate it for constants at compile-time.)
It seems that they have some heuristics not to touch assembler that they are
not sure that they "completely" understand. If you add just a dummy numeric
label, the optimisation is not done.
My preference would be to use builtin_bswap (as riscv/ does) on all
architectures on GCC and Clang, and keep the bespoke C for other compilers and
external header inclusion.
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-08 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 16:49 Rémi Denis-Courmont
2024-06-07 21:16 ` Sean McGovern
2024-06-07 21:26 ` Andreas Rheinhardt
2024-06-08 6:15 ` Rémi Denis-Courmont
2024-06-08 6:23 ` Andreas Rheinhardt
2024-06-08 6:43 ` Rémi Denis-Courmont [this message]
2024-06-08 13:41 ` Andreas Rheinhardt
2024-06-08 14:38 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1800206.TmaS38HnFp@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git