From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 598E84F53B for ; Fri, 27 Feb 2026 16:37:55 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'hM7OkJaUcc7IyXS7HuvsjlA42N/q63kdgC0tur2Ss7Y=', expected b'fHJsK/ADGbsNekButym0Lgq/ddzpyCp8t8CFxrdS2CQ=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772210265; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=hM7OkJaUcc7IyXS7HuvsjlA42N/q63kdgC0tur2Ss7Y=; b=NKyVCSmLsUFsQVUkgIJQnIiFr56yXhFg6HiVUt4GVbX1HjN2995wKEBnFnELPxj/5KMx3 f7/h2ZQfJgrWRKWc0qcE/b7jAQH7OJa4+Zf7QEccvRcae3Nu4/K6oGxSdt7AbrsHx4dO5b1 3JeqgBIIxSIuaHf1jj3P8dxT9pBrjbTB7FzsTusrrHQD+PvUZfXdLx6jyNtjEF1A+TJWsGI iZs0Ap5Qxf0Z/btX5XL75qMPxIjTBN0KkO09cbERYW6f/9f5amtErhN6Q9Es5yRaZ7qvtth ba7xuk6pOVpzTQes7VFhOQT/YG9JXC935bveRzfgesZvIFvr8I0QBnjmeu+A== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EFDF26913B5; Fri, 27 Feb 2026 18:37:45 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772210257; b=fcIXFK7yrJltoUuqg3b1+KVEH/Uw6j+uvnrB7Dg1JIP1PXh5fhfMHU5Wud8vxBCFZ/Aqk pcpN9FMnMNysLqjOKKQcQt359F7pjJfcUeBab//0MM8DgccWAoP0YwwKJOUoagf0Y+/xKEb h6zXOpHMaEwPhVSq59OrXlxSPFP12Dhm3KdyKi/A4HrNTbfxUDZGgL9GWBMMUkAKuCNFbqe G9QXBaK2s5RFkzXECNYrftAho15iLgtJF1gaNtyoKjuBCJ/hIo8YHxLyz//HOxJ+/OsB3Bq C3pEOUKr5brm12yvzIr03lZiZ44nmlVqv5vB+HWmCVAyRh5rDnurW0RXDgQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772210257; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=u+fIEI+aKdwRD1+2Ce7fQA3KTnN+GdZVmZlXR3uHXbk=; b=OMVJ70NImH8lT/ZtZKbYGU1KwA7jcAWzrynFwKHhsKj93uC47qX7H41C+eTFgiSyMp6ad x1eAkBzPtx6olBhPP6DncXTBumV3HWQ5SntNpn+r2B3EnyI0VPrACfm/eLI410inZhpLBEe WQGtx//H2JMwHrputsRkQ07b+X1wO08GaPc/YEpNhG4mV1i/55RnW4k/Cd/kkG3KnDdEFEJ mPM0hslT28ey4bZLkVZAjWlC9WZ5A+Bkj1q0D0K8Na5L61ReX8mwnwDTN5mI9YORO1atGlg yJjQQgjbtg4c4K6rs/dyp98qAAW+egUTIqa2x7KPaHYzLX7633eQn9addhyw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772210248; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=fHJsK/ADGbsNekButym0Lgq/ddzpyCp8t8CFxrdS2CQ=; b=DkcpRnhDyzbHfZkgU02LmD2uqPHK22E9bDPt8AHkdUIOhgc3uFO54pIdAocCX8jsincs4 SNafIuJ6x7ZV5LIxLqHVKMtS7Gt1wT27BbqHc+ps/asna1QVyMDtM5K+nTTmW/tYnF2HI71 nuaDMlWp1bHYt9Ch7JeZS3RRMX5eg6nTqqGfOXjYLuN+7CC8GKCR6oILzm3JgBFFapy5rER T91UgkHGZyrwP7Hw4fYAwkqTiEi8sfvF47UF1fB5SeTuR7nea94P8J20sytk2jmslGJtakX INcev9/QZlw1pWLZfw68fy4z0ZhGjemohpgG2UAhktb4N/5mOC7vrnBuiXQA== MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 27 Feb 2026 16:37:28 -0000 Message-ID: <177221024892.25.2652842761445282930@29965ddac10e> Message-ID-Hash: JPWFJC24WC47RKVQ7UY33LIPFKEDX3ZN X-Message-ID-Hash: JPWFJC24WC47RKVQ7UY33LIPFKEDX3ZN X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] swscale/graph: correctly error out on slice thread init error (PR #22316) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Niklas Haas via ffmpeg-devel Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #22316 opened by Niklas Haas (haasn) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22316 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22316.patch The code was evidently designed at one point in time to support "direct" execution (not via a thread pool) for num_threads == 1, but this was never implemented. Just properly error out here. Signed-off-by: Niklas Haas >>From de0d1d95c110a7724a3edca8c52e1b68acc8dc12 Mon Sep 17 00:00:00 2001 From: Niklas Haas Date: Fri, 27 Feb 2026 13:32:00 +0100 Subject: [PATCH] swscale/graph: correctly error out on slice thread init error The code was evidently designed at one point in time to support "direct" execution (not via a thread pool) for num_threads == 1, but this was never implemented. Just properly error out here. Signed-off-by: Niklas Haas --- libswscale/graph.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libswscale/graph.c b/libswscale/graph.c index 6a17a12496..2eaf7595f4 100644 --- a/libswscale/graph.c +++ b/libswscale/graph.c @@ -791,12 +791,9 @@ int ff_sws_graph_create(SwsContext *ctx, const SwsFormat *dst, const SwsFormat * ret = avpriv_slicethread_create(&graph->slicethread, (void *) graph, sws_graph_worker, NULL, ctx->threads); - if (ret == AVERROR(ENOSYS)) - graph->num_threads = 1; - else if (ret < 0) + if (ret < 0) goto error; - else - graph->num_threads = ret; + graph->num_threads = ret; ret = init_passes(graph); if (ret < 0) -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org