[FFmpeg-devel] [PR] swscale/ops_backend: mark unreachable branch (PR #22315)

[Ramiro Polla via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #22315 opened by Ramiro Polla (ramiro)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22315
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22315.patch

The pixel format for the process loops have already been checked at
this point to be valid.

The switch added in e4abfb8e519 returns AVERROR(EINVAL) in the default
case without calling ff_sws_op_chain_free(chain), but there's no need
to free it since we mark this branch as unreachable.


>From 652f641e26e99f42be1e0bcfdcc1cbed2a6f3b21 Mon Sep 17 00:00:00 2001
From: Ramiro Polla <ramiro.polla@gmail.com>
Date: Fri, 27 Feb 2026 17:07:42 +0100
Subject: [PATCH] swscale/ops_backend: mark unreachable branch

The pixel format for the process loops have already been checked at
this point to be valid.

The switch added in e4abfb8e519 returns AVERROR(EINVAL) in the default
case without calling ff_sws_op_chain_free(chain), but there's no need
to free it since we mark this branch as unreachable.
---
 libswscale/ops_backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libswscale/ops_backend.c b/libswscale/ops_backend.c
index cdbc3d2a3d..da16cb40f3 100644
--- a/libswscale/ops_backend.c
+++ b/libswscale/ops_backend.c
@@ -88,7 +88,7 @@ static int compile(SwsContext *ctx, SwsOpList *ops, SwsCompiledOp *out)
     case SWS_PIXEL_U16: out->func = process_u16; break;
     case SWS_PIXEL_U32: out->func = process_u32; break;
     case SWS_PIXEL_F32: out->func = process_f32; break;
-    default: return AVERROR(EINVAL);
+    default: av_unreachable("Invalid pixel type!");
     }
 
     return 0;
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org