From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 714344F503 for ; Fri, 27 Feb 2026 09:50:12 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'ZR9m1PkYmeD2fOYQ6+Ptvdz2gqyyL7VAxCa4zimGAHw=', expected b'svpRmSha10lYjr8bI0ZkxMIDIAoxFROh8K3+iesMKow=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772185802; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=ZR9m1PkYmeD2fOYQ6+Ptvdz2gqyyL7VAxCa4zimGAHw=; b=ApBd4eRDSSKXlArQDuiPNBkOdLddyru0oDgdGL8sIEEtPrcICzi1X96isN40J0axfsJzb aqdAy/LXrzl/+5UYTcnMWWHQog45uaeDVWdK2U2wg0KFefxeROs3ac3VShrbDPuFFkSMBD+ ekh7Q8oQl2ynbCbc3vJktoWzOwwvNbq9sXQPygcVLHRhKacWhjUPOIk7JcS9pneMebMKrQ5 fZtU3QtcWA2Bjee+KIYPYFrT1Q8ubpvW0zaUh3pOW56p0RVkg8cbAd/gDXNC/QYsjDttWX8 oPk0U+EaFiw2rBIXAQASdu/ffDce86h+wx4YexavdJQF+yLT6vVlT7HIQ9TA== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3ECF6691382; Fri, 27 Feb 2026 11:50:02 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772185788; b=rQ85COKMzrLMh6CDEQwy3FxdZr2ZYnyLWyiPUX1wdjdXGKMgCJzkMPU9RFjBlpEj8rSAN xrDLYYdqqdbJ5PTfYgVif3oa6HJSjzLW44Mssy48fO1J8fcSbHYBerNEPl4giMkR13O9JOQ fFQJgnWEih9ymfwSwirV5PjQLR1AScqjXD2D1D4l2AIEzl4G/ne4Am3OCoor58TMNRAXR1S FWE2HCj0lIbgz2wr72l6SgxPLaSkhACcaiY8UAHm5vY7XmFwk588QurGYrjRZag86ryYYxF 2Cy1NJAGFNJgx2AatmyXcJZcExFqOYJSZUqHPfKH7LzTGkQ5f3PmvTn0k5xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772185788; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Zx9Nae5gOwk1EA6YjqBR0IussO75UL1BuYb7oBU0S+I=; b=WPK/ULvDh+fsfVabTu5PWhli7WL6IrFiBAxAq3a5BGuvXslWGU7kGKi1OT0H2TtybDXI+ YS8a5px3KB5RXpx+wtzPCQXnSv2oPU5XzlFr+wCWb2GpRum6eJKkEAQVwYM9kIkkMUtxr/G pnktcMKlzPmSGdqhEusxYF3OinB0UYHIjjr1CMEJvsNFgu+FDpL0cU5oQNZ3sqVLrw/t/9r N449xf4ivesOSdOIK1J3xV2cxsNYxZkoRBqgBHWv+vz/kSbmesj7KC4dIsZno/5zdur4N3Y 098D4viUVUAoaronGDGDABuxYvVKt8P6M8XRVteU3QN87EqkmqWIu+zHRsyw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772185779; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=svpRmSha10lYjr8bI0ZkxMIDIAoxFROh8K3+iesMKow=; b=qhfBNmt71rpZ1KJ/ACS4tc11F9VghiAAJpUSDl1UPa5qOK3EWD17HnBKhoCc9Ya8dZjbL 8lK9MxYIyDwyIWPSatw76TMuofGlnwXh31/UujZXUuGisCErQqtfhyxxlq17Gt5IOYqxdTr QP45K+hE6NUfA+v2/IMTTHZdVI0tjURRbsHa+pL0oppJhHeDUiCXXuzsPYZnPZe6pyyKMfu xrNP91EbErp9pBvpjA1HTjctB/h5p73NI/FOImGRKC/wb6hiu1rR8GltNHSodpJWN6Lb7D0 AM9J5Uu6VL0uYdy1VGgB3Gb3H8NIO4OYl19zTebHT4liryWts3Z9NS5uzAoQ== MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 27 Feb 2026 09:49:39 -0000 Message-ID: <177218577994.25.11583710475883257861@29965ddac10e> Message-ID-Hash: QP7RNVX7YJYWZAE72CELKABP25ABCCYU X-Message-ID-Hash: QP7RNVX7YJYWZAE72CELKABP25ABCCYU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] swscale/utils: sanity check scaling increments (PR #22305) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Alex Teaca via ffmpeg-devel Cc: Alex Teaca Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #22305 opened by Alex Teaca (alex-teaca) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22305 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22305.patch Large frame sizes produce scaling increments that overflow when stored in the c->lumXInc and c->lumYInc int variables. The calculation is performed in int64_t but truncated to int. Later, the incorrect values are passed to initFilter which applies arithmetic operations that produce undefined-behavior. This patch rejects frame sizes where the scaling increments don't fit into int (c->lumXInc and c->lumYInc). Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21588 Signed-off-by: Alex Teaca >>From 72ca1460b24eed0b043115d89a1ae24cda1fbcfa Mon Sep 17 00:00:00 2001 From: Alex Teaca Date: Fri, 27 Feb 2026 11:01:33 +0200 Subject: [PATCH] swscale/utils: sanity check scaling increments Large frame sizes produce scaling increments that overflow when stored in the c->lumXInc and c->lumYInc int variables. The calculation is performed in int64_t but truncated to int. Later, the incorrect values are passed to initFilter which applies arithmetic operations that produce undefined-behavior. This patch rejects frame sizes where the scaling increments don't fit into int (c->lumXInc and c->lumYInc). Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21588 Signed-off-by: Alex Teaca --- libswscale/utils.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 52095ab2c7..ced51c6147 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -1128,6 +1128,7 @@ av_cold int ff_sws_init_single_context(SwsContext *sws, SwsFilter *srcFilter, int dstH = sws->dst_h; int dst_stride = FFALIGN(dstW * sizeof(int16_t) + 66, 16); int flags, cpu_flags; + int64_t tmpLumXInc, tmpLumYInc; enum AVPixelFormat srcFormat, dstFormat; const AVPixFmtDescriptor *desc_src; const AVPixFmtDescriptor *desc_dst; @@ -1219,8 +1220,18 @@ av_cold int ff_sws_init_single_context(SwsContext *sws, SwsFilter *srcFilter, if (!srcFilter) srcFilter = &dummyFilter; - c->lumXInc = (((int64_t)srcW << 16) + (dstW >> 1)) / dstW; - c->lumYInc = (((int64_t)srcH << 16) + (dstH >> 1)) / dstH; + tmpLumXInc = (((int64_t)srcW << 16) + (dstW >> 1)) / dstW; + tmpLumYInc = (((int64_t)srcH << 16) + (dstH >> 1)) / dstH; + + if (tmpLumXInc > INT_MAX || tmpLumYInc > INT_MAX) { + av_log(c, AV_LOG_ERROR, "%dx%d -> %dx%d makes invalid scaling increments\n", + srcW, srcH, dstW, dstH); + return AVERROR(EINVAL); + } + + c->lumXInc = tmpLumXInc; + c->lumYInc = tmpLumYInc; + c->dstFormatBpp = av_get_bits_per_pixel(desc_dst); c->srcFormatBpp = av_get_bits_per_pixel(desc_src); c->vRounder = 4 * 0x0001000100010001ULL; -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org