From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7F0144F4E5 for ; Thu, 26 Feb 2026 21:46:13 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'tT7IzskedAs1QG94I5NTbpO2PY/Gtiu/har6A5ma2TU=', expected b'4G4+oFR7O1+hAPZhEjrQAHl+wN7AdCjYhvaW0G7OLVI=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772142365; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=tT7IzskedAs1QG94I5NTbpO2PY/Gtiu/har6A5ma2TU=; b=GmHqVu8rCiaaiCc5GuiyOWfagCZQUVI7mpSoOFsxJRm4of3oBwS6eHgCfh7zwuY8QVeBU iXs1H0qdUMDqtGCvR/L9KCNH3YDhz+KnUwKizqTFnHWld6Y2Sp1NMO+mJBNCHXJFmBlh+Tk LzPGB6IF59Zze7OXNTJ+HTITQP7OV6TzVJgwDVTNVOk9+6NPEgH0uw8BDOScEcsL16WWsZk 7R03ETajLKnJ4kaImRjcQMicCACV8zlzJCFkY4PEs44E3PPU0gdwfwR8VfyuUZShDFg0sez HVsdggrkT4E99CjHPtelGPtvZH6v3qev/kUkXggvrhNANEMT5+wZirZBodxw== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 60CA969133E; Thu, 26 Feb 2026 23:46:05 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772142351; b=A2ALSHlp9EebAyD4+PUmjvM1HnMJCmvss1ydRCl92sEec7glN7edofOdd0y5O5PCJuRbi RMP5makOC5Ax4Gan97osqHBWlH1TNSK56YXfoYscUI1Cx5Qiqpt4KHywjoA8E6Yx+J8OoAu pBNWmoKklQnniSkRmsoh0+S85GxRew3dfP0mTs/pnl4bd1AnrPq/DP5hofqv/qex9hYCSY2 Ed7p7TxyhAuZwTH5vTO3oziCteCOO0q/CDdNLZWUhygQcLtxVx02X3hUj2iWv6PBnPbvSxf HAx+sdlUQW8NxDJMwKXhyqmzHiyNQmO1ieV0Nrl+J6Xe52RShd6O00fv+Nbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772142351; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=0IDE9T2rrO7Cm6XAyGWa1X3NKpWmmwc8/TC8VB9mYvA=; b=GTEPJY1SLFK8GLb2jB6QVTZgs1B6CHaE5TXopfihIUnqKpDY5maw0kzs8iyFl01ZdEAng Ir8Zx5/POkY3JFGJXesah47SKV44xOfdVmcMV8cw4nG04XQGyLlde6roI+9bV7NdsoPl6zU /KjpFi7RADU8htQquC8n+FT6Bnk02iSwhNHNV7iRJA4u8KkzX5h+R2NnG1lhcDyTQ6uHn0g kBz7iq0tA+CH44PpLd9t8MfraiTdIGiNtiW0Jt0SABPOZtlcOYwAPgfz6LEjo59NjF/hB7r xTxGpu6NCQiw+pVUaaARy3Z+uptpIcHU735FPHC9Zox6mCD9QeWRgTd1dEjQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772142341; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=4G4+oFR7O1+hAPZhEjrQAHl+wN7AdCjYhvaW0G7OLVI=; b=3hoL7ZfuM5CfO1GIAptbqlRzdikOJCc7sPObE2bG+kx/wKZgiYjbLcZrp9i6ogh2LEhbU AIpWhU0kY5dETtju9eqyIvrcDgV9LUZoGWfS6Wmm6V4Wt7BUk0Lqne4FTPc910aisbwp314 jjGW7bfCmpdqK06EhO51RySA0lfdmi/vM+gYq0XXlukB2XPbZMHkNYZilY6yyb9W2MlD3WD oIqNCvhsBCAmeWRhYMCzf5lQtsAMX2yJU7F12fw0Zi5uWfQyTBoMKQxwDflzXwA1bV7mZgx DdWGjXsjeKahj4hGQaMRp/77ivYDFj4kyUnAsAPhJEhbuizF8a1nSGr73xpA== MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 26 Feb 2026 21:45:41 -0000 Message-ID: <177214234206.25.18229853338689612297@29965ddac10e> Message-ID-Hash: QFQNUYZ5HTKNIWOUIKECK4FRI3FHENEE X-Message-ID-Hash: QFQNUYZ5HTKNIWOUIKECK4FRI3FHENEE X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/cngdec: Fix SIGILL issue in cng_decode_frame() (PR #22300) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: yuyong05 via ffmpeg-devel Cc: yuyong05 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #22300 opened by yuyong05 URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22300 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22300.patch The issue is caused by floating-point to integer overflow conversion at function av_clip_int16(p->filter_out[i + p->order]). The float value is -2,441,986,048.0 out of bound, less than INT_MIN(-2,147,483,648), which leads to UB and SIGILL crash. - Handle NAN using isfinite() - Clip float value into valid range of int16 with av_clipf >>From 93a0975bac8d0dc371da04195210c7cd6070646b Mon Sep 17 00:00:00 2001 From: Yong Yu Date: Thu, 26 Feb 2026 13:35:10 -0800 Subject: [PATCH] avcodec/cngdec: Fix SIGILL issue in cng_decode_frame() The issue is caused by floating-point to integer overflow conversion at function av_clip_int16(p->filter_out[i + p->order]). The float value is -2,441,986,048.0 out of bound, less than INT_MIN(-2,147,483,648), which leads to UB and SIGILL crash. - Handle NAN using isfinite() - Clip float value into valid range of int16 with av_clipf --- libavcodec/cngdec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/cngdec.c b/libavcodec/cngdec.c index eb37c33eb4..b46f5fef95 100644 --- a/libavcodec/cngdec.c +++ b/libavcodec/cngdec.c @@ -153,8 +153,10 @@ static int cng_decode_frame(AVCodecContext *avctx, AVFrame *frame, if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) return ret; buf_out = (int16_t *)frame->data[0]; - for (i = 0; i < avctx->frame_size; i++) - buf_out[i] = av_clip_int16(p->filter_out[i + p->order]); + for (i = 0; i < avctx->frame_size; i++) { + const float f = p->filter_out[i + p->order]; + buf_out[i] = !isfinite(f) ? 0 : lrintf(av_clipf(f, INT16_MIN, INT16_MAX)); + } memcpy(p->filter_out, p->filter_out + avctx->frame_size, p->order * sizeof(*p->filter_out)); -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org