[FFmpeg-devel] [PR] RFC: Add preference of narrow variable scope, especially in loops, to the docs (PR #21808)

[FFmpeg-devel] [PR] RFC: Add preference of narrow variable scope, especially in loops, to the docs (PR #21808)

[Marvin Scholz via ffmpeg-devel]

PR #21808 opened by Marvin Scholz (ePirat)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21808
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21808.patch


>From cdadf39f25d4ab4004da9f7244e888d53ee84946 Mon Sep 17 00:00:00 2001
From: Marvin Scholz <epirat07@gmail.com>
Date: Thu, 19 Feb 2026 22:43:04 +0100
Subject: [PATCH] doc: add narrow variable scope in loops to style examples

---
 doc/developer.texi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/doc/developer.texi b/doc/developer.texi
index 10a2de00df..e5c33bbcae 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -224,6 +224,25 @@ AVStream *stream;
 AVStream* stream;
 @end example
 
+@item
+When sensible, prefer a narrow variable scope, especially in for loops:
+
+@example c, good
+// Good
+for (unsigned i = 0; i < submix->nb_elements; i++) {
+    // Do something...
+}
+@end example
+
+@example c, bad
+// Bad style
+unsigned i;
+//...
+for (i = 0; i < submix->nb_elements; i++) {
+    // Do something...
+}
+@end example
+
 @end itemize
 
 If you work on a file that does not follow these guidelines consistently,
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org