From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1040A4EEBC for ; Thu, 19 Feb 2026 13:31:26 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'y6XE2vUNOr5znQFQiSsVmyWcQrBuWov+hVRBZOshzPw=', expected b'HXTlf8Ggq8LeTjwmBSr03lwjMICQ7gSP34ISs93Wx4o=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1771507876; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=y6XE2vUNOr5znQFQiSsVmyWcQrBuWov+hVRBZOshzPw=; b=R7bVV4VIhW1twTpc9X9D+mKnuKqcFMRUomfnG+Pp+Sd2CkfuUQedHcwrGmtayCwGGkL+N ogLmwsScEPTXSA25O1FPepovYpFFu0cfGLXCV5c5i/Rqgb0B/Tfmyi11liHGuZ9x1IiP9jW z5jh2MFnCtEqWU8RRwxQLZmX2gfa5gfqlfwq2wcFw2gj3ByJ0py9YmG617NHIdpbptMyv2i kG9OaRG6htlXen0XH5saPNIYA1G4lnYEGVZeBxJxENA89nlGU9CJTJwGGSYxyrPYz1AgiB9 KW5IZ1tha+QpZAnxNVI/pf14LSWcXXvL75O4p69wjPk5YJz3tgVmUNGRWjPg== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4ED3569139F; Thu, 19 Feb 2026 15:31:16 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1771507865; b=PlZtBb02GqTXriJSg+MqhcswHccs7mY4JGknPpPCjAqbyiGOMAgb59piDy/3X4X1tOW7g +ObaxNEiBPJToSPSXXgmXvgVT6bGQRmia62uqFaGdv7sXnjhpSOWl1AzqZLZj9OKUi1nyUM Ubw7EDx+CaKXgzF8USEItOPbuOjX4NzFUGHRM8xbzRkgKHHlEsgSrvhPwqOJxyW6EL55vJd Hj/kjt8ylxgBJWpj7uqgqcUO5EyQMQNUuIkUL1kN6kpfr3FAft0WkTpfm6jDaKDbGgSLpyo Nqp1mkWiNHPCn2bdxbqMt70Y18kLXNw+Vqqh1/ta5EbZtl4hU91sl787ZdXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1771507865; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=J1eAv43rfNXarFj9Cea+xjrrpB8ac4FgKnZR/lCnkzE=; b=udqq5Nfswld5Z+wZIonE27FtEIDeDVBhX8i1afy35qMX0p+YpgZg6aUEzzCGMIT489Y4b DiRi7cQeB/GO6lWQsVNSrD280KHvS+I3fLCi42q4yQPtda9ddAuubORkjevCh/g2ib/mCE8 LF2enI8N72nTAzIod+uCFT/BIP67rl15lVk3SFG6REO/4O15q3yz40ZN7C105dy8A2p5Pe5 cl/bNe6Ua8LMNFBwIFCJAsTjYFOtOkEYxweZAgGikWN2gOTsqYUtt8Ug5P+atAqm0wcLQPI IaykRZl6sSJb30/joNQgiengKg9kvb4L5xpCrNBLRrBfGWfF6mzd4v+6gIWg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1771507856; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=HXTlf8Ggq8LeTjwmBSr03lwjMICQ7gSP34ISs93Wx4o=; b=OuQ7OWyqe7xfygULlwArYo0JoK09cky/ZXNdG9TB7sxqKXDze4XgqNwbOczJ7GKz9KJ4C cejXiLQjB2/97a2gfJLf92TEP4WXwuMUSQQm+CCHXRjfuZQaGujAOa5z4TgD8juQgpKzx4d fVrXHqw6ioHdlatW5FrYaKmHtAShOr2BVja3hVvgwjmOUKBOLaXPjy7EfnR5YCl/UynCqRs cwm7/7sr3EM/MJDFnzk9vNOKBk/FK9INQXwKrc/1tyso5gxVDteNtUGdzoFC6YNBjxm6x0a NMUNv0zmfchA3ZGISBpVW7VV5kDsrrlcxOnzFFAddfcV/7QMB8AD2eHhwJBA== MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 19 Feb 2026 13:30:56 -0000 Message-ID: <177150785696.25.4521241190467802929@29965ddac10e> Message-ID-Hash: 6HMRC4EU4RA5PWA5XDOQX7GKRSLDAKWR X-Message-ID-Hash: 6HMRC4EU4RA5PWA5XDOQX7GKRSLDAKWR X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avfilter/af_loudnorm: Avoid unchecked allocation (PR #21795) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21795 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21795 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21795.patch Also deduplicate printing json and summary output. >>From 4d5e74ac2f88aad895ff64329ee1384fd12ed2a7 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Thu, 19 Feb 2026 14:26:33 +0100 Subject: [PATCH] avfilter/af_loudnorm: Avoid unchecked allocation Also deduplicate printing json and summary output. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_loudnorm.c | 36 ++++++++++-------------------------- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c index e9cc40baa6..17b819b185 100644 --- a/libavfilter/af_loudnorm.c +++ b/libavfilter/af_loudnorm.c @@ -20,7 +20,6 @@ /* http://k.ylo.ph/2016/04/04/loudnorm.html */ -#include "libavutil/avstring.h" #include "libavutil/file_open.h" #include "libavutil/mem.h" #include "libavutil/opt.h" @@ -834,7 +833,6 @@ static av_cold void uninit(AVFilterContext *ctx) double i_in, i_out, lra_in, lra_out, thresh_in, thresh_out, tp_in, tp_out; int c; FILE *stats_file = NULL; - char *stats = NULL; if (!s->r128_in || !s->r128_out) goto end; @@ -879,7 +877,9 @@ static av_cold void uninit(AVFilterContext *ctx) break; case JSON: - stats = av_asprintf( + case SUMMARY: { + char stats[1024]; + const char *const format = s->print_format == JSON ? "{\n" "\t\"input_i\" : \"%.2f\",\n" "\t\"input_tp\" : \"%.2f\",\n" @@ -891,25 +891,7 @@ static av_cold void uninit(AVFilterContext *ctx) "\t\"output_thresh\" : \"%.2f\",\n" "\t\"normalization_type\" : \"%s\",\n" "\t\"target_offset\" : \"%.2f\"\n" - "}\n", - i_in, - 20. * log10(tp_in), - lra_in, - thresh_in, - i_out, - 20. * log10(tp_out), - lra_out, - thresh_out, - s->frame_type == LINEAR_MODE ? "linear" : "dynamic", - s->target_i - i_out - ); - av_log(ctx, AV_LOG_INFO, "\n%s", stats); - if (stats_file) - fprintf(stats_file, "%s", stats); - break; - - case SUMMARY: - stats = av_asprintf( + "}\n" : "Input Integrated: %+6.1f LUFS\n" "Input True Peak: %+6.1f dBTP\n" "Input LRA: %6.1f LU\n" @@ -921,7 +903,9 @@ static av_cold void uninit(AVFilterContext *ctx) "Output Threshold: %+6.1f LUFS\n" "\n" "Normalization Type: %s\n" - "Target Offset: %+6.1f LU\n", + "Target Offset: %+6.1f LU\n"; + + snprintf(stats, sizeof(stats), format, i_in, 20. * log10(tp_in), lra_in, @@ -930,7 +914,8 @@ static av_cold void uninit(AVFilterContext *ctx) 20. * log10(tp_out), lra_out, thresh_out, - s->frame_type == LINEAR_MODE ? "Linear" : "Dynamic", + s->frame_type == LINEAR_MODE ? (s->print_format == JSON ? "linear" : "Linear") + : (s->print_format == JSON ? "dynamic" : "Dynamic"), s->target_i - i_out ); av_log(ctx, AV_LOG_INFO, "\n%s", stats); @@ -938,10 +923,9 @@ static av_cold void uninit(AVFilterContext *ctx) fprintf(stats_file, "%s", stats); break; } + } end: - if (stats) - av_free(stats); if (stats_file && stats_file != stdout) fclose(stats_file); if (s->r128_in) -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org