From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 789AB4EE4B for ; Tue, 17 Feb 2026 20:05:44 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'P7LWxnNwM+fAaoffRaNO+nQy+cBUq6D1jkkJOi3lmXw=', expected b'NtGwZna1GC8ZgK7UUumW/s6xOW2FhAk57PM82HWTw4k=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1771358737; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=P7LWxnNwM+fAaoffRaNO+nQy+cBUq6D1jkkJOi3lmXw=; b=jMqAaaZtdHUW4K7A/5Ekko/Zo/HmMZ+GFsqei+dh/LE9b9CGV5TlK/nCXnVQepMW6m1/a bhghcrB4DCgSwfx6N8RVa/Q08Zf2J8CPv9gJkPOekDgB88lFZl2nomlb9PxE1P2fGSX/x9e pA9ZmOZB5Alxce0N1pLGZ7+pcTZHI0PO+Xj0dHHmf7dSOU6sdiX1imhjVfnTY782EgH+RgG JnqlG1D4pmkh+knX5+fpMj1VxcAlyqvFLutL7MUol5/knNowBejJfNaWqnaEHAkyrcReL+E RNsMzBU0TAHgViGmpgwn2/XPwhU+xLGmwqxQkFnNUcc6JrYCB7dGSZRfx11w== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5A06F6911F4; Tue, 17 Feb 2026 22:05:37 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1771358724; b=jewiXTYPatxd43d+FpzWQaPJ76PeXKAAawDZng3f7AjmaH6yd9pGpF7s4HNaPC8Kccoq5 9xX6jvKnIAN56/jEott3xq5ET4ksq7JZCQ5+0Skgj3Dh3278/MZtOLLjYgtifFJuV9L8y65 3CQ6otmhL4td7nckSVIGr8Mbkj1v1dcyCaCsFJAVPjNW/+4ljNji+rvgv6MJmIsPRwoILWa X1/uqIGuWC44M6IXXzqfbmmMrrtCdVQcavi3zNs/KJQwP3l/lNJU3pErneKZsPW3HXLvRA2 vi3i1housrjS1FvIQJLqcl4XO8uAyG8IRaOCG7/U58rRFO4CklpmZHCN22mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1771358724; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=VDFborUcypOwYgvL1c6LRcPzW+U0l/nRjSqfA7/vCwE=; b=RjJZBte7byah/uoMgobyKXNbYfwlV0iwBuRS0F9+CnbRJkvufBBe/1wskO9jGMVe/OpuE ryjxMmiFFPDdUtG2yssNNPxLiuPwZ1tGw8tYqxBJHRSP2pxzV+J8IpyUjcKXpiEsSk6jaLu MqrnUwl7HrGkpOJee+6KfPVtZ7DAGf2F6K1FycsJPd3C+Oilg72rSix0Rl0KJdTVszMUtxU jXlaJKewQOZPEa9l6Wc7DTaQ7tYfTXj2ByLViz781xhXi191b3Y3oFn8JI7N4nyx8XFhidq XmfWf70yc1gatpZWivZC1yEcL8cbneLuS0W1IbiEof+8YiuhFg4AJAPYfbUw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1771358714; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=NtGwZna1GC8ZgK7UUumW/s6xOW2FhAk57PM82HWTw4k=; b=d3Z01TLhblBMMwdE4xRg2DVUYPkdwqGU7ZV4qLgvBTOwALC/iaxHCwIu4nY8QO2Gv9pwF TP+VGXwOh5DTqJUOwcYQmNU4NpBaVfxCSrZeseYVgse2jfo028+RbRcJxu5Pm8p57eJixnT tmyEJR9495pOAYWEijwompGFFgUtKjlWzOL8wTPk59K3RDci3Sjso60nIBWraJUJtANtNAD qkNXvtgYXqLYIu8V5AFNfRl+yyZj4ErzEK7aHEsURog8rQeT7Lhkanvd/f99UcjcbtNh7NY HUEJF3ltiduCLWeRyTaMLVcjMkkwayTb7Xz9E5aoucMI2PEAwO75Gp7eodjw== Received: from c8d966988b92 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9821B691164 for ; Tue, 17 Feb 2026 22:05:14 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Feb 2026 20:05:14 -0000 Message-ID: <177135871478.25.6926878858532365435@29965ddac10e> Message-ID-Hash: PVD2ORXK642IN5VIGP4QUNUEEVNNZOXR X-Message-ID-Hash: PVD2ORXK642IN5VIGP4QUNUEEVNNZOXR X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avfilter/vf_drawtext: fix newline being shown as glyph (PR #21776) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: AnandajithS via ffmpeg-devel Cc: AnandajithS Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21776 opened by AnandajithS URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21776 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21776.patch During processing, the newline character is included in the range passed to shape_text_hb because the pointer representing the current character is moved forward by GET_UTF8 macro before newline check, which causes it to create a notdef glyph This PR fixes the issue by adding a check condition in shape_text_hb to exclude the newline character Fixes #21565 Signed-off-by: AnandajithS >>From 675631f6cde9447c8e206a3a4367fab636370329 Mon Sep 17 00:00:00 2001 From: AnandajithS Date: Wed, 18 Feb 2026 00:54:20 +0530 Subject: [PATCH] avfilter/vf_drawtext: fix newline being shown as glyph During processing, the newline character is included in the range passed to shape_text_hb because the pointer representing the current character is moved forward by GET_UTF8 macro before newline check, which causes it to create a notdef glyph This PR fixes the issue by adding a check condition in shape_text_hb to exclude the newline character Signed-off-by: AnandajithS --- libavfilter/vf_drawtext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 2812de37f5..de6c61aea3 100644 --- a/libavfilter/vf_drawtext.c +++ b/libavfilter/vf_drawtext.c @@ -1458,7 +1458,7 @@ continue_on_failed2: TextLine *cur_line = &s->lines[line_count]; HarfbuzzData *hb = &cur_line->hb_data; cur_line->cluster_offset = line_offset; - ret = shape_text_hb(s, hb, start, p - start); + ret = shape_text_hb(s, hb, start, p - start - (code?1:0)); if (ret != 0) { goto done; } -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org