[FFmpeg-devel] [PR] avfilter/vf_drawtext: fix newline being shown as glyph (PR #21776)

[FFmpeg-devel] [PR] avfilter/vf_drawtext: fix newline being shown as glyph (PR #21776)

[AnandajithS via ffmpeg-devel]

PR #21776 opened by AnandajithS
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21776
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21776.patch

During processing, the newline character is included in the range
passed to shape_text_hb because the pointer representing the current
character is moved forward by GET_UTF8 macro before newline check,
which causes it to create a notdef glyph

This PR fixes the issue by adding a check condition in shape_text_hb
to exclude the newline character

Fixes #21565

Signed-off-by: AnandajithS <anandajiths2006@gmail.com>


>From 675631f6cde9447c8e206a3a4367fab636370329 Mon Sep 17 00:00:00 2001
From: AnandajithS <anandajiths2006@gmail.com>
Date: Wed, 18 Feb 2026 00:54:20 +0530
Subject: [PATCH] avfilter/vf_drawtext: fix newline being shown as glyph

During processing, the newline character is included in the range
passed to shape_text_hb because the pointer representing the current
character is moved forward by GET_UTF8 macro before newline check,
which causes it to create a notdef glyph

This PR fixes the issue by adding a check condition in shape_text_hb
to exclude the newline character

Signed-off-by: AnandajithS <anandajiths2006@gmail.com>
---
 libavfilter/vf_drawtext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
index 2812de37f5..de6c61aea3 100644
--- a/libavfilter/vf_drawtext.c
+++ b/libavfilter/vf_drawtext.c
@@ -1458,7 +1458,7 @@ continue_on_failed2:
             TextLine *cur_line = &s->lines[line_count];
             HarfbuzzData *hb = &cur_line->hb_data;
             cur_line->cluster_offset = line_offset;
-            ret = shape_text_hb(s, hb, start, p - start);
+            ret = shape_text_hb(s, hb, start, p - start - (code?1:0));
             if (ret != 0) {
                 goto done;
             }
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org