Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/apv_dsp: Fix left-shift of negative value
Date: Wed, 30 Apr 2025 22:32:58 +0100
Message-ID: <1770fdfc-7434-4928-b504-c64487baa43e@jkqxz.net> (raw)
In-Reply-To: <GV1P250MB07376EDF15694AFA6209167A8F832@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

On 30/04/2025 19:26, Andreas Rheinhardt wrote:
> Patch attached.
> 
> - Andreas

Hmm, the spec does write exactly this but also defines << as arithmetic left shift of a two's complement representation so it works.

Seems fair, LGTM.

More generally this line is not robust to extreme values (can integer overflow 32 bits), but the cases which do this are not useful and won't be in real streams (if calculated at full precision they would always be far outside the possible coefficient range from a forward transform, so it takes a crafted encoder to make them).

Possibly a pre-clip to a calculated range which ensures it doesn't go too far outside the following clip range is the right answer to avoid the overflow?  I will think about this a bit more.

Thanks,

- Mark

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-04-30 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 18:26 Andreas Rheinhardt
2025-04-30 21:32 ` Mark Thompson [this message]
2025-04-30 21:56   ` Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1770fdfc-7434-4928-b504-c64487baa43e@jkqxz.net \
    --to=sw@jkqxz.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git