Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] avformat/http: add missing check to connection re-use (PR #21702)
Date: Mon, 09 Feb 2026 15:45:58 -0000
Message-ID: <177065195912.25.12358963401781127178@4457048688e7> (raw)

PR #21702 opened by Niklas Haas (haasn)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21702
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21702.patch

Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21685
Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21693
Fixes: e03b034e45e68450e16f913c8aaf5ec362bc1446


>From 71030aec6eedaa9b103b7e43df813304179a7e8e Mon Sep 17 00:00:00 2001
From: Niklas Haas <git@haasn.dev>
Date: Mon, 9 Feb 2026 16:41:52 +0100
Subject: [PATCH] avformat/http: add missing check to connection re-use

Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21685
Fixes: https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21693
Fixes: e03b034e45e68450e16f913c8aaf5ec362bc1446
---
 libavformat/http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/http.c b/libavformat/http.c
index 805e3eff9f..5c91c67527 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -2119,7 +2119,7 @@ static int64_t http_seek_internal(URLContext *h, int64_t off, int whence, int fo
 
     /* try to reuse existing connection for small seeks */
     uint64_t remaining = s->range_end - old_off - old_buf_size;
-    if (!s->willclose && s->range_end && remaining <= ffurl_get_short_seek(h)) {
+    if (s->hd && !s->willclose && s->range_end && remaining <= ffurl_get_short_seek(h)) {
         /* drain remaining data left on the wire from previous request */
         av_log(h, AV_LOG_DEBUG, "Soft-seeking to offset %"PRIu64" by draining "
                "%"PRIu64" remaining byte(s)\n", s->off, remaining);
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2026-02-09 15:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177065195912.25.12358963401781127178@4457048688e7 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git