From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2263C4E963 for ; Mon, 9 Feb 2026 01:59:01 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'LSS2dVBJ081rb3nyqsphTLX48oT++9ewNzkbwNEWHaQ=', expected b'xTs519CP+j9I9KC/YcX7jnoN9MLfonmD7wfjT878H+c=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1770602331; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=LSS2dVBJ081rb3nyqsphTLX48oT++9ewNzkbwNEWHaQ=; b=vYZXC2ThK4M+1auGDWlyLkCJu0iY9uT7bVzT8PeGbGwexkMu6xxO6Osx+FMt4w6yrEMQY u5h21fBuQ3GDTubAQ2F/IfP++GBR3pYucuwSXWVMbZIdkKa4K3iLFB4FR/s1Eww7Nunpl2h wjMXkyonVNUl7rHLeqNr4b9qe6xLp5/zjrCO24JR+T9UmYZOjHZma7OrmY/ehPwHw9FUaSr jF6EqRi+OzJf2kfvrbfLZYvQPnqIQQxNAr+7VzXHP2WyP49cfhczUCOlxVFRhKN24YyzIE9 D+5tWQM0updaq0r9xKHEEVCjuESlNr1uNZVqsi7z0Fxp7cH+Ym47fnj1/V1A== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 92A59690E1C; Mon, 9 Feb 2026 03:58:51 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1770602315; b=g0x2JWoX3122QZ46Ifq6IZzmSGaE3Jw0RIMAPZjF9xC0GRP23/RxnjweZ06Ms1QVmXEkI wJuCDY4zCdNGd76UT7BcseSc5CCdAtY8c+qIjmlB6VA0d9jMOfxudpBKi80tq9XWfG6Swni nAWRpK+TJ3i0vhZ3LqcO2PuttToX2zL9VLaojXJYaFdm3ZSgH5sR8cW2DTTyNjsMJrNlAug 73FHGnyRpGWupO/mHt0lA8Xkq30wrsRBSprXHCFp4pY9HFzGlKcRNGv7az4WVk8WQZ8oUXV VfMR+OSuNXvWcVXRGMk0QMJqiRSKgFtVJsCDRVhZghHg9uuVBLkd5Te59qnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1770602315; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=PcJmSA/AWOR0VLzORdyMQMm8DV5YHvJoES45YTBJZvM=; b=XQ2Rq8Z7kxV6epylWwV9Wwc2Olkpq6M7x/jJ848RHlLCQ3GfbWikpUfbQjK6ySMCavQyg ADdJi571c2EuK50T9i5FF4X4j7dqkuhvFcFuGguPPT4471czmde4twiu0na/Pxen0QJmu3y 2OTE82lPMpADifLUnh1A1sHC4/Dstkzz9m0LvT6DSwx16DAJdrilw1ekTj+Gj24UR7G1VX7 5wlmAVrfQEC7oSGWXsI/rjW+Koxy7Cfsxroi0ON7SKIqGS9a/0J3fM4R+jqzUwmhLO+spU0 r9+LLDtz8/M9JMxobbEO6Y4VaIqbasPF0FARS4TXUOLJwOfqepJAu9hPhPcw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1770602308; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=xTs519CP+j9I9KC/YcX7jnoN9MLfonmD7wfjT878H+c=; b=Cg+Syd50fyhmP0nmx+zTwWxoGutnCVFAJUG+9KRx7Ot2LG2kAWG23TaNaulMpghp2tYo3 d9LYqhyZdkxv0hEAHX57FqbTxvND9tigm0ziO0i91llkiWck3i1nH5CINvd5b0XSoa8wi43 /ahTKaeEttBriUwdAbMsus9Xj+twCIjQ/0J9tXd1/AsbYTbZeMf2yPV9qhC3nml4UYtr/dj o/lIcBFTr++5qA8ZTs8Ku7nJ8Ig1bRc0ugrMCvzQLQqDLLbwAzhScOuzjzVvZpa1AsZQ0qy Uqmm5XcclfD+DDYECOdaRL3xDY+nB0LBx5Z2jyKjUTnU4/6YE4f2UjQjNXwg== Received: from c8d966988b92 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 42E0368EB77 for ; Mon, 9 Feb 2026 03:58:28 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 09 Feb 2026 01:58:27 -0000 Message-ID: <177060230842.25.11336403003573118283@4457048688e7> Message-ID-Hash: GG4R5WUPN3FP6TOD7BNM3DCOHZAMDQGE X-Message-ID-Hash: GG4R5WUPN3FP6TOD7BNM3DCOHZAMDQGE X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/dpcm: Remove unnecessary flush callbacks (PR #21690) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21690 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21690 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21690.patch >>From bd119f7d406207b27cfe1bfa70f7d47bc5401927 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 9 Feb 2026 02:34:17 +0100 Subject: [PATCH 1/2] avcodec/dpcm: Avoid trailing '_' in macro parameters Signed-off-by: Andreas Rheinhardt --- libavcodec/dpcm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/dpcm.c b/libavcodec/dpcm.c index edeb1aae72..fed6f76124 100644 --- a/libavcodec/dpcm.c +++ b/libavcodec/dpcm.c @@ -466,12 +466,12 @@ static av_cold void dpcm_flush(AVCodecContext *avctx) s->sample[0] = s->sample[1] = 0; } -#define DPCM_DECODER(id_, name_, long_name_) \ -const FFCodec ff_ ## name_ ## _decoder = { \ - .p.name = #name_, \ - CODEC_LONG_NAME(long_name_), \ +#define DPCM_DECODER(ID, NAME, LONG_NAME) \ +const FFCodec ff_ ## NAME ## _decoder = { \ + .p.name = #NAME, \ + CODEC_LONG_NAME(LONG_NAME), \ .p.type = AVMEDIA_TYPE_AUDIO, \ - .p.id = id_, \ + .p.id = ID, \ .p.capabilities = AV_CODEC_CAP_DR1, \ .priv_data_size = sizeof(DPCMContext), \ .init = dpcm_decode_init, \ -- 2.52.0 >>From 6d8c4c8284c2d463f489875cfa6ce5cc841c205b Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 9 Feb 2026 02:42:15 +0100 Subject: [PATCH 2/2] avcodec/dpcm: Remove unnecessary flush callbacks {INTERPLAY,ROQ,XAN}_DPCM does not use the stored samples at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/dpcm.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/dpcm.c b/libavcodec/dpcm.c index fed6f76124..39df47dcfa 100644 --- a/libavcodec/dpcm.c +++ b/libavcodec/dpcm.c @@ -466,7 +466,7 @@ static av_cold void dpcm_flush(AVCodecContext *avctx) s->sample[0] = s->sample[1] = 0; } -#define DPCM_DECODER(ID, NAME, LONG_NAME) \ +#define DPCM_DECODER(ID, NAME, FLUSH, LONG_NAME) \ const FFCodec ff_ ## NAME ## _decoder = { \ .p.name = #NAME, \ CODEC_LONG_NAME(LONG_NAME), \ @@ -475,16 +475,16 @@ const FFCodec ff_ ## NAME ## _decoder = { \ .p.capabilities = AV_CODEC_CAP_DR1, \ .priv_data_size = sizeof(DPCMContext), \ .init = dpcm_decode_init, \ - .flush = dpcm_flush, \ + .flush = FLUSH, \ FF_CODEC_DECODE_CB(dpcm_decode_frame), \ } -DPCM_DECODER(AV_CODEC_ID_CBD2_DPCM, cbd2_dpcm, "DPCM Cuberoot-Delta-Exact"); -DPCM_DECODER(AV_CODEC_ID_DERF_DPCM, derf_dpcm, "DPCM Xilam DERF"); -DPCM_DECODER(AV_CODEC_ID_GREMLIN_DPCM, gremlin_dpcm, "DPCM Gremlin"); -DPCM_DECODER(AV_CODEC_ID_INTERPLAY_DPCM, interplay_dpcm, "DPCM Interplay"); -DPCM_DECODER(AV_CODEC_ID_ROQ_DPCM, roq_dpcm, "DPCM id RoQ"); -DPCM_DECODER(AV_CODEC_ID_SDX2_DPCM, sdx2_dpcm, "DPCM Squareroot-Delta-Exact"); -DPCM_DECODER(AV_CODEC_ID_SOL_DPCM, sol_dpcm, "DPCM Sol"); -DPCM_DECODER(AV_CODEC_ID_XAN_DPCM, xan_dpcm, "DPCM Xan"); -DPCM_DECODER(AV_CODEC_ID_WADY_DPCM, wady_dpcm, "DPCM Marble WADY"); +DPCM_DECODER(AV_CODEC_ID_CBD2_DPCM, cbd2_dpcm, dpcm_flush, "DPCM Cuberoot-Delta-Exact"); +DPCM_DECODER(AV_CODEC_ID_DERF_DPCM, derf_dpcm, dpcm_flush, "DPCM Xilam DERF"); +DPCM_DECODER(AV_CODEC_ID_GREMLIN_DPCM, gremlin_dpcm, dpcm_flush, "DPCM Gremlin"); +DPCM_DECODER(AV_CODEC_ID_INTERPLAY_DPCM, interplay_dpcm, NULL, "DPCM Interplay"); +DPCM_DECODER(AV_CODEC_ID_ROQ_DPCM, roq_dpcm, NULL, "DPCM id RoQ"); +DPCM_DECODER(AV_CODEC_ID_SDX2_DPCM, sdx2_dpcm, dpcm_flush, "DPCM Squareroot-Delta-Exact"); +DPCM_DECODER(AV_CODEC_ID_SOL_DPCM, sol_dpcm, dpcm_flush, "DPCM Sol"); +DPCM_DECODER(AV_CODEC_ID_XAN_DPCM, xan_dpcm, NULL, "DPCM Xan"); +DPCM_DECODER(AV_CODEC_ID_WADY_DPCM, wady_dpcm, dpcm_flush, "DPCM Marble WADY"); -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org