[FFmpeg-devel] [PR] avcodec/adpcm: Check input buffer size (PR #21683)

[FFmpeg-devel] [PR] avcodec/adpcm: Check input buffer size (PR #21683)

[michaelni via ffmpeg-devel]

PR #21683 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21683
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21683.patch

Larger values will lead to integer overflows in intermediates
No testcase

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>


>From 529ebd983d6aae9d0939669c5265dd69bfff2664 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <michael@niedermayer.cc>
Date: Sun, 8 Feb 2026 02:52:54 +0100
Subject: [PATCH] avcodec/adpcm: Check input buffer size

Larger values will lead to integer overflows in intermediates
No testcase

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/adpcm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index 31340af677..bd9ad2933f 100644
--- a/libavcodec/adpcm.c
+++ b/libavcodec/adpcm.c
@@ -1173,6 +1173,8 @@ static int get_nb_samples(AVCodecContext *avctx, GetByteContext *gb,
 
     if(ch <= 0)
         return 0;
+    if (buf_size > INT_MAX / 2)
+        return 0;
 
     switch (avctx->codec->id) {
     /* constant, only check buf_size */
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org