From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3CFB04E863 for ; Fri, 6 Feb 2026 13:57:08 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'U4SVlh5LFGIstnmZYnqwQ/D/rxsXytjxH/UXeDFU2Bs=', expected b'lE6j9KOX4f2E6v48uHGxTTMGZGmO0emcXYmUr9QoVH8=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1770386220; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=U4SVlh5LFGIstnmZYnqwQ/D/rxsXytjxH/UXeDFU2Bs=; b=fs1H46kRZ0gRMUPmAvX0nswCnmGM/nl3D4awXIoZ6f69qfsKkvvICur2xseWazK3G1Zap xLLvUSHOdddY2CAfThH7SrS4g5Wg9lAgAWVex/eg6Dyswr6z+z3LFNdx+uCOWTL8J/i1YdY GDQ00n/Pj289giHuC6gkZQA8zdPaREWhOX211R+94iFWXnD4wC8re2tS6MNFjlg3/62Dkv0 C5a25fi9aZ28h1Vj5dIksZrOo6Lb5P2xKfHf/6uSc39gOoXd75NuiDyEfV0ciLhOlyBretH jHRDAPfNDorNgy1F9g0mX2FCt7FOxTclH/VGHI5YKYPaziPX8UbtfJlRpC9A== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2648C691101; Fri, 6 Feb 2026 15:57:00 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1770386204; b=iyR9Vm4ixLYyToXtKZ/x55b4YGrVUDzRNg2GL5mWGuClorJRx2llvJyRiuCK5F54nsS5a jkG3pIauhL5k0tOlT4HfmlCCiAdNoM05+vSHvUkx49uS4IjJBcUUPlNNsFAnGk1EwIzeWGI 6WRrL2Nh33VL0JC7GKKrraChWihKo5wcpcB0Fun5WnK58KHSc7Uf/bqGy0ToiUnVHlYF3ik V1u5k8kUKyC4TeC1NSBrreKXkbSUQSXWT4F/w/+r+tYIMwYM7GiGjnh0FjSufKSU+e+QJab qKGJ5RnA2I+Kr21UZ9c/GJg0QhXBK38TrjzjwnzVz2tRuuXZtc0Z/DWXqLZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1770386204; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=GNd36HHDoS1EhsLITTWQURG8JoTgdbMlUl8yV3iKFOk=; b=rVXjPKwSyrA1yoMWgKD/G34cRvPAHh4spbEYuSdtmXwlbsYrOkQiXMY92YyEkT8EZoo/k hW5b9zrpEbLFT0aXb9QKTt0EN+NQRrL3l0gvpDqK10e6+c4eCbzKW1kc9QyHHFRTMWXjgOt RS3TfdCWkXfiAQ+WGrHuPsoLqAUrLKZbYZAal+3xL5Eh71zs2iHUL9lUceIa8kMNAls+Aso Wu+7kD+4HzW0dn7uADV9qEG9rbhNJhsPOtb4PNFAOr9BXSouJ+k3fyIRufbDsR2AUtUq7DK MxqmYEsubBgxcFUPBZ0CSq+c7nlny9rDJA3ZJdnp0gYSyAkvxgXWayvY5t0A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1770386196; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=lE6j9KOX4f2E6v48uHGxTTMGZGmO0emcXYmUr9QoVH8=; b=WxeCDCVDKqft3phrA3OqICDj7dbsRk5GXRIwgtQrntX4EF1KHc+AQyU9lz6iWIvL69wO8 1SGwcD47HaP3guUd5T/ASOKNrIjcndwij/oRK8GRtFEG4LEt6e8Xm5C08wFoCbGmf1jG98e evwOX6rW7/Lxfu5ZXSyq3yDy2Vq4VsI+X5SSWXZL7u+8c368L4XJ/ydMKG/slLmaIrGgmFo gEPOR/fWTHeslTrwGsLnBThCSjW3UTTCrBF1Ds2ht2spAUXsVrJ0NrzbXsfgYwARQq+lFOm AuOhPfDKXIF3e6E+23G8RtVX/VGjCGXvMnc4fVmOdPZIWfCd3jWKKSTzZCrQ== Received: from c8d966988b92 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E8E91691073 for ; Fri, 6 Feb 2026 15:56:35 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 06 Feb 2026 13:56:35 -0000 Message-ID: <177038619612.25.11977220573967613365@4457048688e7> Message-ID-Hash: ORRVHVYINHV4QFYR6NHEPIFPRRV5FXK2 X-Message-ID-Hash: ORRVHVYINHV4QFYR6NHEPIFPRRV5FXK2 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/aom_film_grain: avoid duplicate indexes in ff_aom_parse_film_grain_sets() (PR #21660) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: michaelni via ffmpeg-devel Cc: michaelni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21660 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21660 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21660.patch Fixes: use after free Fixes: 478301106/clusterfuzz-testcase-minimized-ffmpeg_dem_HEVC_fuzzer-6155792247226368 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer >>From a55f89710c7c8a812a68a0a2a295452618cfd72d Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 6 Feb 2026 03:27:20 +0100 Subject: [PATCH 1/2] avcodec/aom_film_grain: avoid duplicate indexes in ff_aom_parse_film_grain_sets() Fixes: use after free Fixes: 478301106/clusterfuzz-testcase-minimized-ffmpeg_dem_HEVC_fuzzer-6155792247226368 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aom_film_grain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aom_film_grain.c b/libavcodec/aom_film_grain.c index a5b692562d..5919d99c30 100644 --- a/libavcodec/aom_film_grain.c +++ b/libavcodec/aom_film_grain.c @@ -152,8 +152,9 @@ int ff_aom_parse_film_grain_sets(AVFilmGrainAFGS1Params *s, payload_4byte = get_bits1(gb); payload_size = get_bits(gb, payload_4byte ? 2 : 8); set_idx = get_bits(gb, 3); + fgp = av_film_grain_params_alloc(&fgp_size); - if (!fgp) + if (!fgp || s->sets[set_idx]) goto error; aom = &fgp->codec.aom; -- 2.52.0 >>From 6efa67d9d448f9a6ae23c5d0c451d058767019f6 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 6 Feb 2026 03:49:30 +0100 Subject: [PATCH 2/2] avcodec/aom_film_grain: Remove impossible check fgp is freshly allocated so it cannot be equal to ref Signed-off-by: Michael Niedermayer --- libavcodec/aom_film_grain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aom_film_grain.c b/libavcodec/aom_film_grain.c index 5919d99c30..bb60c55774 100644 --- a/libavcodec/aom_film_grain.c +++ b/libavcodec/aom_film_grain.c @@ -213,7 +213,7 @@ int ff_aom_parse_film_grain_sets(AVFilmGrainAFGS1Params *s, } predict_scaling = get_bits1(gb); - if (predict_scaling && (!ref || ref == fgp)) + if (predict_scaling && !ref) goto error; // prediction must be from valid, different set predict_y_scaling = predict_scaling ? get_bits1(gb) : 0; -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org