Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PR] avcodec/x86/vorbisdsp: change cmpleps to cmpltps in inverse coupling (PR #21656)
@ 2026-02-05 21:33 hassanhany via ffmpeg-devel
  0 siblings, 0 replies; only message in thread
From: hassanhany via ffmpeg-devel @ 2026-02-05 21:33 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: hassanhany

PR #21656 opened by hassanhany
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21656
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21656.patch

Changed the comparison from cmpleps to strictly less than
(cmpltps) to strictly follow the Vorbis spec

Fixes https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21501


>From 84fa37f2e4138f1ef943685870bda894e79c3fe1 Mon Sep 17 00:00:00 2001
From: Hassan Hany <hassanhanyrashad@gmail.com>
Date: Thu, 5 Feb 2026 23:14:16 +0200
Subject: [PATCH] avcodec/x86/vorbisdsp: change cmpleps to cmpltps in inverse
 coupling

Changed the comparison from cmpleps to strictly less than
(cmpltps) to strictly follow the Vorbis spec

Fixes https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21501
---
 libavcodec/x86/vorbisdsp.asm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/x86/vorbisdsp.asm b/libavcodec/x86/vorbisdsp.asm
index 9afe2eb352..815a1b2114 100644
--- a/libavcodec/x86/vorbisdsp.asm
+++ b/libavcodec/x86/vorbisdsp.asm
@@ -41,8 +41,8 @@ align 16
     mova                     m1, [angq+block_sizeq]
     xorps                    m2, m2
     xorps                    m3, m3
-    cmpleps                  m2, m0     ; m <= 0.0
-    cmpleps                  m3, m1     ; a <= 0.0
+    cmpltps                  m2, m0     ; m < 0.0
+    cmpltps                  m3, m1     ; a < 0.0
     andps                    m2, m5     ; keep only the sign bit
     xorps                    m1, m2
     mova                     m4, m3
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-02-05 21:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-05 21:33 [FFmpeg-devel] [PR] avcodec/x86/vorbisdsp: change cmpleps to cmpltps in inverse coupling (PR #21656) hassanhany via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git