From: hassanhany via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: hassanhany <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] avcodec/x86/vorbisdsp: change cmpleps to cmpltps in inverse coupling (PR #21656)
Date: Thu, 05 Feb 2026 21:33:13 -0000
Message-ID: <177032719375.25.3377001482234261739@4457048688e7> (raw)
PR #21656 opened by hassanhany
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21656
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21656.patch
Changed the comparison from cmpleps to strictly less than
(cmpltps) to strictly follow the Vorbis spec
Fixes https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21501
>From 84fa37f2e4138f1ef943685870bda894e79c3fe1 Mon Sep 17 00:00:00 2001
From: Hassan Hany <hassanhanyrashad@gmail.com>
Date: Thu, 5 Feb 2026 23:14:16 +0200
Subject: [PATCH] avcodec/x86/vorbisdsp: change cmpleps to cmpltps in inverse
coupling
Changed the comparison from cmpleps to strictly less than
(cmpltps) to strictly follow the Vorbis spec
Fixes https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/21501
---
libavcodec/x86/vorbisdsp.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/vorbisdsp.asm b/libavcodec/x86/vorbisdsp.asm
index 9afe2eb352..815a1b2114 100644
--- a/libavcodec/x86/vorbisdsp.asm
+++ b/libavcodec/x86/vorbisdsp.asm
@@ -41,8 +41,8 @@ align 16
mova m1, [angq+block_sizeq]
xorps m2, m2
xorps m3, m3
- cmpleps m2, m0 ; m <= 0.0
- cmpleps m3, m1 ; a <= 0.0
+ cmpltps m2, m0 ; m < 0.0
+ cmpltps m3, m1 ; a < 0.0
andps m2, m5 ; keep only the sign bit
xorps m1, m2
mova m4, m3
--
2.52.0
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
reply other threads:[~2026-02-05 21:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177032719375.25.3377001482234261739@4457048688e7 \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git