[FFmpeg-devel] [PR] swscale/utils: zero init filter memory as before (PR #21578)

[FFmpeg-devel] [PR] swscale/utils: zero init filter memory as before (PR #21578)

[Kacper Michajłow via ffmpeg-devel]

PR #21578 opened by Kacper Michajłow (kasper93)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21578
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21578.patch

Commit 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a removed zeroing of those
buffers, without mention, which introduces corrupted output.


From fcd428af3b183da5c4322e7f646e947af58b1237 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= <kasper93@gmail.com>
Date: Sun, 25 Jan 2026 16:57:09 +0100
Subject: [PATCH] swscale/utils: zero init filter memory as before

Commit 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a removed zeroing of those
buffers, without mention, which introduces corrupted output.

Fixes: 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a
Fixes: https://github.com/mpv-player/mpv/issues/17317
---
 libswscale/utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libswscale/utils.c b/libswscale/utils.c
index 24942fe6da..195af846d4 100644
--- a/libswscale/utils.c
+++ b/libswscale/utils.c
@@ -388,7 +388,7 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos,
     if (dstFilter)
         filter2Size += dstFilter->length - 1;
     av_assert0(filter2Size > 0);
-    filter2 = av_malloc_array(dstW, filter2Size * sizeof(*filter2));
+    filter2 = av_calloc(dstW, filter2Size * sizeof(*filter2));
     if (!filter2)
         goto nomem;
     for (i = 0; i < dstW; i++) {
@@ -557,7 +557,7 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos,
 
     // Note the +1 is for the MMX scaler which reads over the end
     /* align at 16 for AltiVec (needed by hScale_altivec_real) */
-    *outFilter = av_malloc_array(dstW + 3, *outFilterSize * sizeof(**outFilter));
+    *outFilter = av_calloc(dstW + 3, *outFilterSize * sizeof(**outFilter));
     if (!*outFilter)
         goto nomem;
 
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org