From: "Kacper Michajłow via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: "Kacper Michajłow" <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] swscale/utils: zero init filter memory as before (PR #21578)
Date: Sun, 25 Jan 2026 16:00:20 -0000
Message-ID: <176935682139.25.7846895085478073734@4457048688e7> (raw)
PR #21578 opened by Kacper Michajłow (kasper93)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21578
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21578.patch
Commit 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a removed zeroing of those
buffers, without mention, which introduces corrupted output.
From fcd428af3b183da5c4322e7f646e947af58b1237 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= <kasper93@gmail.com>
Date: Sun, 25 Jan 2026 16:57:09 +0100
Subject: [PATCH] swscale/utils: zero init filter memory as before
Commit 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a removed zeroing of those
buffers, without mention, which introduces corrupted output.
Fixes: 795bb37a39e163cbb5b6d897ebb0ca90ea7b449a
Fixes: https://github.com/mpv-player/mpv/issues/17317
---
libswscale/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libswscale/utils.c b/libswscale/utils.c
index 24942fe6da..195af846d4 100644
--- a/libswscale/utils.c
+++ b/libswscale/utils.c
@@ -388,7 +388,7 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos,
if (dstFilter)
filter2Size += dstFilter->length - 1;
av_assert0(filter2Size > 0);
- filter2 = av_malloc_array(dstW, filter2Size * sizeof(*filter2));
+ filter2 = av_calloc(dstW, filter2Size * sizeof(*filter2));
if (!filter2)
goto nomem;
for (i = 0; i < dstW; i++) {
@@ -557,7 +557,7 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos,
// Note the +1 is for the MMX scaler which reads over the end
/* align at 16 for AltiVec (needed by hScale_altivec_real) */
- *outFilter = av_malloc_array(dstW + 3, *outFilterSize * sizeof(**outFilter));
+ *outFilter = av_calloc(dstW + 3, *outFilterSize * sizeof(**outFilter));
if (!*outFilter)
goto nomem;
--
2.52.0
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
reply other threads:[~2026-01-25 16:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176935682139.25.7846895085478073734@4457048688e7 \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git