Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Gyan Doshi <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] avformat/cafdec: parse non-intra streams (PR #21576)
Date: Sun, 25 Jan 2026 10:49:32 -0000
Message-ID: <176933817348.25.7036844589770358510@4457048688e7> (raw)

PR #21576 opened by Gyan Doshi (GyanD)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21576
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21576.patch

A user tried a streamcopy of an AAC stream from a CAF file and the output was empty.
Turns out neither the demuxer sets KF flags nor does it enable parsing so no packet is flagged as KF so the CLI muxes no packets.

Fixed.


>From f5e97e88dcf6823d7428829eea1c15e0856d892b Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Sun, 25 Jan 2026 16:12:39 +0530
Subject: [PATCH] avformat/cafdec: parse non-intra streams

Needed to set KF flags so that they can be streamcopied using CLI.
---
 libavformat/cafdec.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
index 99ae041364..fdd7b80073 100644
--- a/libavformat/cafdec.c
+++ b/libavformat/cafdec.c
@@ -28,6 +28,7 @@
 #include <inttypes.h>
 
 #include "avformat.h"
+#include "avformat_internal.h"
 #include "avio_internal.h"
 #include "demux.h"
 #include "internal.h"
@@ -421,6 +422,9 @@ found_data:
     if (caf->data_size >= 0)
         avio_seek(pb, caf->data_start, SEEK_SET);
 
+    if (!ff_is_intra_only(st->codecpar->codec_id))
+        ffstream(st)->need_parsing = AVSTREAM_PARSE_HEADERS;
+
     return 0;
 }
 
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2026-01-25 10:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176933817348.25.7036844589770358510@4457048688e7 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git