[FFmpeg-devel] [PR] avformat/whip: remove the confused option buffer_size (PR #21518)

[Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #21518 opened by Jack Lau (JackLau)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21518
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21518.patch

See https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20965#issuecomment-22815

The buffer_size isn't inlcuded in release/8.0,
directly use new option ts_buffer_size to replace
buffer_size shoule be okay.

Signed-off-by: Jack Lau <jacklau1222gm@gmail.com>


>From dff39385f87af76ef4ec935d7c0496b71a5578dd Mon Sep 17 00:00:00 2001
From: Jack Lau <jacklau1222gm@gmail.com>
Date: Mon, 19 Jan 2026 23:15:22 +0800
Subject: [PATCH] avformat/whip: remove the confused option buffer_size

See https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20965#issuecomment-22815

The buffer_size isn't inlcuded in release/8.0,
directly use new option ts_buffer_size to replace
buffer_size shoule be okay.

Signed-off-by: Jack Lau <jacklau1222gm@gmail.com>
---
 doc/muxers.texi    | 4 +---
 libavformat/whip.c | 2 --
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/doc/muxers.texi b/doc/muxers.texi
index 9d3ca3624c..e1f737b1d9 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3955,12 +3955,10 @@ Default value is 5000.
 Set the maximum size, in bytes, of RTP packets that send out.
 Default value is 1200.
 
-@item buffer_size, ts_buffer_size @var{integer}
+@item ts_buffer_size @var{integer}
 Set the buffer size, in bytes, of underlying protocol.
 Default value is -1(auto). The UDP auto selects a reasonable value.
 
-Using the buffer_size option name is deprecated and should not be used.
-
 @item whip_flags @var{flags}
 Possible values:
 
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 5200aca4fd..4695c6dc39 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -2011,11 +2011,9 @@ static int whip_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket
 
 #define OFFSET(x) offsetof(WHIPContext, x)
 #define ENC AV_OPT_FLAG_ENCODING_PARAM
-#define DEP AV_OPT_FLAG_DEPRECATED
 static const AVOption options[] = {
     { "handshake_timeout",  "Timeout in milliseconds for ICE and DTLS handshake.",      OFFSET(handshake_timeout),  AV_OPT_TYPE_INT,    { .i64 = 5000 },    -1, INT_MAX, ENC },
     { "pkt_size",           "The maximum size, in bytes, of RTP packets that send out", OFFSET(pkt_size),           AV_OPT_TYPE_INT,    { .i64 = 1200 },    -1, INT_MAX, ENC },
-    { "buffer_size",        "The buffer size, in bytes, of underlying protocol",        OFFSET(ts_buffer_size),        AV_OPT_TYPE_INT,    { .i64 = -1 },      -1, INT_MAX, ENC | DEP },
     { "ts_buffer_size",     "The buffer size, in bytes, of underlying protocol",        OFFSET(ts_buffer_size),        AV_OPT_TYPE_INT,    { .i64 = -1 },      -1, INT_MAX, ENC },
     { "whip_flags",         "Set flags affecting WHIP connection behavior",             OFFSET(flags),              AV_OPT_TYPE_FLAGS,  { .i64 = 0},         0, UINT_MAX, ENC, .unit = "flags" },
     { "dtls_active",        "Set dtls role as active",                                  0,                          AV_OPT_TYPE_CONST,  { .i64 = WHIP_DTLS_ACTIVE}, 0, UINT_MAX, ENC, .unit = "flags" },
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org