From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D790B4004F for ; Sun, 18 Jan 2026 23:30:58 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'V6v9cYK7oGyhzJpq/3T2xB2UFwEJwG6NTFuufUZCAJ0=', expected b'TM+89ELHnSUgx2mZ7hAJ3X7eqiTiDiSd8bdhmVaddxg=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768779043; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=V6v9cYK7oGyhzJpq/3T2xB2UFwEJwG6NTFuufUZCAJ0=; b=3TbSsd5iUzJ4GU/YVUERX0PdLHSjSvltlpwLx1RFtAFqYcNjBorehBV5H/zJLFUgxgqRb z/3kScUlnPjy2vzAd0wzyb1LJ9n6GXj3Yfj6Qh+p0TmOmpvIM10sLEHzrU/wNfzDqxZIJXH z23z0xwGh+RWBOuK55747Q/40LyqFgm6VUN0LG9mM4/Y4/Aih04s/ydIxYqWqDnZr+KqcBa fWESrIJoYLXnk/a66/zZzSQ2+Lf9PnXb8mfeu8j8RAi5F7Y6J/oCIRGe4CXb4yrift92xUo Z2oqzlp3SCBSXeY55Plcielr4qI3oVUS1L5nzIfLHCSzWs8qWThP4Jn4SBBQ== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 51CA8690E78; Mon, 19 Jan 2026 01:30:43 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1768779023; b=LuRIyg5UXlNgblNo17gR7GC/grq6Q5J8i4gLeHN1yXyuPS8hWN3JMJWXuQeJNq+zh452z HW+Trbw9P5oJb3M4v18Rb8efXiJaPg9UCnN9k22i0TcDFIuLvatsaSLbzZ9CvbbCy933naW 4AKMnSuccz6pGQZj9d/lQKk58mAD9sRfOnD7zzj0YsFYZV4hnYcCfMhCKsGwYL+uX8RaHJ0 1XvKfpLmjPyWK2ioEXRruXvcbUgqhfHGhwXpLGg2TOwXhP76R9ZklgTbo730zyD5dpJ33tG 7VD/ijLZaT42iSAK9dQsU3QU4zzkEnfVkbTyZI1sfBQEC7kDtyFeaSnAMqhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1768779023; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=rkU+Y/+CuSKbzuXgYQ9RaCGCj5e4bpvKIhiBSQIr5ME=; b=a8CeAgjOvkLsxclyjlEzeCLUqVUWZwgKSBWd18V0c/cupR6hDCAwz7p1p1OkgwFpOmxqF sD4jLjiI6rxp/tRL3T8qNG4DgYb2kyY3gKxdT0agctWqJuH2PW4otJDUwmv0Zj6/szryu1l QxtJIQ63XSugi4GCLx21THZjFs3lavMHWIy8DUMHG25QbMHyK29qDtE+86Wb6ndLmrtB8uV +z3OLQzY0udvSfe7d4mLv79DpS/weqMba3/jWq6uikzSdQJuej55v64R5yRodH+fNXIMwnN oEIxVk3GMZKcq0aX/PIaEic4+CpFZyOdE74kRzNMw4V+YHrEjk61SHUL0toQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768779013; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=TM+89ELHnSUgx2mZ7hAJ3X7eqiTiDiSd8bdhmVaddxg=; b=4JUr+Tv8saRO6x8MH8jkdYcZDMIeweb+VmxC++opORqVUaz0Xq5eS2ptHfICN7pJ03Ocy 0U7ppYFqVQMYAr5x7PQnW2hHavPWH3rI8wD7BKEuLa+C+4gXfxPg+9VUq2akmzClYPq6Tdy w4pAhS1NJ0sdk7IEv94Ky02H2eR72ur2AMLPQqSrxsKmWmdTcOdy1stu8DX4Qo7y1NW5SOL 6SvXvAOYHLIvkd3bGZZaY+k+Gx9Hdayfsn4sfUlZIGuTV1/kl3RFr79yC+pcsEpoY+JdYFI nUhe2yuYHXNL4yHxWDdj4q8UyhW6ckX5d5PEuPkYZsWHh+VWYcN8qqtDdGJg== Received: from 69dab402ede7 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 64AC768F8CE for ; Mon, 19 Jan 2026 01:30:13 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Sun, 18 Jan 2026 23:30:12 -0000 Message-ID: <176877901352.25.13056398247219966934@4457048688e7> Message-ID-Hash: XAXFWI3X5F3ULJ25AS66CWFNQ52CIYXL X-Message-ID-Hash: XAXFWI3X5F3ULJ25AS66CWFNQ52CIYXL X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/mlp: Don't use internals of CRC API (PR #21507) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21507 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21507 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21507.patch ff_mlp_restart_checksum() used the (undocumented) layout of the CRC tables and therefore broke on x86 when the clmul implementation added in dc03cffe9c9577127ef82b6f56118115f900e5f2 is used. This commit fixes this. >>From f330d178adf5508607f2c1f3d0cc0201b6fd4d18 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 19 Jan 2026 00:26:34 +0100 Subject: [PATCH] avcodec/mlp: Don't use internals of CRC API ff_mlp_restart_checksum() used the (undocumented) layout of the CRC tables and therefore broke on x86 when the clmul implementation added in dc03cffe9c9577127ef82b6f56118115f900e5f2 is used. This commit fixes this. Signed-off-by: Andreas Rheinhardt --- libavcodec/mlp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/mlp.c b/libavcodec/mlp.c index 33045c08c7..8ea6e6d72e 100644 --- a/libavcodec/mlp.c +++ b/libavcodec/mlp.c @@ -107,8 +107,11 @@ uint8_t ff_mlp_restart_checksum(const uint8_t *buf, unsigned int bit_size) int i; int num_bytes = (bit_size + 2) / 8; - int crc = crc_1D[buf[0] & 0x3f]; - crc = av_crc(crc_1D, crc, buf + 1, num_bytes - 2); + // The two most significant bits of buf[0] are not supposed + // to be contained in the checksum; using buf[0] & 0xC0 as start value + // achieves this. + int crc = av_crc(crc_1D, buf[0] & 0xC0, buf, num_bytes - 1); + crc ^= buf[num_bytes - 1]; for (i = 0; i < ((bit_size + 2) & 7); i++) { -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org