[FFmpeg-devel] [PR] avformat/hcom: check that all extradata bytes were read from the input (PR #21494)

[FFmpeg-devel] [PR] avformat/hcom: check that all extradata bytes were read from the input (PR #21494)

[James Almer via ffmpeg-devel]

PR #21494 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21494
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21494.patch

Fixes issue #21493.


>From 927702d39b5612cd34f3f5c174f5a14bf86476e0 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Fri, 16 Jan 2026 13:14:09 -0300
Subject: [PATCH] avformat/hcom: check that all extradata bytes were read from
 the input

Fixes issue #21493.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/hcom.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavformat/hcom.c b/libavformat/hcom.c
index 2a8c524496..fa32f2bbb9 100644
--- a/libavformat/hcom.c
+++ b/libavformat/hcom.c
@@ -73,7 +73,9 @@ static int hcom_read_header(AVFormatContext *s)
         return ret;
     AV_WB16(st->codecpar->extradata, dict_entries);
     AV_WB32(st->codecpar->extradata + 2, compresstype);
-    avio_read(s->pb, st->codecpar->extradata + 6, dict_entries * 4);
+    ret = ffio_read_size(s->pb, st->codecpar->extradata + 6, dict_entries * 4);
+    if (ret < 0)
+        return ret;
     avio_skip(s->pb, 1);
     st->codecpar->extradata[dict_entries * 4 + 6] = avio_r8(s->pb);
 
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org