Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: James Almer <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] avformat/hcom: check that all extradata bytes were read from the input (PR #21494)
Date: Fri, 16 Jan 2026 16:14:41 -0000
Message-ID: <176858008218.25.4331897251136199264@4457048688e7> (raw)

PR #21494 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21494
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21494.patch

Fixes issue #21493.


>From 927702d39b5612cd34f3f5c174f5a14bf86476e0 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Fri, 16 Jan 2026 13:14:09 -0300
Subject: [PATCH] avformat/hcom: check that all extradata bytes were read from
 the input

Fixes issue #21493.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/hcom.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libavformat/hcom.c b/libavformat/hcom.c
index 2a8c524496..fa32f2bbb9 100644
--- a/libavformat/hcom.c
+++ b/libavformat/hcom.c
@@ -73,7 +73,9 @@ static int hcom_read_header(AVFormatContext *s)
         return ret;
     AV_WB16(st->codecpar->extradata, dict_entries);
     AV_WB32(st->codecpar->extradata + 2, compresstype);
-    avio_read(s->pb, st->codecpar->extradata + 6, dict_entries * 4);
+    ret = ffio_read_size(s->pb, st->codecpar->extradata + 6, dict_entries * 4);
+    if (ret < 0)
+        return ret;
     avio_skip(s->pb, 1);
     st->codecpar->extradata[dict_entries * 4 + 6] = avio_r8(s->pb);
 
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2026-01-16 16:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176858008218.25.4331897251136199264@4457048688e7 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git