From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 87AC04E288 for ; Thu, 15 Jan 2026 23:36:45 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'2JgxapiGA7J0dcRK3nH/6qGZWxm27Ju78DmEbZiRW1E=', expected b'MM67KGNBoX9qy3Z/NSYzgYKNC92q4tcB1TmM2H4ESAc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768520191; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2JgxapiGA7J0dcRK3nH/6qGZWxm27Ju78DmEbZiRW1E=; b=QN2xTua6UCN+9/F/m8MZrN+cPcdur2JLN6Bo7pOXEG0klROqrxy+4RapRmlcE60kFhO6m 7zR+YvZ57mQ1EGlnCZ2taGwoiAib70oBmGj0Zc7RG3993iTh52J9hMmOXhrbixPnASzoZpy YQnPu0ZcbHJPBKn2ZPjS+1C7JAIwVVUsxXflbgcll8DI50rXqBokGkGWMiQPXfZMSpyPS5Y E0oil0iaVul6HMXv5gG3dCRo5c5niDxTEbbxQBYv83ZdcwoqF7G00QehSiRQwDO2a6+n2Oc 4/AYuV2lNRW/6nYSge/QAxDyGWWBruJUu6OkQlmRCYeJct8gmytCuEE1xt+w== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9E07C690E3E; Fri, 16 Jan 2026 01:36:31 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1768520174; b=dRWo8GcTZlShTvr3P+bRK5bKJXHww83n3jRz0iNWleyzz6iPXeouzb6fjeUulYqLRGCL1 FKurBzBUrL+lQbrbg5PVq7h0OV7qh+3ugVgoalDFQDvu67XX3bq+C7gsC+FIawmNNi/VbRs /RyWDOyYOPq030e47DT8yzjrvOMPU/sLjqjU9tQ7a1Nz1iANoDe28lazbD6wtwzkaeV088V g6AwPJZP0kWMEIb9dWw00rlLzs7zc3AlFnypGYFeNm5wEWRbkeyXs4suQmVrVaPI1IXnUyC LDK9SCYZWuJ2PzmVeyD9vrf6GX3k99kAumFv5aNG5dzSnxjlRPwvEAh6ApAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1768520174; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Xpycb2Ne+mh/SXrbt2CRFTraPjAq+h4dRp+K//jOnEU=; b=C76bUba8Xx5FSWITcvf+woG6rUwRgs5nB7cvTffI7HtfsC1y/nKqTSS2Mg02ertQxWQjp QanSeHslpCJRf6FXxh8K6piLw/DgHpNkM+fZtyA6q3CBoctb3BYu2e3g9C4I41s64HlsNVB 0ZHLaX6/zlBtdao6H5dhf5Li/6d1H9X5OEGmCa4o8kmqg8Q0xVGuN6A9xZY7J7ycOYdgTGL y7196tbnoK+YgNq6vuNoYx2us0vD9+PvTUGqs27Q07+alvG0caJbYzaX0wOaTj4sP4tM9wI eEIHHmqllDLl7b0FmlnlppkdwxdZFJmxnWmSFrPI+t/mhA3Tc7WnChYAj5sw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768520164; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=MM67KGNBoX9qy3Z/NSYzgYKNC92q4tcB1TmM2H4ESAc=; b=cZfRP1TAq+RQjCHERtOieRm7LLqnGBrE19YAtfAdXL0OZ260ufapHUwSHE1LQlTmWB/YL uF60c+cQIcwsizi5+pPA2x9AFTKIX+D4Vc2XsQ2ntPklpB5a3ebfK6rAX+NMj3nYI1D+XXF 6UHfDNFUtDQnxZtNWd/XniDM7KwCt0rOChjjLh/hYz9yblkmTUz/YP2DOGiWP32bQNzhpqJ 3l12sdzEHPDLhvn7lMv6aNAxGtYmmzAkSwtTDwPE8kZ+xvPz9PTxEWE33Q7Xzt9LwvgdgoG dikE59kVWzo+uPmls8dahKdMcW5AifQVnUYsihq/0a/d6L1MtVU7es1JIWKQ== Received: from 69dab402ede7 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DA619690CCA for ; Fri, 16 Jan 2026 01:36:04 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 15 Jan 2026 23:36:04 -0000 Message-ID: <176852016504.25.1615190366179230382@4457048688e7> Message-ID-Hash: FACKVZDXRWXMTDNPCBXUTWDWXFYU2UMS X-Message-ID-Hash: FACKVZDXRWXMTDNPCBXUTWDWXFYU2UMS X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] Revert "lavfi: make sure frame SAR matches the link value" (PR #21482) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Marton Balint via ffmpeg-devel Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21482 opened by Marton Balint (cus) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21482 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21482.patch This reverts commit fcc33ada47e594d6b35b71c4a998af796f56492e. It breaks playback of files with changing aspect ratio in ffplay, such as [1], because the filter chain is initialized with the initial aspect ratio, so any change is overwritten. Michael already reported this issue at the time of patch submission [2], but it was applied anyway. Ideally we could reinitialize the filter chain, but we never wanted to do that just for an aspect ratio change, because a filter chain reinitialization in the middle of playback / encoding can cause even worse issues. So I think it is better to just revert this. [1] https://samples.ffmpeg.org/archive/container/mpegts/mpegts+mpeg2video+mp2++aspect.ts [2] https://ffmpeg.org/pipermail/ffmpeg-devel/2023-July/312175.html >>From b306cc24bf8d023d579b0637f58ce8cb0039cfb8 Mon Sep 17 00:00:00 2001 From: Marton Balint Date: Fri, 16 Jan 2026 00:11:57 +0100 Subject: [PATCH 1/2] avfilter: do not overwrite frame aspect ratio with source frame props in histogram and vectorscrope Signed-off-by: Marton Balint --- libavfilter/vf_histogram.c | 1 + libavfilter/vf_vectorscope.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c index f77148cdfe..1a5626b317 100644 --- a/libavfilter/vf_histogram.c +++ b/libavfilter/vf_histogram.c @@ -594,6 +594,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) } av_frame_copy_props(out, in); + out->sample_aspect_ratio = outlink->sample_aspect_ratio; av_frame_free(&in); s->x_pos++; if (s->x_pos >= s->width) { diff --git a/libavfilter/vf_vectorscope.c b/libavfilter/vf_vectorscope.c index eeee166172..483132332e 100644 --- a/libavfilter/vf_vectorscope.c +++ b/libavfilter/vf_vectorscope.c @@ -1469,6 +1469,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) return AVERROR(ENOMEM); } av_frame_copy_props(out, in); + out->sample_aspect_ratio = outlink->sample_aspect_ratio; s->vectorscope(s, in, out, s->pd); s->graticulef(s, out, s->x, s->y, s->pd, s->cs); -- 2.52.0 >>From 8b13e72ad8bb6c1d64606481049f7dbaf0c1cd85 Mon Sep 17 00:00:00 2001 From: Marton Balint Date: Wed, 14 Jan 2026 23:03:26 +0100 Subject: [PATCH 2/2] Revert "lavfi: make sure frame SAR matches the link value" This reverts commit fcc33ada47e594d6b35b71c4a998af796f56492e. It breaks playback of files with changing aspect ratio in ffplay, such as [1], because the filter chain is initialized with the initial aspect ratio, so any change is overwritten. [1] https://samples.ffmpeg.org/archive/container/mpegts/mpegts+mpeg2video+mp2++aspect.ts --- libavfilter/avfilter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 169c2baa42..bb0b665f0c 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1084,8 +1084,6 @@ int ff_filter_frame(AVFilterLink *link, AVFrame *frame) if (av_pix_fmt_desc_get(link->format)->flags & AV_PIX_FMT_FLAG_ALPHA) av_assert1(frame->alpha_mode == link->alpha_mode); } - - frame->sample_aspect_ratio = link->sample_aspect_ratio; } else { if (frame->format != link->format) { av_log(link->dst, AV_LOG_ERROR, "Format change is not supported\n"); -- 2.52.0 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org