From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 919014E24D for ; Thu, 15 Jan 2026 05:39:50 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'dS7wY0GNZ8XtqJ4+OcdzBbCBpNnSIQZVtXxW+oZUz0g=', expected b'c7/Jy2uccxJ7UDotd4jnPS80vRI3T42xNCE0pldQpsI=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768455533; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=dS7wY0GNZ8XtqJ4+OcdzBbCBpNnSIQZVtXxW+oZUz0g=; b=eRKIvhgjb9q6pxeBo8jJz4206qb+RldGgRKvqmMGa1ifkvllGac7U69DWbBjgBKevPvK7 whwpGiwPMzmXUN7UkV10Uqhi+QgfoKGnmRaq6hFw/XhxF0h4Z9JwoW40BMcGwj6MKrd3EMN 6WqbbFUuqapJSobtGLfmBCTIVNKq507R5KKlHGkMgP1f85NRR55mBvZ9I0w5PvE72v77d73 pgKrW+S5TvL2eC6UCU5MbUXTvh+KcS68QSgJlMXFMJrUzBdSyUPyIsBFI8b9XB/MO7XEqOj a48oIpzWNYAGcCc3Wpf2cNNBX7Ij25tbirvEBuA1uB7mMdcQuA5010FExezQ== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C31FF690E28; Thu, 15 Jan 2026 07:38:53 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1768455489; b=Lxd8qVQNf4+LGNWltDu02emycn01gTeVBbQeQkJrTu5C4ZkzqdG0jXLmNm7nwwNGCwo7b TgYIdokQsSm9p8Z/3kQ49U+amPYeefR9I96HM2bPSvE7cI5DHFu7hXHrPNlXb0wx4+waLOw UBTk/JtOQtKWycmuRLRuBoVTVYMbrndTpbC5Yy/R0I9+3P30B9gw6ociYVdLGRwgHtgyIAU 1oZw//jFWMWbPE7LRhMhLWexVLGb05Tco9U2vWoXuuEchJp3AUA+75PWrduaAyGfpVJexQB 99gcjETvulJfwxUCdWiwsmyxhGdkTLdtj8l2mfm8TpZNLhjtEPOtyEd4aYJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1768455489; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Vs8KlzHfFG8aeLk6u+lKJgb59PgdabOIAQ5eJkLz4q8=; b=NBrun7OgW5NMArH53hx/8y9QgscsVvAdLO5rXc9DOpxhN2bcxTudhJ7oaIGMN6iDGM00U dw8p2TksYS8wUF1hz/6MXkaANM2j6Kw5I3rfqOnOdxtYI08ASJdqArcazMSCU03DU+BWT/t 4/d0gYthtkJgyKoBah2v2KiLR+Tk8JaCsRMpCOtEq3axTBx6QPrxh+/6l05yvgdL5yRdH6h tnLc2c27Q9KSFFFgUmZ1eok8BQ6pMEo0WctjwfZFiBst0bnv5cIMxrQk+55z82ObtDMjH/j jOadwspnIqRC6eKXudo+YWIQCvfY4IpatsugpZA5ZVCGoRnUzKbSkxa1RF8A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1768455471; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=c7/Jy2uccxJ7UDotd4jnPS80vRI3T42xNCE0pldQpsI=; b=XTrasRAMHz5vqepahij+diBpjRFj9RppmE8HE+FM8SuziTz2W2BltnZe64XHHpO7QS5Ug i+78n9KQ4iDJ2zcNG3X4TISTJwOknHpQcusV6Tb86wBZJh6Am1aKIrSMuF62n+vLzraiHrG C32wYDzxLwWeO1yI4pD7twKMQTn2y85Xcfr3EztAscKpjZ8CkJ92p3GiO/fvXKXtVSReXs5 FpJ39ewCsICwosvG5vPE8ADEKSFCIL4pk9/74vmo6rtw2ja4giX/C2tdImvDNeN8wMXapeu p8pwEs9PDE+KwTHqq0gL+YRaA+GEKOwiyBbBchy/fJ3v/f2gzIcUO5mbTVvw== Received: from f7c34508609e (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7B05E690DA1 for ; Thu, 15 Jan 2026 07:37:51 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 15 Jan 2026 05:37:49 -0000 Message-ID: <176845547262.25.12398021404461595469@4457048688e7> Message-ID-Hash: BKTCXWD2KGF2BNLTSUGV55O24SIJKFUO X-Message-ID-Hash: BKTCXWD2KGF2BNLTSUGV55O24SIJKFUO X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] fftools/opt_common: Make -sources/-sinks options work without arguments (PR #21473) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: add-uos-ffmpeg via ffmpeg-devel Cc: add-uos-ffmpeg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21473 opened by add-uos-ffmpeg URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21473 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21473.patch The -sources and -sinks options were defined with OPT_FUNC_ARG flag, which requires an argument. This caused "Missing argument for option 'sources'" error when running ffprobe -sources without arguments. Removing OPT_FUNC_ARG flag allows these options to work without arguments, listing all available devices, while still supporting optional device name argument for filtering specific devices. >>From a7b7c17533d14bf34c7af69ab7b7580a72c062d4 Mon Sep 17 00:00:00 2001 From: zhanghongyuan Date: Thu, 15 Jan 2026 11:39:41 +0800 Subject: [PATCH] fftools/opt_common: Make -sources/-sinks options work without arguments The -sources and -sinks options were defined with OPT_FUNC_ARG flag, which requires an argument. This caused "Missing argument for option 'sources'" error when running ffprobe -sources without arguments. Removing OPT_FUNC_ARG flag allows these options to work without arguments, listing all available devices, while still supporting optional device name argument for filtering specific devices. --- fftools/opt_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/opt_common.h b/fftools/opt_common.h index 2a891cdd89..31179046ff 100644 --- a/fftools/opt_common.h +++ b/fftools/opt_common.h @@ -41,9 +41,9 @@ int show_sources(void *optctx, const char *opt, const char *arg); #if CONFIG_AVDEVICE #define CMDUTILS_COMMON_OPTIONS_AVDEVICE \ - { "sources" , OPT_TYPE_FUNC, OPT_EXIT | OPT_FUNC_ARG | OPT_EXPERT, { .func_arg = show_sources }, \ + { "sources" , OPT_TYPE_FUNC, OPT_EXIT | OPT_EXPERT, { .func_arg = show_sources }, \ "list sources of the input device", "device" }, \ - { "sinks" , OPT_TYPE_FUNC, OPT_EXIT | OPT_FUNC_ARG | OPT_EXPERT, { .func_arg = show_sinks }, \ + { "sinks" , OPT_TYPE_FUNC, OPT_EXIT | OPT_EXPERT, { .func_arg = show_sinks }, \ "list sinks of the output device", "device" }, \ #else -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org