From: James Almer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: James Almer <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] configure: add missing vulkan_1_4 check (PR #21450)
Date: Tue, 13 Jan 2026 15:34:56 -0000
Message-ID: <176831849743.25.3840200554960593271@4457048688e7> (raw)
PR #21450 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21450
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21450.patch
Removed in f2affdfafb4e7dd0674ba415ea77faa949a11439 by mistake.
Also, fix the logic in probe_glslc() so it doesn't return false when debug is disabled.
>From e50b8a1eebcb2e08de0d759a53cef55e8f926e11 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Tue, 13 Jan 2026 12:33:00 -0300
Subject: [PATCH] configure: add missing vulkan_1_4 check
Removed in f2affdfafb4e7dd0674ba415ea77faa949a11439 by mistake.
Also, fix the logic in probe_glslc() so it doesn't return false when debug is disabled.
Signed-off-by: James Almer <jamrial@gmail.com>
---
configure | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 7e885f5100..11c8e880ac 100755
--- a/configure
+++ b/configure
@@ -6841,7 +6841,6 @@ fi
# _deps results in it always passing.
# Disable it explicitly to fix this.
disable spirv_library
-disable spirv_compiler
check_func_headers malloc.h _aligned_malloc && enable aligned_malloc
check_func ${malloc_prefix}memalign && enable memalign
@@ -7715,13 +7714,17 @@ probe_glslc(){
else
append GLSLCFLAGS $glslc_opt_none
fi
- enabled debug && append GLSLCFLAGS $glslc_debug
+ if enabled debug; then
+ append GLSLCFLAGS $glslc_debug
+ fi
}
if enabled vulkan; then
for program in $glslc glslc glslang glslangValidator; do
probe_glslc $program && break
done
+ check_pkg_config_header_only vulkan_1_4 "vulkan >= 1.4.317" "vulkan/vulkan.h" "defined VK_VERSION_1_4" ||
+ check_cpp_condition vulkan_1_4 "vulkan/vulkan.h" "defined(VK_VERSION_1_5) || (defined(VK_VERSION_1_4) && VK_HEADER_VERSION >= 317)"
else
disable libglslang libshaderc spirv_library spirv_compiler
fi
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
reply other threads:[~2026-01-13 15:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176831849743.25.3840200554960593271@4457048688e7 \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git