From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 270824E00B for ; Fri, 9 Jan 2026 22:01:15 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'M2iT2tUig4hCVCwIA7si4KBXuImhdQRoNYMHn12eJ0U=', expected b'mE9eWELcZdcGQQNfnvE8eFodxYXzydf9uy8w67Yr6TI=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767996062; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=M2iT2tUig4hCVCwIA7si4KBXuImhdQRoNYMHn12eJ0U=; b=GmLi4BMJzyNjuLgwFYHAXaUG0koCSOcHKYPocO7aWyemGXfWuJisFP2BPBaNqdCi/irFp EYhfp4+64sX0IuaRgqhfcNO7IUUNhCZqGeVqm/GtmSclKGFqA5b8YN/dqmvANnzTe/bGeL5 n6ja4p4TBW/6Y6Ul1q87Aws5nEE0C4d+WLX0y+4broAu9ICpYOF9/NBuOQGCaK6huR6ulJU Y0mtPaGDJlgdTSkUvl7KXkO5Im7+MEi8m0TKXMU3urhGEqYmOEoJ5uGoFw4m5nyB3WGlq3D dDqTfCHXj4wk8DnRFD26ex1cli4p952o5V9kSq/nFDm6x00g2GNlCxthtjTA== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6F82D690DEA; Sat, 10 Jan 2026 00:01:02 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767996040; b=U7rFJE0OZVmWLCD6ie4fr1dQYQq1pTHUm2LRUSofmt81P+rngXabOZTISpzUFKg8aryrM jmMV/0P11w+7A3sMtvGYiqpaDe5fr/RSy4/qmenZ+oS20Uw3hfK/PzLWSp7l0wuKh9LAV/i TgJ2hiZNBo1PSyAlY7+9lsOQxkXI/skWSWNfTfLRFiNI54WpJeAY/yP7S0rhEiZrPo/8jjm YvWH8uTEqiP5mC4AX9UjdXGSI5IxRZQW0On5s/vwA59plIsSlb4HS4Xes7uJuM0SG+8Fr/a C0OeeWoUG4NLfADKuOKTpYfE+RmZHCBlp8IS7u1prM9HqZlrttnO7Yzk9P2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767996040; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=egHMt5I2o9J5bTAobQECd68AztJ0/jjTbflzgNuuCZ8=; b=jIVMjyO8vVMTEk3G6QrlCtNEfWMG3YiviUGLXsq5o1RHcKq7FXzpQ1Lh60KRBkYvzbOBn cgJxLuKDd+gQd1+8m7m4MqQiQUrXWnfSONXmoZB3rXYxzu1RzRPyIxRfvXuQdSStRKiletG rf5EzdfnFFcQVd5caVxNut09vleQMWEM3QGwjNBxzSipbqbHQ1Zcw3c0jF3RqclLnTKh9tn pXvN8bccQ1HK4kav9se8JhjQeOuFXQwLnUX17kVHvm15OfB5KU+i5OrHzZmibYfvOCt3sMY JPoVsWmr/CWJre8ySKWPxTcjlnaWLohDxTTU1mUnreLwklQtdwwYnf0Fkw/Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767996032; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=mE9eWELcZdcGQQNfnvE8eFodxYXzydf9uy8w67Yr6TI=; b=RJE+xwCparpWUs3YVXB0kOsXxLAsDJolbUexDABQqy7R5SzMIldQ0Ldy6lOzq1NPNVI7c 2v9nB4K1loBR8CJ1tWT0MpnWGoEITT9QSJ6udS0DQxhqbom/YUIJYzK2fyjyJq5rBzpjfnF t6DJpsEPygmKJXge3MEEWyZUT8gNUnyoV5sp4lZXCedJotUu8gJ3qiwlM1hte1kxujSEAqk E4S2GkWDuO76rZ7gZZchRE5udoIWGJbs2j4ny3mEmBuHWYRj5bUCItk4fpbOhwZ8DYcjWtB 7aXVUjwu/IdQeSTSv9hM1By68+DZ351cAdVw4UFik5rcEQVWhJBTtryhY1Qw== Received: from f7c34508609e (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id E86AA690D72 for ; Sat, 10 Jan 2026 00:00:31 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 09 Jan 2026 22:00:31 -0000 Message-ID: <176799603206.25.10889933777532410381@4457048688e7> Message-ID-Hash: MO3MNAVE2LT7OIEG2G7TN6TQSH2SAEM6 X-Message-ID-Hash: MO3MNAVE2LT7OIEG2G7TN6TQSH2SAEM6 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/d3d12va_encode: Add H.264 entropy coder parameter support (PR #21424) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Edison Ling via ffmpeg-devel Cc: Edison Ling Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21424 opened by Edison Ling (edisonling) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21424 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21424.patch add parameter `coder` for users to explicitly select CABAC or CAVLC coding in D3D12 H264 encoding usage: `-coder cabac` or `-coder ac` or `-coder 1` `-coder cavlc` or `-coder vlc` or `-coder 0` `-coder auto` or `-coder -1` sample command line: ``` .\ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v h264_d3d12va -coder cabac -y output.mp4 ``` >>From 6fe819efd483640aaa843803f3159446e0b3d128 Mon Sep 17 00:00:00 2001 From: "Ling, Edison" Date: Fri, 9 Jan 2026 16:49:33 -0500 Subject: [PATCH] avcodec/d3d12va_encode: Add H264 entropy coder parameter support add parameter `coder` for users to explicitly select CABAC or CAVLC coding in D3D12 H264 encoding usage: `-coder cabac` or `-coder ac` or `-coder 1` `-coder cavlc` or `-coder vlc` or `-coder 0` `-coder auto` or `-coder -1` sample command line: ``` .\ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v h264_d3d12va -coder cabac -y output.mp4 ``` --- libavcodec/d3d12va_encode_h264.c | 30 +++++++++++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/libavcodec/d3d12va_encode_h264.c b/libavcodec/d3d12va_encode_h264.c index bcf5a326e5..8ac26c34f8 100644 --- a/libavcodec/d3d12va_encode_h264.c +++ b/libavcodec/d3d12va_encode_h264.c @@ -44,6 +44,7 @@ typedef struct D3D12VAEncodeH264Context { int qp; int profile; int level; + int coder; int idr_pic_id; // Writer structures. @@ -269,9 +270,24 @@ static int d3d12va_encode_h264_get_encoder_caps(AVCodecContext *avctx) config->ConfigurationFlags = D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_H264_FLAG_NONE; - if (h264_caps.SupportFlags & D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_SUPPORT_H264_FLAG_CABAC_ENCODING_SUPPORT) { - config->ConfigurationFlags |= D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_H264_FLAG_ENABLE_CABAC_ENCODING; - priv->unit_opts.cabac = 1; + // Entropy coder configuration + if (priv->coder == 1) { + if (h264_caps.SupportFlags & D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_SUPPORT_H264_FLAG_CABAC_ENCODING_SUPPORT) { + config->ConfigurationFlags |= D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_H264_FLAG_ENABLE_CABAC_ENCODING; + priv->unit_opts.cabac = 1; + } else { + av_log(avctx, AV_LOG_ERROR, "CABAC entropy coding requested but not supported by driver.\n"); + return AVERROR(ENOTSUP); + } + } else if (priv->coder == 0) { + priv->unit_opts.cabac = 0; + } else { + if (h264_caps.SupportFlags & D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_SUPPORT_H264_FLAG_CABAC_ENCODING_SUPPORT) { + config->ConfigurationFlags |= D3D12_VIDEO_ENCODER_CODEC_CONFIGURATION_H264_FLAG_ENABLE_CABAC_ENCODING; + priv->unit_opts.cabac = 1; + } else { + priv->unit_opts.cabac = 0; + } } base_ctx->surface_width = FFALIGN(avctx->width, 16); @@ -591,6 +607,14 @@ static const AVOption d3d12va_encode_h264_options[] = { { LEVEL("6.2", 62) }, #undef LEVEL + { "coder", "Entropy coder type", + OFFSET(coder), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1, FLAGS, .unit = "coder" }, + { "auto", "Driver default", 0, AV_OPT_TYPE_CONST, { .i64 = -1 }, 0, 0, FLAGS, .unit = "coder" }, + { "cavlc", "CAVLC entropy coder", 0, AV_OPT_TYPE_CONST, { .i64 = 0 }, 0, 0, FLAGS, .unit = "coder" }, + { "vlc", "VLC entropy coder (CAVLC)", 0, AV_OPT_TYPE_CONST, { .i64 = 0 }, 0, 0, FLAGS, .unit = "coder" }, + { "cabac", "CABAC entropy coder", 0, AV_OPT_TYPE_CONST, { .i64 = 1 }, 0, 0, FLAGS, .unit = "coder" }, + { "ac", "Arithmetic coder (CABAC)", 0, AV_OPT_TYPE_CONST, { .i64 = 1 }, 0, 0, FLAGS, .unit = "coder" }, + { NULL }, }; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org