[FFmpeg-devel] [PR] libavformat/evcdec.c: add a check to ensure evc_frame_merge_bsf is present (PR #21417)

[FFmpeg-devel] [PR] libavformat/evcdec.c: add a check to ensure evc_frame_merge_bsf is present (PR #21417)

[James Almer via ffmpeg-devel]

PR #21417 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21417
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21417.patch

While the inclusion of the bsf is forced by a configure check, it's better to not just have the code here assume filter will never be NULL.

Fixes Coverity issue CID 1680305.


>From 588ef047a057493439b1c9c8521bc24fd26bb186 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Thu, 8 Jan 2026 21:50:38 -0300
Subject: [PATCH] libavformat/evcdec.c: add a check to ensure
 evc_frame_merge_bsf is present

While the inclusion of the bsf is forced by a configure check, it's better to not
just have the code here assume filter will never be NULL.

Fixes Coverity issue CID 1680305.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/evcdec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 9e735fab55..7ba9fdca54 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/evcdec.c
@@ -104,6 +104,9 @@ static int evc_read_header(AVFormatContext *s)
     EVCDemuxContext *c = s->priv_data;
     int ret = 0;
 
+    if (!filter)
+        return AVERROR_BUG;
+
     st = avformat_new_stream(s, NULL);
     if (!st) {
         ret = AVERROR(ENOMEM);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org