Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: James Almer <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PR] libavformat/evcdec.c: add a check to ensure evc_frame_merge_bsf is present (PR #21417)
Date: Fri, 09 Jan 2026 00:52:01 -0000
Message-ID: <176791992227.25.3767523417190497228@4457048688e7> (raw)

PR #21417 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21417
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21417.patch

While the inclusion of the bsf is forced by a configure check, it's better to not just have the code here assume filter will never be NULL.

Fixes Coverity issue CID 1680305.


>From 588ef047a057493439b1c9c8521bc24fd26bb186 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Thu, 8 Jan 2026 21:50:38 -0300
Subject: [PATCH] libavformat/evcdec.c: add a check to ensure
 evc_frame_merge_bsf is present

While the inclusion of the bsf is forced by a configure check, it's better to not
just have the code here assume filter will never be NULL.

Fixes Coverity issue CID 1680305.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/evcdec.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/evcdec.c b/libavformat/evcdec.c
index 9e735fab55..7ba9fdca54 100644
--- a/libavformat/evcdec.c
+++ b/libavformat/evcdec.c
@@ -104,6 +104,9 @@ static int evc_read_header(AVFormatContext *s)
     EVCDemuxContext *c = s->priv_data;
     int ret = 0;
 
+    if (!filter)
+        return AVERROR_BUG;
+
     st = avformat_new_stream(s, NULL);
     if (!st) {
         ret = AVERROR(ENOMEM);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2026-01-09  0:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176791992227.25.3767523417190497228@4457048688e7 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git