[FFmpeg-devel] [PR] tests/fate/id3v2: don't use a reference file for fate-id3v2-invalid-tags (PR #21416)

[FFmpeg-devel] [PR] tests/fate/id3v2: don't use a reference file for fate-id3v2-invalid-tags (PR #21416)

[James Almer via ffmpeg-devel]

PR #21416 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21416
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21416.patch

This test only checks that the command fails, so there's no need to compare a printed error message.

This fixes running the test under Valgrind, where more, unrelated lines areprinted, making the comparison fail.


>From a82f8961045d19a2ad055fa11d0997923a61be49 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Thu, 8 Jan 2026 21:46:34 -0300
Subject: [PATCH] tests/fate/id3v2: don't use a reference file for
 fate-id3v2-invalid-tags

This test only checks that the command fails, so there's no need to compare a
printed error message.

This fixes running the test under Valgrind, where more, unrelated lines are
printed, making the comparison fail.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/fate/id3v2.mak | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/fate/id3v2.mak b/tests/fate/id3v2.mak
index 1893556103..a3040e9759 100644
--- a/tests/fate/id3v2.mak
+++ b/tests/fate/id3v2.mak
@@ -2,7 +2,8 @@ FATE_ID3V2_FFPROBE-$(CONFIG_MP3_DEMUXER) += fate-id3v2-priv
 fate-id3v2-priv: CMD = probetags $(TARGET_SAMPLES)/id3v2/id3v2_priv.mp3
 
 FATE_ID3V2_FFMPEG-$(CONFIG_MP3_DEMUXER) += fate-id3v2-invalid-tags
-fate-id3v2-invalid-tags: CMD = run $(FFMPEG) -nostdin -hide_banner -loglevel fatal -i $(TARGET_SAMPLES)/id3v2/invalid-tags.mp3 -f null - 2>&1 || true
+fate-id3v2-invalid-tags: CMD = run $(FFMPEG) -nostdin -hide_banner -i $(TARGET_SAMPLES)/id3v2/invalid-tags.mp3 -f null - || true
+fate-id3v2-invalid-tags: CMP = null
 
 FATE_ID3V2_FFMPEG_FFPROBE-$(call REMUX, MP3) += fate-id3v2-priv-remux
 fate-id3v2-priv-remux: CMD = transcode mp3 $(TARGET_SAMPLES)/id3v2/id3v2_priv.mp3 mp3 "-c copy" "-c copy -t 0.1" "-show_entries format_tags"
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org