From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A44874DF07 for ; Wed, 7 Jan 2026 20:06:59 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'53fpzJALpYowxUrQso4z/9vrhIF7B9x35MdXei1qmZ4=', expected b'SI797Gd9lRmAEFnHNIk2VBIW/GTcul7GRHn3oO0zjpA=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767816409; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=53fpzJALpYowxUrQso4z/9vrhIF7B9x35MdXei1qmZ4=; b=eKfup9CCJgMqw0AxcZ6wR7E7UKo4OHESgrRC2TOtnTH0m5V0gxRDudfhelnQyABY1MbqO m0EIt8+ufhTYC1QFcwQvWFk7lS9XJsJUeatXHtU/+H346OWItImx8xPQl6C655PB4z8YPDP m7hjIW+5dqSZEclQ0Tzjl+1+wIZdBMrqjaMImjinNciurTNid1NJJy4w8+qB2/yiWGMCTqP qsOViR21eKduRpZDXIYLs7gwcL6zmhVkaNesdD/cUPu5VkodfUx2S5/OJxMEeimLnfqaEVT EYp9+Tr9shGk+fo1w04ElYQrLXpl67p6vSkWh06JBmsP6hWebGzrthXDBCeg== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B3532690D93; Wed, 7 Jan 2026 22:06:49 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767816394; b=j7CQ5T2A0su/FOZBnYOH/knzWJxyuZAyUA7KM+wwbwS0zBeNHtKSIWJirXaCohmN0F+cX +Cp63iSbTaCJ7AMwtgeQN8eXaexLmz+YK1Lyio1zkgyvUUYOwkrhIjwFGoNwy+IYXr/YR7F XXsIm6fh912zu74wgIbzQkNVLTeagOwYDrXVRSxObcxIySpcQ+hR/cZzdLe7OtSSXt3SyNW FMkWFwp7bpY0eey3mqCS7u4OqBGVdRvR9m47Lk5LsBeuS+RyIy4/tGBVokHxJk4GAxOjyWs VONSmJafKTJPU/00eBbq1LK2664nEsIEHp1HRbGgKyIjsObvVsnQoeMzpGKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767816394; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=2EswVPYovoa/4m9WMET4YZMiBzi5F8ie2Ti6dwcfW5s=; b=ctRJYlPVO57vtwEf7yOp956gu5CCTMBzX0GHdSHh1DsTyJag+0eV8tfIRYtsNzdJdy3Ij UKdD5saezyMSjne+HkmgADTHPP/pdn12VahVOvL2He2KZPMgHLUeO1VFi7yUUKqecsFrJF+ dTvNlHnfh9uv8IXizP/ULN7BI9tZmDjyZRn8MxbZ3NySQYuiLIE+KiFZ/IXIXmaaDjeUWhj rDBmxvPBefNYckUPZ+z7kI+Z2D474Z3cG+fvsHZOa1ISs8muLtAY8/uyrOXjzf4F8lH3WX6 RmdUSSXhIbefTTcfQHJ//qctlCFyODVrOeRx3SDCyVzvfnoLVn7AQVdcwdGw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767816386; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=SI797Gd9lRmAEFnHNIk2VBIW/GTcul7GRHn3oO0zjpA=; b=oOUwAYe2/4rgagRuxOAVu6CE8+iFfwob69dZ1wD3elK1L8Ypr2CmHn3vf2bPNcOyjln1G 4B06iLZVCgPvqcB7CL/iE/Tlv5+WGc07PkiB1PzuBItllANKUy8rlKKX9N8u6k460XThwvu QTC5aLRSkVTdSZoUW9fCHwoZRsTWHvp95x3kqrLdzM9fP9pbUPjtlU39Lhk2gzzKEe0HJwi V2tRzpi5JMlK9wqs9mqfmtpK+VyD5FrElEEpCPUF/BGxBGeTaB9XX+0GfPYmh0t0JM7FBzZ X+h5RVuvPMaP6HmsefcFDGnRzpwF77ScQTGyETivGgwP5fdtJUHwpAXwN7tw== Received: from de3a2b3407a2 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9975A690D22 for ; Wed, 7 Jan 2026 22:06:26 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 07 Jan 2026 20:06:26 -0000 Message-ID: <176781638675.25.17393293602601000900@4457048688e7> Message-ID-Hash: DM77WWI5JSOOF4KPU3OG2TKOKCNOJQOG X-Message-ID-Hash: DM77WWI5JSOOF4KPU3OG2TKOKCNOJQOG X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avfilter/vf_find_rect: Fix handling odd sized images (PR #21409) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: michaelni via ffmpeg-devel Cc: michaelni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21409 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21409 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21409.patch Fixes: out of array read Fixes: #YWH-PGM40646-17 Found-by: An0n99X Signed-off-by: Michael Niedermayer >>From 6a0822317a3e60c9c8611dc47bc1ea09c89d0657 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Wed, 7 Jan 2026 20:48:34 +0100 Subject: [PATCH] avfilter/vf_find_rect: Fix handling odd sized images Fixes: out of array read Fixes: #YWH-PGM40646-17 Found-by: An0n99X Signed-off-by: Michael Niedermayer --- libavfilter/vf_find_rect.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c index 037be36fc5..b0be1a6f11 100644 --- a/libavfilter/vf_find_rect.c +++ b/libavfilter/vf_find_rect.c @@ -80,8 +80,10 @@ static AVFrame *downscale(AVFrame *in) src = in ->data[0]; dst = frame->data[0]; - for(y = 0; y < frame->height; y++) { - for(x = 0; x < frame->width; x++) { + int w2 = in->width/2; + int h2 = in->height/2; + for(y = 0; y < h2; y++) { + for(x = 0; x < w2; x++) { dst[x] = ( src[2*x+0] + src[2*x+1] + src[2*x+0 + in->linesize[0]] @@ -91,6 +93,22 @@ static AVFrame *downscale(AVFrame *in) src += 2*in->linesize[0]; dst += frame->linesize[0]; } + src = in ->data[0]; + dst = frame->data[0]; + for(y = 0; y < frame->height; y++) { + int yd = y < h2 ? in->linesize[0] : 0; + x = yd ? w2 : 0; + for(; x < frame->width; x++) { + dst[x] = ( src[2*x+0] + + src[FFMIN(2*x+1, w2)] + + src[2*x+0 + yd] + + src[FFMIN(2*x+1, w2) + yd] + + 2) >> 2; + } + src += 2*in->linesize[0]; + dst += frame->linesize[0]; + } + return frame; } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org