[FFmpeg-devel] [PR] avcodec/mjpegdec: remove unused buggy_avid variable (PR #21404)

[Ramiro Polla via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #21404 opened by Ramiro Polla (ramiro)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21404
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21404.patch

This variable has been unused since b6c04b6821.


>From 3827e07dd6f325be5d1e5083ec35d5f7f2ddd01e Mon Sep 17 00:00:00 2001
From: Ramiro Polla <ramiro.polla@gmail.com>
Date: Wed, 7 Jan 2026 04:52:35 +0100
Subject: [PATCH] avcodec/mjpegdec: remove unused buggy_avid variable

This variable has been unused since b6c04b6821.
---
 libavcodec/mjpegdec.c | 5 +----
 libavcodec/mjpegdec.h | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
index 417cedae4a..64f2475183 100644
--- a/libavcodec/mjpegdec.c
+++ b/libavcodec/mjpegdec.c
@@ -100,7 +100,6 @@ static int init_default_huffman_tables(MJpegDecodeContext *s)
 
 static void parse_avid(MJpegDecodeContext *s, uint8_t *buf, int len)
 {
-    s->buggy_avid = 1;
     if (len > 12 && buf[12] == 1) /* 1 - NTSC */
         s->interlace_polarity = 1;
     if (len > 12 && buf[12] == 2) /* 2 - PAL */
@@ -1893,8 +1892,7 @@ static int mjpeg_decode_app(MJpegDecodeContext *s)
         av_log(s->avctx, AV_LOG_DEBUG, "APPx (%s / %8X) len=%d\n",
                av_fourcc2str(av_bswap32(id)), id, len);
 
-    /* Buggy AVID, it puts EOI only at every 10th frame. */
-    /* Also, this fourcc is used by non-avid files too, it holds some
+    /* This fourcc is used by non-avid files too, it holds some
        information, but it's always present in AVID-created files. */
     if (id == AV_RB32("AVI1")) {
         /* structure:
@@ -1904,7 +1902,6 @@ static int mjpeg_decode_app(MJpegDecodeContext *s)
             4bytes      field_size
             4bytes      field_size_less_padding
         */
-            s->buggy_avid = 1;
         i = bytestream2_get_byteu(&s->gB); len--;
         av_log(s->avctx, AV_LOG_DEBUG, "polarity %d\n", i);
         goto out;
diff --git a/libavcodec/mjpegdec.h b/libavcodec/mjpegdec.h
index 4f4139dcc4..c2f83ac949 100644
--- a/libavcodec/mjpegdec.h
+++ b/libavcodec/mjpegdec.h
@@ -127,7 +127,6 @@ typedef struct MJpegDecodeContext {
     int restart_interval;
     int restart_count;
 
-    int buggy_avid;
     int cs_itu601;
     int interlace_polarity;
     int multiscope;
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org