From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6C11B4CEA1 for ; Wed, 31 Dec 2025 21:06:44 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'MtcaCpfiobdjlG/t5GAQi1zf3zuiEIpd/kRXy+CEduc=', expected b'TskNZp0BmAQxdxiamWfqp5SKbD8m8YWmtLjHvC6TX0o=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767215196; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=MtcaCpfiobdjlG/t5GAQi1zf3zuiEIpd/kRXy+CEduc=; b=W60MPpkRsW9BC0mufiAmcA0tStfhNHlI0k8Ea+g7n+N4UY6QN+TLb0XtUZggeZJznfzO9 R9yI/Hi6Fe0ea7Qm9K0XXrNQsS2DBblvdf0kEHYI8ZrnZ7TllBwiwlpaaWiFInhN31DVSMK v6WzK6PPde3B/+UI2jK4xN1JE8FjaFbpeZrwNKWw40H3WRhJn9+wSCURlG5zA3MIiyt/RYY GV9qLXZRWMxpxRQ105/6VrcCnKfqoklbn13/Zgb2y3a06EzvhNgSLoYmuvITyIq/zUpM1bm 89x4EJf0D8Q1g98csqFoYgwuJ7uFDcbbdqpiWEWM9ggp6zY91xcIZkVkzG3A== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B6F82690C4B; Wed, 31 Dec 2025 23:06:36 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767215184; b=N0LOonT+0kUz7PV8el2lBTeQeRrpTfMNNDY7ZA37PptMcNYHZcdx6JN8uO1kBmKUm3Geg KHNsniYT/Vg0rp4bbFGIDiZ09m6Bt+b1ZLcCb2EfDl3ejJfeHcQiuPQID41X+AYKfoaGemb shF0PZ3zgDpAjsTjSkV7Co/cg+FZ+yCP5Wr7AIdFeVu9UgyHsO9MF0ibEcHiHdhumlLZnYm ug8nxompxDD+82gtRE05V1JS5VBGDmr4EyhlpeOPpQTVd13oe/POevv1YEhnY4kxTAuhljH fjLJ2xFXghSndHlKmKdcjUneILw9di9Jz9qX4uvK9m4PqH2jpZvdUEyPTZnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767215184; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=E06XCp/+6PU2Fwj+aFt4YzawgeJo1aCJetTjE3G+B3M=; b=gDKU8NX0hipdE6BkuJi4y8UTBnqvQtI/aT4UOECtiXqsaNHj3fwPQJ9Q62DRXXLLMfSyE eGuBSguAbQr5YZuRk0+D/0re5WTPbRkaxoxYfkI/jC0Qq5/XypWZ6xIplQL8lC+M5YWhLJB Enn/R4GqbStrF8L6jysyoMw1OY2C3Eygdwsa0Xx0W06FEm9acZIoJgUKZzdX9cRVUMqJR9j zpthVywcpAKLpsOFlQOw279K7TbKnnOrgOEksMglmXdkk/tVAHrXtn6ec4yvSTeaUb5+c/Z JxFI4Ltm+LHadV0tjokxkSmP2p18k9F73e4O0EqNS3m1+Xq5XsaJ6ExaMXGA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767215176; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=TskNZp0BmAQxdxiamWfqp5SKbD8m8YWmtLjHvC6TX0o=; b=jvvsg86K/MO+dcgoDwQqbbwdArxCmXBkG1AqdUICtn99vHBU2ZmOxxuTExuVTsy/coDVb ksbhluiegOrwffDTfzHpBjnIfzrdRQ2fhO8FtRjCJpZby63m4el8aNHRdwooMzL4j/qsg2t UccDz9qGEMJ9jvIKM2KYphaBTL6SC70PJsUt9K0kfPMhxzIRoD87Os9GzGMi9iT3lKz1OhZ tRClbe6gkDTS33Sne7PqK5v4RQh+eC9ogMBjDXv5dekXmOlQpeXT7VmLaBlUOwERJxLi1T8 zcL0g07kpwiT6O5yZv6oI5OXEYmoXCl5YNjkguXjwcqr+Qd5HqCrpNwnwsOQ== Received: from de3a2b3407a2 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5F90F690502 for ; Wed, 31 Dec 2025 23:06:16 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 31 Dec 2025 21:06:15 -0000 Message-ID: <176721517657.25.15724354509026845555@4457048688e7> Message-ID-Hash: MG6VUWVWFNMTPBFYXK4CI6DI5OOS7BDA X-Message-ID-Hash: MG6VUWVWFNMTPBFYXK4CI6DI5OOS7BDA X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PR] avcodec/exr: enforce maximum channel limit to avoid excessive memory allocations (PR #21347) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Timo Rothenpieler via ffmpeg-devel Cc: Timo Rothenpieler Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21347 opened by Timo Rothenpieler (BtbN) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21347 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21347.patch A specially crafted file could define an unlimited number of channels, leading to ever-growing memory allocations and even overflows in the size calculation. Also fixes the not properly checked allocation via av_realloc. Fixes #YWH-PGM40646-33 >>From 025e88a32c87eaf3e6f912ed51521d020a9a85b2 Mon Sep 17 00:00:00 2001 From: Timo Rothenpieler Date: Wed, 31 Dec 2025 22:02:34 +0100 Subject: [PATCH 1/2] avcodec/exr: only assign result of av_realloc on allocation success --- libavcodec/exr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 536a55c5be..8b9fe4b3fc 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1603,6 +1603,7 @@ static int decode_header(EXRContext *s, AVFrame *frame) int layer_match = 0; int ret; int dup_channels = 0; + void *tmp; s->current_channel_offset = 0; s->xmin = ~0; @@ -1807,12 +1808,13 @@ static int decode_header(EXRContext *s, AVFrame *frame) } } - s->channels = av_realloc(s->channels, - ++s->nb_channels * sizeof(EXRChannel)); - if (!s->channels) { + tmp = av_realloc(s->channels, ++s->nb_channels * sizeof(EXRChannel)); + if (!tmp) { ret = AVERROR(ENOMEM); goto fail; } + s->channels = tmp; + channel = &s->channels[s->nb_channels - 1]; channel->pixel_type = current_pixel_type; channel->xsub = xsub; -- 2.49.1 >>From c97c5fa2f3598c14858ec6fb357537ae4fe1c36b Mon Sep 17 00:00:00 2001 From: Timo Rothenpieler Date: Wed, 31 Dec 2025 22:02:52 +0100 Subject: [PATCH 2/2] avcodec/exr: enforce maximum channel limit to avoid excessive memory allocations A specially crafted file could define an unlimited number of channels, leading to ever growing memory allocations and even overflows in the size calculation. Fixes #YWH-PGM40646-33 --- libavcodec/exr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 8b9fe4b3fc..10078b462f 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -59,6 +59,8 @@ #include "mathops.h" #include "thread.h" +#define MAX_CHANNELS 1024 + enum ExrCompr { EXR_RAW, EXR_RLE, @@ -1808,6 +1810,12 @@ static int decode_header(EXRContext *s, AVFrame *frame) } } + if (s->nb_channels >= MAX_CHANNELS) { + av_log(s->avctx, AV_LOG_ERROR, "Number of channels exceeds supported maximum of %d.\n", MAX_CHANNELS); + ret = AVERROR_INVALIDDATA; + goto fail; + } + tmp = av_realloc(s->channels, ++s->nb_channels * sizeof(EXRChannel)); if (!tmp) { ret = AVERROR(ENOMEM); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org