From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 90BED4DAEB for ; Tue, 23 Dec 2025 19:31:17 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'g2tygBEpvXfO4UNI6t8b5OdW70WLiARpWrFZslQK+ek=', expected b'PzHwLHeEUUYj8br2/8t8hdXqWJHNPM25Vs8o34GStwc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766518268; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=g2tygBEpvXfO4UNI6t8b5OdW70WLiARpWrFZslQK+ek=; b=2PYeSGiKWKoN7vdy0Xdjf4JQlYk3t2oBm6GbnWehmI+QmklcjG5ScYbRFvHG4B5QB9dAr gcF/PVQ8N/ie7XkqKIAXznRz9/KojOrq6T6nxn7HTPHbPTmud2J3dWg9lCh/Vhn55ZCF07p Pz5hY6qZkQQ8QQCANj6QkpisPEl912FEXnBiUqbO37hDLO7qAUkOQoW0tIJOOt38eChl0JU Ft24RYzb+6cvHpidTKNZkNqnmyLFQFTaf1nDI8WL6q+oEsk5a/h848+L363WgtTV0LUJhCI f3jGY3Ipu+ol2YFlG4IP8TwCjUIlnh4BULjJmN4aWL1k8fsGJes/hsEka19Q== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6201A690B46; Tue, 23 Dec 2025 21:31:08 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766518257; b=LzILi0VsNjT5QwsUTn1xWSFQ4bLpO1RyRTp9HC4yUKy3wrW8XhvtuAH1uq1LWXAthhmqF 52GDPqD0/LhCJ3dUYV3fj2OFFF8stofUVDn7SPUE23p36QC3DN4vcR7B7Ha2SazN44Weqn0 OdUwEYU+y46BlNlqULCF1wTwZ3jZwzEJ8IcgbhNMzh/dnoOL68u64I2CzsImkwtJvIVvqpO E1bd5W1s5XhRsjOQyVT5e3caYOdsTMdvlk6u05Z7Q4pCOwpoTjU1fmq1v8PXc7uH+37k6t0 TUFZIJa1+ZYdQmkmVfDrCONccfxs8ZY+DU81gAcn5C6i3Gv9bTxqbhNq9YKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766518257; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=qna2beiRME8S7htM2288yVXDRICkcQsF/tos3of3XWg=; b=OvaRBJdOtFHxCvhdsOVAAEuaRbRPan1CgwBwUgcb4syEgEOd6AJSksZ1f2N9CeIj3RE+E E6hn9g5Hm1zP/jW3jFflyV0klYa4BG3IkLktEZlTBoIGfgqv3UmRIAZEu0ilbINoX+lQU0H hZ4Am+meiV9PVSAifY1A3ut6HC46w0hlfdd/qD2AeZBVEzmm4zkf7QsnGrcE72UaAcqtWPQ MALEuD0zOth1QhuPuUupLr2gUJWCg3jCrKCUBnITOZ+jWNpJmrzLkGvrz5Y+6KZsjFlJUtn O5rKBRELaK5/C95+XHwJEC9nB52dp5AwzaZr2LcL3da1RurFKQtUoDUYFIUA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766518249; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=PzHwLHeEUUYj8br2/8t8hdXqWJHNPM25Vs8o34GStwc=; b=kDVMWYAFaHaMNXQDuBRk6NpRRZlE1TAgxeyK+vReAHk8hAkXvF48J6jHcsD+ClwJTpaf+ MBz4vicrw8LETLWRFvoxgj5P1MetbgsGKStwpb9bmQQqBftsaavJUMo49zCF8u9AQ/nlASX hOiT2rOk4DzrrrRDo84D7+3wbbKsz/9hRXApOpcPYhCQupPejiISrnLfLD9zUwYu+a9rjYD dIs2jwQrfnttfTC1RHFXoTRgMKwEosHNqrXBmSLV0vp4PhxEYyXG6cXYI2Hqj/0OUlEJSFf Nl/jZU6ayshD/hUDcoFgHRyJ5aG1zOWqUfbkjAVYrFOn7TR0bNQYPwWMu3hg== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0B5E0690AFB for ; Tue, 23 Dec 2025 21:30:49 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Dec 2025 19:30:48 -0000 Message-ID: <176651824921.60.15568546913576070275@2cb04c0e5124> Message-ID-Hash: CWPNJBOFKKPKUSRERCTJIMIDOKHHWDAN X-Message-ID-Hash: CWPNJBOFKKPKUSRERCTJIMIDOKHHWDAN X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/dca_xll: fix use of uninitialized memory of get_rice_array() (PR #21285) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: michaelni via ffmpeg-devel Cc: michaelni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21285 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21285 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21285.patch >>From f559146bb79277e0bb52d117516f93f7bb7ae28a Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Tue, 23 Dec 2025 16:22:23 +0100 Subject: [PATCH 1/2] avcodec/dca_xll: Check get_rice_array() Fixes: use of uninitialized memory Fixes: 451655450/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DCA_DEC_fuzzer-6527248623796224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dca_xll.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c index 0e9a4e77e7..86e992bf1c 100644 --- a/libavcodec/dca_xll.c +++ b/libavcodec/dca_xll.c @@ -64,12 +64,16 @@ static void get_linear_array(GetBitContext *gb, int32_t *array, int size, int n) array[i] = get_linear(gb, n); } -static void get_rice_array(GetBitContext *gb, int32_t *array, int size, int k) +static int get_rice_array(GetBitContext *gb, int32_t *array, int size, int k) { int i; - for (i = 0; i < size; i++) + for (i = 0; i < size && get_bits_left(gb) > k; i++) array[i] = get_rice(gb, k); + + if (i < size) + return AVERROR_INVALIDDATA; + return 0; } static int parse_dmix_coeffs(DCAXllDecoder *s, DCAXllChSet *c) @@ -529,8 +533,10 @@ static int chs_parse_band_data(DCAXllDecoder *s, DCAXllChSet *c, int band, int s } else { // Rice codes // Unpack all residuals of part A of segment 0 - get_rice_array(&s->gb, part_a, c->nsamples_part_a[k], - c->bitalloc_part_a[k]); + int ret = get_rice_array(&s->gb, part_a, c->nsamples_part_a[k], + c->bitalloc_part_a[k]); + if (ret < 0) + return ret; if (c->bitalloc_hybrid_linear[k]) { // Hybrid Rice codes @@ -560,7 +566,9 @@ static int chs_parse_band_data(DCAXllDecoder *s, DCAXllChSet *c, int band, int s } else { // Rice codes // Unpack all residuals of part B of segment 0 and others - get_rice_array(&s->gb, part_b, nsamples_part_b, c->bitalloc_part_b[k]); + ret = get_rice_array(&s->gb, part_b, nsamples_part_b, c->bitalloc_part_b[k]); + if (ret < 0) + return ret; } } } -- 2.49.1 >>From 09bdd5b7ecf2b98e5cb7e916fdcd456e521476db Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Tue, 23 Dec 2025 16:24:22 +0100 Subject: [PATCH 2/2] avcodec/dca_xll: Clear padding in pbr_buffer The testcase is already fixed by the previous commit Fixes: use of uninitilaized memory Fixes: 451655450/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DCA_DEC_fuzzer-6527248623796224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dca_xll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c index 86e992bf1c..20ace57271 100644 --- a/libavcodec/dca_xll.c +++ b/libavcodec/dca_xll.c @@ -1102,6 +1102,7 @@ static int copy_to_pbr(DCAXllDecoder *s, const uint8_t *data, int size, int dela return AVERROR(ENOMEM); memcpy(s->pbr_buffer, data, size); + memset(s->pbr_buffer + size, 0, DCA_XLL_PBR_BUFFER_MAX + AV_INPUT_BUFFER_PADDING_SIZE - size); s->pbr_length = size; s->pbr_delay = delay; return 0; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org