From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A259C49359 for ; Tue, 23 Dec 2025 01:24:06 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'T5ErMy/m1fakCtZRvlpz+wDv4t9ztHHt+A6FH4XEqBQ=', expected b'i8eETYnJnflPaYrgN7sS9tbDHQbTosO8/649pnYp8Uc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766453030; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=T5ErMy/m1fakCtZRvlpz+wDv4t9ztHHt+A6FH4XEqBQ=; b=B71D9/x4mc+3JozYGDIEiYxGtZJ+hLRemTLGFHdJgWTj7c84ks2rwSu6RwzUEIzQKc1lx fTWUsPXwNJa0v1qKoXSMOiWJXhivdBls2948T7pXNO0OqvMIM2vySwLEQga8VOvrvFaYYXs O3DNQz6+lOid1DQQ24olSCALrWy3UZ+hq3ifBnIbeIa5VNwTj79P6oQLku+LlO/81cDAdXV GUIcp8Vy+mLptjwCP/LLIliu7TNM7GnWJxD7tbhAG+Ud5oYWZczRAgpa/Y6Hw7vYPAbL1ge mPv0u+ctO6VdTEnW1FzvZs2/VidgHC1/7II9wdYnnVaX1HqfguE7FVg+gFAw== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D2042690B01; Tue, 23 Dec 2025 03:23:50 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1766453023; b=N07GiVCNJT32EV4D3IXChLEmpDSim4mqWF9X/2iPd0TMwDie44NYGSg4dqF8vK9pE7kUE oUY2aXMCS7I87lx7SCcR9meEFagMf5H10HsnVVSFST1ZoyRRzxpP53GxRNQsXI7UDEyfE1K 1mYPbECj7xv49V3lDzMAFKIb6WPHVQ0FDHeQ0KyusIFT3bIuWDJQNZ7YaXd6XHYvQxy6QNG a+ACRUhKyeKD1yz6BQ5ScwLOnwtZYCCh9KlBXsaR3IhdjSb7rCnfLrxgRH4U0hftq30Hbk2 iyZcSkZZKNrfctrPwVjiz/S0GqMmvbStmLX/DRqpLlkufa2hgNIMpgqlOwOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1766453023; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=XttGB8eLVJpHekGmjFCJs98eA0XJiENVyL605UrfIsU=; b=RQAjgujq0dtw0ZqkklvaF7cZhOpZzWwiV5tAIH80oPvfpegWhw7L0ei6blQAieZSgwpbh gWG/Tg0rGGLJMHQrdQI/FXV7qWkuyfh3xfNDfbDwO5FGFP9J3AAeKc7+7pv4wWVypAfyaJN TwAGYP0OcqbsSfGBpqo3QbEJgew6JNkCqX1Iy3JnR4+mRIudwnvfpVi9MfU1CY+9MoQXhkb fLNzyrKaDdK+2d+TPH6xuJz3KSow3hxlUapSNOYCgTvPED+PDrdPBhm2EqQsbeUjI+jV5D4 JJsuvErowxIBbjxRQiVF//KvzUGRU3I9c89tlQmAm5/i90qH9yWGYgaTen7Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1766453014; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=i8eETYnJnflPaYrgN7sS9tbDHQbTosO8/649pnYp8Uc=; b=AmerVYhiX1vyt1fAJb6ljQbJ1bhSFB3r9fmlDXT5O9Dl6dS7juCEdAsBuKBG2Ba9GBdJw IRtQMwxx8kek9KA5MV7YxUE5cqVlrZY0b8KrUcpKdc4O4nxJ9J39GCUKdoZX/LTKzW1ilN1 JRxlcRAEBfbTcTZIfmZQu/y2QJGGz9BU0+WL2HZdOd7v/Ne+v11Sa+ma0Yks8N90mCZuj7r imTwDX1piLasXCDeqII8MvXGR9NSsp9vvHwL0OEf0wIZpLK0oKg56aWvD3Yv3PCIpew896C H8V++fcS8tiW5FBgOsHoktWLlp3pRSP0MblCx3UiE3bzfTueRrU8O6J8AKFQ== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 49D1D690825 for ; Tue, 23 Dec 2025 03:23:34 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Dec 2025 01:23:33 -0000 Message-ID: <176645301447.60.839409092490857918@2cb04c0e5124> Message-ID-Hash: AGRBGVDSOMO36CAS2M2JUSI3O2D6N2T6 X-Message-ID-Hash: AGRBGVDSOMO36CAS2M2JUSI3O2D6N2T6 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] Use av_unreachable() instead of av_assert0(0) at the end of non-void functions (PR #21270) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: James Almer via ffmpeg-devel Cc: James Almer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21270 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21270 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21270.patch Fixes compilation with gcc-tsan and --disable-optimizations. >>From bb334f05b967673fb7caeb8dcc6469927cc03ddc Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 22 Dec 2025 22:19:01 -0300 Subject: [PATCH 1/3] fftools/ffmpeg_enc: use av_unreachable instead of av_assert0(0) at the end of a non-void function Fixes compilation with gcc-tsan and --disable-optimizations Signed-off-by: James Almer --- fftools/ffmpeg_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 0f7d961472..a595912933 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -728,7 +728,7 @@ static int encode_frame(OutputFile *of, OutputStream *ost, AVFrame *frame, } } - av_assert0(0); + av_unreachable("encode_frame() loop should return"); } static enum AVPictureType forced_kf_apply(void *logctx, KeyframeForceCtx *kf, -- 2.49.1 >>From 3d6ee50fb545dd6dcc2519ecbe5cb52450a53d8b Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 22 Dec 2025 22:19:11 -0300 Subject: [PATCH 2/3] fftools/ffmpeg_sched: use av_unreachable instead of av_assert0(0) at the end of a non-void function Fixes compilation with gcc-tsan and --disable-optimizations Signed-off-by: James Almer --- fftools/ffmpeg_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index c5ee6971f1..0d820acb8e 100644 --- a/fftools/ffmpeg_sched.c +++ b/fftools/ffmpeg_sched.c @@ -2654,7 +2654,7 @@ static int task_cleanup(Scheduler *sch, SchedulerNode node) case SCH_NODE_TYPE_DEC: return dec_done (sch, node.idx); case SCH_NODE_TYPE_ENC: return enc_done (sch, node.idx); case SCH_NODE_TYPE_FILTER_IN: return filter_done(sch, node.idx); - default: av_assert0(0); + default: av_unreachable("Invalid node type?"); } } -- 2.49.1 >>From 39ab9effb99651f5fbc289c420e784944485c4cc Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 22 Dec 2025 22:19:37 -0300 Subject: [PATCH 3/3] avcodec/cbs_apv: use av_unreachable instead of av_assert0(0) at the end of a non-void function Fixes compilation with gcc-tsan and --disable-optimizations Signed-off-by: James Almer --- libavcodec/cbs_apv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_apv.c b/libavcodec/cbs_apv.c index be52c2e511..f6f701b9dd 100644 --- a/libavcodec/cbs_apv.c +++ b/libavcodec/cbs_apv.c @@ -33,7 +33,7 @@ static int cbs_apv_get_num_comp(const APVRawFrameHeader *fh) case APV_CHROMA_FORMAT_4444: return 4; default: - av_assert0(0 && "Invalid chroma_format_idc"); + av_unreachable("Invalid chroma_format_idc"); } } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org