[FFmpeg-devel] [PATCH] avcodec/demux: validate avctx state in has_decode_delay_been_guessed (PR #21215)

[FFmpeg-devel] [PATCH] avcodec/demux: validate avctx state in has_decode_delay_been_guessed (PR #21215)

[Timo Rothenpieler via ffmpeg-devel]

PR #21215 opened by Timo Rothenpieler (BtbN)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21215
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21215.patch

There are cases where the codecpar and avctx codec can differ, or potentially the latter might not even be opened.

Fixes #YWH-PGM40646-20


>From 5107836dc9fb4bf433295f00891c52c80f2cfdd2 Mon Sep 17 00:00:00 2001
From: Timo Rothenpieler <timo@rothenpieler.org>
Date: Tue, 16 Dec 2025 15:17:55 +0100
Subject: [PATCH] avcodec/demux: validate avctx state in
 has_decode_delay_been_guessed

Fixes #YWH-PGM40646-20
---
 libavformat/demux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/demux.c b/libavformat/demux.c
index 934eb80553..3777b5288f 100644
--- a/libavformat/demux.c
+++ b/libavformat/demux.c
@@ -752,6 +752,8 @@ static int has_decode_delay_been_guessed(AVStream *st)
     if (st->codecpar->codec_id != AV_CODEC_ID_H264) return 1;
     if (!sti->info) // if we have left find_stream_info then nb_decoded_frames won't increase anymore for stream copy
         return 1;
+    if (!avcodec_is_open(sti->avctx) || sti->avctx->codec_id != AV_CODEC_ID_H264)
+        return 1;
 #if CONFIG_H264_DECODER
     if (sti->avctx->has_b_frames &&
         avpriv_h264_has_num_reorder_frames(sti->avctx) == sti->avctx->has_b_frames)
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org