Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Timo Rothenpieler via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Timo Rothenpieler <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] avcodec/demux: validate avctx state in has_decode_delay_been_guessed (PR #21215)
Date: Tue, 16 Dec 2025 14:20:35 -0000
Message-ID: <176589483556.60.14820417131956836447@2cb04c0e5124> (raw)

PR #21215 opened by Timo Rothenpieler (BtbN)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21215
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21215.patch

There are cases where the codecpar and avctx codec can differ, or potentially the latter might not even be opened.

Fixes #YWH-PGM40646-20


>From 5107836dc9fb4bf433295f00891c52c80f2cfdd2 Mon Sep 17 00:00:00 2001
From: Timo Rothenpieler <timo@rothenpieler.org>
Date: Tue, 16 Dec 2025 15:17:55 +0100
Subject: [PATCH] avcodec/demux: validate avctx state in
 has_decode_delay_been_guessed

Fixes #YWH-PGM40646-20
---
 libavformat/demux.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/demux.c b/libavformat/demux.c
index 934eb80553..3777b5288f 100644
--- a/libavformat/demux.c
+++ b/libavformat/demux.c
@@ -752,6 +752,8 @@ static int has_decode_delay_been_guessed(AVStream *st)
     if (st->codecpar->codec_id != AV_CODEC_ID_H264) return 1;
     if (!sti->info) // if we have left find_stream_info then nb_decoded_frames won't increase anymore for stream copy
         return 1;
+    if (!avcodec_is_open(sti->avctx) || sti->avctx->codec_id != AV_CODEC_ID_H264)
+        return 1;
 #if CONFIG_H264_DECODER
     if (sti->avctx->has_b_frames &&
         avpriv_h264_has_num_reorder_frames(sti->avctx) == sti->avctx->has_b_frames)
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2025-12-16 14:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176589483556.60.14820417131956836447@2cb04c0e5124 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git