From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9564040108 for ; Mon, 15 Dec 2025 08:50:29 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'Yyqnwu1bGtk0n9+IrkMK+k3M3Gi3u6jRbhl9UWKokTQ=', expected b'9067FwEUTn0lbhOYZLz7BA69ga0vY7qRgBESzBQxcTs=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1765779273; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=Yyqnwu1bGtk0n9+IrkMK+k3M3Gi3u6jRbhl9UWKokTQ=; b=tSbvDZlELFWj3nQa0+agQQEVm/3F3oogn8tG86uirAiOacaTyqY5aQOZ+9zjK+ZPf1ZDK XjFgDc27vsP2/q7KzNyEZ2MmoOj4om+Jq4D0kyqfewkmWmhbUSUVvVSepks1tgd7A112uzu +IKrHoPs82c2/vGQBLo2kBJkaKpbUkaMu8YnUgLVy3J68l41wXoD9D+WchaGGVUwgAuYJBD 2YZpoeS9jiGZULb6hoA0lE7LF1A1/0uc960OqEw/NWW0e/ls/NlpX8nvba0/ew0cZGt6ZTs GmtEWCJ3mfMikYcsz+2q2+ppccGvYdDVnQEHCA/RfLPEilyyE+XMQ+t8NUsw== Received: from [172.20.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id ACEC2690821; Mon, 15 Dec 2025 08:14:33 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1765779264; b=MXIMGm1QX+y2Pm5up2Iwj2DemKjCpkcBC+a0caVLw6o5lVQbgR/8vLLYKn7snUgfqJeFO k8YddxIzWJHKoFPYUjTD01Q2+gHB0zGLbotXy3Gt/xsDf5+vaZ7DmS/0cfr6/Yl3gROIXqP MNhx/JfnjDQxyvFvLq+WjB2wlprrOlgvk8FTeXSJ/BQEpMDauKuSMi8RuEVNNKDBJbp7fux 1rYUOwTcq64o95Xl9vCG9a1eEvRReK97kUrCxaUEl6zILT7MX1GpdS0kQsU1fncr8AvTDES DPbDCjFzMR50e61QqfjLf0j/nFnnDaC6cxTQmDsvSgFtAsHQvRz2xK+LrcZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1765779264; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=68936YGs0rJgBXPVwFhL2wbV8vl4qNJyvn5ikPUyDUY=; b=tTuJ82hCLJznfJssITy/9n/f4jrKoFZGLPxBhcJPa9uCZ1qFClF9oC4wJmid+eEy0dBmh EG7yD3d9W/41Kp28YTXxJqalBQkhfk5EVPOrBwLKCbjFIH8VDgCEgEVkO3jI1zfDspbnFo2 nEei8+7yD41Bz5Ssg441m3zBQtgZz+o5fO0ZNT8QKZmROA2tzekmh67xo65ONx3Hi/04XnT ss9B4OLS6TlrjKrgZnXanVeH1nuSTtpHHK9/kv/Hpqy+lAK2H7e9y/sPexz9Ov8xTbnK+Cd 7ccStWKkwxqZlqF4wgtuJoTbTsUUyL/Wh4tXACDyKzGuhyL5qgjaq5WoRAZA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1765779255; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=9067FwEUTn0lbhOYZLz7BA69ga0vY7qRgBESzBQxcTs=; b=HbRjjHaIZ5TBuv/Ttge+GhLoq7UijGfQZr1WliP/8u5i5YMSNWAUYI6eNHpheWBtkExEi I7lrj3aaYYS5/ltTMx9Sn8UouCpzGK/GHaDV3hkMPQoh8rVt9qsqt0bZ25cIQOUG76YFj/K AkEQOaAOv5sn/PQ+8PpvNqceu0IYEF61NWFyfj4m/bhcU+Okunt35phnNX+EUNlav7tv5fY 9frTHjiA5W9FAMdXzdc4hcfT0YdqFaeLi6zS7BV2/Bb1XTeGQOKFa+NCK/IhnTRSQTgUH9c Gf3Ul5q2NF75w6kxWMoLDfu30MWh41TiLXKGtzpEPaJ6eU3k1SbD2JZtWB0g== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 68EFD690819 for ; Mon, 15 Dec 2025 08:14:15 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 15 Dec 2025 06:14:15 -0000 Message-ID: <176577925559.60.15948815956543137918@2cb04c0e5124> Message-ID-Hash: ZKH26N75PD62UOMY7SGOA7F6SZXS4VKA X-Message-ID-Hash: ZKH26N75PD62UOMY7SGOA7F6SZXS4VKA X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] release/8.0: avfilter/feedback: fix feedback block (PR #21201) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21201 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21201 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21201.patch Fix #20940 The feedback and its sub-filter both request frame from each other, casuing block since 4440e499ba The feedback should only request inputs[1] once rather than continuously request frame cause blocking. This patch add check whether feedback already request inputs[1] via ff_outlink_frame_wanted(ctx->outputs[1]), if true, then exit and waiting inputs[0] because it means we need more frames input to proceed. Signed-off-by: Jack Lau (cherry picked from commit 3f0842294fbefcca32fdad6b644eae8c14f547e5) >>From 2333984d846186f69806a886b12cf5efeebfecc1 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Tue, 18 Nov 2025 06:45:06 +0800 Subject: [PATCH] avfilter/vf_feedback: fix feedback block Fix #20940 The feedback and its sub-filter both request frame from each other, casuing block since 4440e499ba The feedback should only request inputs[1] once rather than continuously request frame cause blocking. This patch add check whether feedback already request inputs[1] via ff_outlink_frame_wanted(ctx->outputs[1]), if true, then exit and waiting inputs[0] because it means we need more frames input to proceed. Signed-off-by: Jack Lau (cherry picked from commit 3f0842294fbefcca32fdad6b644eae8c14f547e5) --- libavfilter/vf_feedback.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_feedback.c b/libavfilter/vf_feedback.c index 6667ddfd16..e3633d7d37 100644 --- a/libavfilter/vf_feedback.c +++ b/libavfilter/vf_feedback.c @@ -245,6 +245,10 @@ static int activate(AVFilterContext *ctx) } if (!s->feed || ctx->is_disabled) { + if (!ctx->is_disabled && ff_outlink_frame_wanted(ctx->outputs[1])) { + ff_inlink_request_frame(ctx->inputs[0]); + return 0; + } if (ff_outlink_frame_wanted(ctx->outputs[0])) { ff_inlink_request_frame(ctx->inputs[0]); if (!ctx->is_disabled) -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org