From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 34F204BF45 for ; Fri, 5 Dec 2025 02:28:16 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'WLbqowPO5Luq2Bf+C8EfOAYdzGQnjgVC14AICvRhsxY=', expected b'1jZ0ciMJUN1j2C6nIv4CGnaCGyWZmI8mA2wTEfutmc4=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764901687; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=WLbqowPO5Luq2Bf+C8EfOAYdzGQnjgVC14AICvRhsxY=; b=wdESQyg/hCfPlMsw5doJv9uuQ+Sf61CeuPlHm/ElBeLmENd5DqbRFXrPHhnP/D55tOIIk RojsxzUGBir5W3/eQ2J05iEF3o5GN6VrtbMrXDbcuVwi9cPxFPuWUfPuVWowNIRrwOD69mk ETbolWKSuQzNtIqrAhnfzp/dzJgAApXOeIwKgrPezkQ0LCLgra3KIbXz0q5Fgk+SGkV/rHp eSGv6bMGCHAb/fom1Iak7EddUO+Dk/7TPCCR25Fl2M6ZVNvi8q+kMYmWCRp8t7qEb2L/320 MwIy/IgwssYHYM/iOBvAlY8JpjU9E0Ck/ZRfaYsSAX0lG2PfGe5jno7ZGL+g== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2E9BF69057D; Fri, 5 Dec 2025 04:28:07 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764901667; b=GqKVXcQ8DisjrojhzUwFhbmA4LxEtsUMtqNM5Sf2K+l5hzG48CrnoZDy7Cw6xYZQpGFw6 PaTMqXRs2ICK5hVHdutLUlQhoiZ3vtl2QOdTyFUsUYcFRhL2RiV6LuisP8sxPougLvxntgp 68flL+eR5gD01ZCdo3Aaq4XUpe/ukRtWxEf1CEPRVly0yygGuVRWiVVGcn6x5M0j8Tent5A D6O2rxNzmyrAuqU1Ly4v6t8fiJnj5AbY+6Y/4+Xar1FVtpZBNqwtfHAOON4WbaP7ZUrfEm6 LVSlbnibXlHyCqQhXF5FXO3wYEN1Kdm5bSc54w7cm1SzIiwXg5XvV1W2Y4pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764901667; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=CogwVSn0lF41yGvQVXmkBuRX4QMhY4JlDZPn2O/Z4O4=; b=bCt5T7Ibzs19F2fXZAElWGNG/7q3egRVgWbQT22y5EsyqyAXrmykxmIkeFwFptoRXtzz5 g0Llc8wbgd6ODZla9oSP+xzm2TJoMMJwsQWoJKdqeywXlO8myLDLXF4RVZ27YeyvnnsrCKW F95xSOpyCnTE1RXc1l/sIodNbjO2Zt8d3gScWRS6iAgXv7dHhRK06o8YME4k/PcPn4jnecF uY/OJ3YdwQZ9D/bvfLPTOVjqCEc0RQ2ElBI7DpKce1Gd6OW+c/X+wymgct2gBQMzDcrvgxS 235TTXLxsMpSGtEuf13tZhMdfQ6o8sO96gDC55If8n0KGOBdFaJr2MDesI6A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764901657; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=1jZ0ciMJUN1j2C6nIv4CGnaCGyWZmI8mA2wTEfutmc4=; b=swPgajgvknn7ZD6L0zfPYPskiG+Sn3cgT9k9wNAE/vSJeX/HmUu/iKQaMmw25xQRJe89z ooaxGKdnqZ44QEPRvcc0nz0lIypaA0aa7cKYBu1fAtz2E90Hu6t0zM1q5h2AOHIUuqfK25x /Vao7ZqbkFZ+KHCy2mx6ygeomyluiNqjz66Kdx56lGRLBwldWJhKOogoFAMZ3VYQpLILVmY uSrIdLjbd0M8vVgwNAr0CbZzBySI2J8oy25heSwEFXS20JhZ+ZK63RtLOvwjv4uSANKkP9/ m77XXJu9I/r9T+obj8eTqAmPelguM8Tx+Ct9lLe+0W9ys5EYB7sw12Ko8uzQ== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3DE0469050D for ; Fri, 5 Dec 2025 04:27:37 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 05 Dec 2025 02:27:36 -0000 Message-ID: <176490165739.39.7980704809500324062@2cb04c0e5124> Message-ID-Hash: GM5U63DMR7E66QB4POACWTCY4NPHHTWA X-Message-ID-Hash: GM5U63DMR7E66QB4POACWTCY4NPHHTWA X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/dpx: Fix heap-buffer-overflow in 16-bit decoding (PR #21106) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: oliverchang via ffmpeg-devel Cc: oliverchang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21106 opened by oliverchang URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21106 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21106.patch Fixes a heap-buffer-overflow in `libavcodec/dpx.c` triggered by a stale `unpadded_10bit` flag in the `DPXDecContext`. This flag, set for 10-bit unpadded frames, persisted across `decode_frame` calls. If a subsequent frame was 16-bit, the stale flag caused incorrect buffer size validation, allowing truncated buffers to pass checks designed for smaller 10-bit packed data. This led to an out-of-bounds read in `av_image_copy_plane` during 16-bit decoding. The fix explicitly resets `dpx->unpadded_10bit = 0` at the start of `decode_frame` to ensure correct validation for each frame. Fixes: https://issues.oss-fuzz.com/issues/464471792 >>From 4154373156a9798bbbe632fc1318efb256792816 Mon Sep 17 00:00:00 2001 From: Oliver Chang Date: Fri, 5 Dec 2025 02:07:10 +0000 Subject: [PATCH] avcodec/dpx: Fix heap-buffer-overflow in 16-bit decoding Fixes a heap-buffer-overflow in `libavcodec/dpx.c` triggered by a stale `unpadded_10bit` flag in the `DPXDecContext`. This flag, set for 10-bit unpadded frames, persisted across `decode_frame` calls. If a subsequent frame was 16-bit, the stale flag caused incorrect buffer size validation, allowing truncated buffers to pass checks designed for smaller 10-bit packed data. This led to an out-of-bounds read in `av_image_copy_plane` during 16-bit decoding. The fix explicitly resets `dpx->unpadded_10bit = 0` at the start of `decode_frame` to ensure correct validation for each frame. Fixes: https://issues.oss-fuzz.com/issues/464471792 --- libavcodec/dpx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c index 7355b50f7a..429290aede 100644 --- a/libavcodec/dpx.c +++ b/libavcodec/dpx.c @@ -280,6 +280,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *p, int *got_frame, AVPacket *avpkt) { DPXDecContext *dpx = avctx->priv_data; + dpx->unpadded_10bit = 0; enum AVPixelFormat pix_fmt; const uint8_t *buf = avpkt->data; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org