[FFmpeg-devel] [PATCH] tests/checkasm/mpegvideo_unquantize: Add missing const (PR #21087)

[FFmpeg-devel] [PATCH] tests/checkasm/mpegvideo_unquantize: Add missing const (PR #21087)

[mkver via ffmpeg-devel]

PR #21087 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21087
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21087.patch

Fixes this test under UBSan:
runtime error: call to function dct_unquantize_mpeg1_intra_c through pointer to incorrect function type 'void (*)(struct MpegEncContext *, short *, int, int)'
I don't know how I could forget this.


>From b58979cf09b0e56942ef2e83f0985ddd424d6b25 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Wed, 3 Dec 2025 13:05:58 +0100
Subject: [PATCH] tests/checkasm/mpegvideo_unquantize: Add missing const

Fixes this test under UBSan:
runtime error: call to function dct_unquantize_mpeg1_intra_c through pointer to incorrect function type 'void (*)(struct MpegEncContext *, short *, int, int)'
I don't know how I could forget this.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/checkasm/mpegvideo_unquantize.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/checkasm/mpegvideo_unquantize.c b/tests/checkasm/mpegvideo_unquantize.c
index 220a743a96..60c61b217b 100644
--- a/tests/checkasm/mpegvideo_unquantize.c
+++ b/tests/checkasm/mpegvideo_unquantize.c
@@ -215,11 +215,11 @@ void checkasm_check_mpegvideo_unquantize(void)
     int q_scale_type = rnd() & 1;
 
     ff_mpv_unquantize_init(&unquant_dsp_ctx, 1 /* bitexact */, q_scale_type);
-    declare_func(void, MPVContext *s, int16_t *block, int n, int qscale);
+    declare_func(void, const MPVContext *s, int16_t *block, int n, int qscale);
 
     for (size_t i = 0; i < FF_ARRAY_ELEMS(tests); ++i) {
-        void (*func)(MPVContext *s, int16_t *block, int n, int qscale) =
-            *(void (**)(MPVContext *, int16_t *, int, int))((char*)&unquant_dsp_ctx + tests[i].offset);
+        void (*func)(const MPVContext *s, int16_t *block, int n, int qscale) =
+            *(void (**)(const MPVContext *, int16_t *, int, int))((char*)&unquant_dsp_ctx + tests[i].offset);
         if (check_func(func, "%s", tests[i].name)) {
             MPVContext new, ref;
             DECLARE_ALIGNED(16, int16_t, block_new)[64];
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org