[FFmpeg-devel] [PATCH] avcodec/{arm,neon}/mpegvideo: Readd a missed initialization (PR #21086)

[FFmpeg-devel] [PATCH] avcodec/{arm,neon}/mpegvideo: Readd a missed initialization (PR #21086)

[Martin Storsjö via ffmpeg-devel]

PR #21086 opened by Martin Storsjö (mstorsjo)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21086
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21086.patch

This was accidentally removed in
357fc5243c32300bba91c096488e86558beed4c8.

This fixes test failures when built with Clang and MSVC;
surprisingly, the checkasm test did seem to pass when built with
GCC. Clang and MSVC also warn about the use of the uninitialized
variable, while GCC didn't.


From b98179cec637e380d755fcfa2a461709278139d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin@martin.st>
Date: Wed, 3 Dec 2025 13:49:39 +0200
Subject: [PATCH] avcodec/{arm,neon}/mpegvideo: Readd a missed initialization

This was accidentally removed in
357fc5243c32300bba91c096488e86558beed4c8.

This fixes test failures when built with Clang and MSVC;
surprisingly, the checkasm test did seem to pass when built with
GCC. Clang and MSVC also warn about the use of the uninitialized
variable, while GCC didn't.
---
 libavcodec/neon/mpegvideo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/neon/mpegvideo.c b/libavcodec/neon/mpegvideo.c
index 44e9b70303..45ac36df18 100644
--- a/libavcodec/neon/mpegvideo.c
+++ b/libavcodec/neon/mpegvideo.c
@@ -41,6 +41,8 @@ static void inline ff_dct_unquantize_h263_neon(int qscale, int qadd, int nCoeffs
     int16x8_t q14s16, q15s16, qzs16;
     uint16x8_t q1u16, q9u16;
 
+    qzs16 = vdupq_n_s16(0);
+
     q15s16 = vdupq_n_s16(qscale << 1);
     q14s16 = vdupq_n_s16(qadd);
     q13s16 = vnegq_s16(q14s16);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org