From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0EEA34CEEA for ; Wed, 3 Dec 2025 03:18:56 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'0YOjN60XVgKJ47T+GyIu23LdFl2qVgYiyAr3Fqz15tM=', expected b'F5oBqEKS5v5UZyYOi14BMO59g0nb0sdbuv+HCPKBZnc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764731927; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=0YOjN60XVgKJ47T+GyIu23LdFl2qVgYiyAr3Fqz15tM=; b=vQy1wsZjRFDZHNymMVLNfpNGba0xxICjXyusGGTsrvP6+uXQMX1ZQ+Gh8ChyZbugAvUNo se/UxRianyUDEwgQrdI/ejUWlQ3yQ55F5ipFol/qGCD7v31ieN/9RDGKMe+P4FcOcPFhIVV wdfOa6ZA6uA94XC3IorgZCcgQZPaVPlts7GYXcJFYOELWId73wvYHPke4Nj59doXw9ry1Z3 n255hsZSlPI6drNE8P00mO1e10RqXrwaNwDVnP7m0UTLo1ycoWQAsLmksv8SwXnef7gjZbK Ptvk/AcHa1JRZTvOHYy2sPE37XSUc3MnTq0mCsMWlp49YCe99axh0KlbmeEQ== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A1D9969047E; Wed, 3 Dec 2025 05:18:47 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764731914; b=sNf6s2d2rGAd/cUWD4FM26sZK5dLE/iIWlsBA8ymZgIwaAauTjZqtiOpaHLCFjSez6eco 6Cqe9sPryuItqz3om8r3E8N1lG1KIqWzK3p7ixl5nHDQNura+cXPHfdbnvTxy6eGZOsCIKE DcnsbWmFSsVPQzLAU0iuwZjLArH/cjgOcPkhxXGcfhSPaBW25TTlblCiy0LAE+Wrb2+4iH4 5bBPmKFrRDqmnBYM1TpcjMm5UEH6x5V40B+G2fwalYKxG76K8fQt3wBT7oysBYfjdGe2Dxu oHjDjJCKcsbbUaSK0lmLgGdzSLleJdBFtyjMVsZbalvX605+k7rOvwCo1n9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764731914; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=CIHOe89GYmsQBskmG8fOUdhtB9KM+Zalv/c3mcYFK3M=; b=rptvWgNRGVl1O8IVtgXL5Lv/Q6fAEJubPRcpTYvI0D7jQ/ZE+HmqZT6wH/QViCS6T4JrX I4eAUZK2wuM05qdmHnysKaqEbJUSsI5x/eeXLpLnn4j/vURNnZd3RoAse9+jBBSbyR5O9e7 x8XGhd9a32y2Z/NN1EYhg6gauujjGqjf6kolymaTv4HAeYBZkUxJOfvZAQz+hI+73He+Cwh en96/TvrqJA0Gfd4amuBlI9U9bDO5Yf9//GyIHI4kEQv4xpoTocazWPN54CL25rc1J3+r32 ApGZrkw2CCksq5iClVVLMRJ2hz1dY/qRuRHaWkAfPJ9zLybDs/8RpIJ29qrw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764731908; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=F5oBqEKS5v5UZyYOi14BMO59g0nb0sdbuv+HCPKBZnc=; b=rhKSlv56yJ43J9v7kladCflQzpiudxteCmNBXNUQ7kN62ysrZpfPcYHo8Z7bH92EGLUkr O9LdJ0youAQnI1Vm289Fmru1BmsJ3Tq2+q/d2jbBvx5zE6/xH1AtzD5h2bQH96YFEykv6eK /lt9dFefm7tbMfQw8W746l5t/pL9aa2YI9su6AQcU3VA7O9gS44xXL+hjZ2D5VcZgn72otJ xrIx/zAD6GcEzjCG0meeVl2EQ8AUgVzI2czK/AT1U5qf/Lcpy9ZQ6oIpU75zRSMIcUGT5e8 XfKM8opNz/CgPSIDAn0Ztb0FWS+3Q50Y7QBJrxnoDx5tZoPlem7ol+OPizPA== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 21F47690396 for ; Wed, 3 Dec 2025 05:18:28 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 03 Dec 2025 03:18:27 -0000 Message-ID: <176473190828.39.10800347272176878664@2cb04c0e5124> Message-ID-Hash: AU3SQALPKVPCBE2LBSYKGF5RZAKQ4WKR X-Message-ID-Hash: AU3SQALPKVPCBE2LBSYKGF5RZAKQ4WKR X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] libavcodec/prores_raw: Fix heap-buffer-overflow in decode_frame (PR #21085) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: oliverchang via ffmpeg-devel Cc: oliverchang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21085 opened by oliverchang URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21085 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21085.patch Fixes a heap-buffer-overflow in `decode_frame` where `header_len` read from the bitstream was not validated against the remaining bytes in the input buffer (`gb`). This allowed `gb_hdr` to be initialized with a size exceeding the actual packet data, leading to an out-of-bounds read. The fix adds a check to ensure `bytestream2_get_bytes_left(&gb)` is greater than or equal to `header_len - 2` before initializing `gb_hdr`. Fixes: https://issues.oss-fuzz.com/issues/439711053 >>From ac7bdf8326e0747758ef1ceb03f4ff8abf225283 Mon Sep 17 00:00:00 2001 From: Oliver Chang Date: Wed, 3 Dec 2025 02:57:43 +0000 Subject: [PATCH] libavcodec/prores_raw: Fix heap-buffer-overflow in decode_frame Fixes a heap-buffer-overflow in `decode_frame` where `header_len` read from the bitstream was not validated against the remaining bytes in the input buffer (`gb`). This allowed `gb_hdr` to be initialized with a size exceeding the actual packet data, leading to an out-of-bounds read. The fix adds a check to ensure `bytestream2_get_bytes_left(&gb)` is greater than or equal to `header_len - 2` before initializing `gb_hdr`. Fixes: https://issues.oss-fuzz.com/issues/439711053 --- libavcodec/prores_raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/prores_raw.c b/libavcodec/prores_raw.c index 01f1bbd2fb..8be566ed36 100644 --- a/libavcodec/prores_raw.c +++ b/libavcodec/prores_raw.c @@ -360,7 +360,7 @@ static int decode_frame(AVCodecContext *avctx, return AVERROR_INVALIDDATA; int header_len = bytestream2_get_be16(&gb); - if (header_len < 62) + if (header_len < 62 || bytestream2_get_bytes_left(&gb) < header_len - 2) return AVERROR_INVALIDDATA; GetByteContext gb_hdr; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org