From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id AAD174CEA1 for ; Mon, 1 Dec 2025 14:11:45 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'1SCP88hkDyrjyWpGrP/xnSZD/LH820dNMVVv+Udj1mc=', expected b'EnXh5xG2hLkY0r8ILZ3AR0Y/NL8LN1EaR73OBHg6eOY=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764598294; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=1SCP88hkDyrjyWpGrP/xnSZD/LH820dNMVVv+Udj1mc=; b=Biw3uYPZlulXLZLOtVjBkc2rYVTMpSBtcOdEpeVlZtoKHh9A7eZMxBg/hwF+2TqI/e9PV weW1fBV5RbmFG55fSFkgiD652Fup7S0OVZ0RJ7lhVSLNET0lCEgYb82fCaY1zp3yfENl87o EXi/j3mDrFcvrChqco/5MoYUN5B1MmZOaqoYyORAV8+xj44nY418WJbtCm5ODA3dwFP1kXX V+ZZHFiftjOhuT5BzVQ/DMPSxpMbpmFa0yGna/RvUDDFO6sAwMazilRAAVM/gLxJmXevKee Zqmq4NQ9Ka1PqUjCzcd3PpYMnV2ijUQM8fmkPOnAWETLVgJyTOsZ79ezgH7A== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C27DE6903F6; Mon, 1 Dec 2025 16:11:34 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764598279; b=SXwYHSQ0ANzuBatG1mxgHU8aUK17J+ZRE+bIyi1PM2H/Z2Uj4P3RUKneYpYp/8iCW1xcD I2zQ9oAhop+9NtKH7aVV39LF95KYG3CkB7uTTK8oBOZDxtX0B/3rhK+IR095haV3W8iop8g RnvpTV9xj69iW9y3sHaX4Wbdqq1yrO4d7+A+mWp9g9YbbdykO7hZK2YurcXuUzdG8eY7zg7 cmbmBjCLSdwdOtAr44dz3VPIpoYWDqhBbi6eoX1bWozw53WH/5guMSTkKwroQojsyA649IW Aw8VgRqL86eThqzJod57Bim6kysyz3eYxZQO5FvF9zcj+7JyRwI1Vc4IEbhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764598279; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=hDhwWowfeQkm1E+0oPqOxmrhhEwp5O5lc43FTaVnO5I=; b=cTR2n8l384rtyts3xdQ7znNehF9dSExy5budGIdS2deM8e24D4qM+vUKZYv6HlZTCafIf QRsn00VU72MA8RGFCtGLoHa5LrMOAoXN7MwI2N96wXvhhZOwFuqiSpjyTC+WuI2BCwOD9xm fhvEToZe188fXAmqgr9e4vsR+XcDn/Nn8X4htSz6Fy+t1sQlkfk2f58FxrYbFROAXl4jvqj u8tT9WJ6yItGWNKOdZ5guaf7/Bha9+EKjhJHH+l+lF1A26QOLO4LUqQkIf/kXibc6cowhTv EWGzI2ZgSUK+c3bU/+J32fetizyAhSZDzWot5qSIoxUSGopQHpFFoGszD58g== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764598271; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=EnXh5xG2hLkY0r8ILZ3AR0Y/NL8LN1EaR73OBHg6eOY=; b=xTTxjJ2FZfW7ZVxdpl+K1FDusGL+UM6TkKx6VIW074vujtbyIchCr1G8mgcX+ZOmIr1bx Ak8T09pErJT5quHDGfGvW/RAPzpFPX0A/YoNYkK3HoJ9ZtRbXm2N+lH3Qmg+po93YNMmw0N DJJ4o0GK1tBFl0GMHCCKcOq73zRvBlLKlLVPrXfUfHjN1zEF6nPo1AMuTSUqH3b5KvRzgIG BlYFoUdI0XTZHAh2itVFGDZ8CUuZrMpjl8QhXC8V3cMBquuim/NwQaC5mlc4n7xszzwc57p IyAmTz2XwrqWqECsZ3SDKv8VnuFsFoqIoQ9Qi8KzUfbAcuzOYaOBWe6TzjRw== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 6BA7A69024E for ; Mon, 1 Dec 2025 16:11:11 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 01 Dec 2025 14:11:11 -0000 Message-ID: <176459827154.39.4904509518036094946@2cb04c0e5124> Message-ID-Hash: EI3DHR5PSFPTA3FXWTBCKKLJIPHZEYBZ X-Message-ID-Hash: EI3DHR5PSFPTA3FXWTBCKKLJIPHZEYBZ X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/f_select: also handle global side data in filter links (PR #21072) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: James Almer via ffmpeg-devel Cc: James Almer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21072 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21072 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21072.patch Should fix issue ffmpeg/ffmpeg#21071 >>From e977f97b75681984fbd8e93e37687ad6d989131c Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 1 Dec 2025 11:07:43 -0300 Subject: [PATCH] avfilter/f_select: also handle global side data in filter links Should fix issue #21071 Signed-off-by: James Almer --- libavfilter/f_sidedata.c | 45 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c index b88a8cbd02..dc7da5a19a 100644 --- a/libavfilter/f_sidedata.c +++ b/libavfilter/f_sidedata.c @@ -96,6 +96,31 @@ static av_cold int init(AVFilterContext *ctx) return 0; } +static int config_props(AVFilterLink *outlink) +{ + AVFilterContext *ctx = outlink->src; + SideDataContext *s = ctx->priv; + const AVFrameSideData *sd = NULL; + + if (s->type != -1) + sd = av_frame_side_data_get(outlink->side_data, outlink->nb_side_data, s->type); + + switch (s->mode) { + case SIDEDATA_SELECT: + break; + case SIDEDATA_DELETE: + if (s->type == -1) + av_frame_side_data_free(&outlink->side_data, &outlink->nb_side_data); + else if (sd) + av_frame_side_data_remove(&outlink->side_data, &outlink->nb_side_data, s->type); + break; + default: + av_assert0(0); + }; + + return 0; +} + static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { AVFilterContext *ctx = inlink->dst; @@ -143,6 +168,14 @@ static const AVFilterPad ainputs[] = { }, }; +static const AVFilterPad aoutputs[] = { + { + .name = "default", + .type = AVMEDIA_TYPE_AUDIO, + .config_props = config_props, + }, +}; + const FFFilter ff_af_asidedata = { .p.name = "asidedata", .p.description = NULL_IF_CONFIG_SMALL("Manipulate audio frame side data."), @@ -152,7 +185,7 @@ const FFFilter ff_af_asidedata = { .priv_size = sizeof(SideDataContext), .init = init, FILTER_INPUTS(ainputs), - FILTER_OUTPUTS(ff_audio_default_filterpad), + FILTER_OUTPUTS(aoutputs), }; #endif /* CONFIG_ASIDEDATA_FILTER */ @@ -169,6 +202,14 @@ static const AVFilterPad inputs[] = { }, }; +static const AVFilterPad outputs[] = { + { + .name = "default", + .type = AVMEDIA_TYPE_VIDEO, + .config_props = config_props, + }, +}; + const FFFilter ff_vf_sidedata = { .p.name = "sidedata", .p.description = NULL_IF_CONFIG_SMALL("Manipulate video frame side data."), @@ -178,6 +219,6 @@ const FFFilter ff_vf_sidedata = { .priv_size = sizeof(SideDataContext), .init = init, FILTER_INPUTS(inputs), - FILTER_OUTPUTS(ff_video_default_filterpad), + FILTER_OUTPUTS(outputs), }; #endif /* CONFIG_SIDEDATA_FILTER */ -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org