From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BE0A34C921 for ; Wed, 26 Nov 2025 16:48:06 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'zo8hPzzrY6HDxFY1YC9MkrXJ2fHzgZwGgZSH2z54ytM=', expected b'aPHR7hrhGJFkBoGpV9xnE/sKYtXhnQwxnwy58Fe/mOA=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764175678; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=zo8hPzzrY6HDxFY1YC9MkrXJ2fHzgZwGgZSH2z54ytM=; b=UPuSJVRUOazO5K/7yUypwce/vK+8W3xA4H0LmbNbH0F5l9b6eLQydtxow5XMTqIh7fGiw 4hjuV1ITmaY6X0LR1LpmwRc6FYceZ9hKT/CGtCZ+vcW+211E4bMyqgNbkdgdQBVLx93WxJd I6INPAAnqKyxXOQw9DMqA6kzHBoGrigYu/oztf9fLO4F9nL29woi47rRa1mQkIA8GCSfJPG wJ5Vj6h+TenREayi1FhUFiS5vBBcHRgF7bVw46v3AB2G4iDgJH7Eo9XooszymsPxXBQpIum zx72AYe2lsT1EvjIunuraiqqYWLHq2WPQkjnwQIoZXDq1xjKvKHyaTb62cvQ== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 48BE86901FA; Wed, 26 Nov 2025 18:47:58 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764175664; b=uXyzJHZ1PTt5DnLUioWHyZ2Ldonvk+RJKsWOjPKEThCbAR/lBaiz46oitMv6dtWuwYjsz IiwyhI4euWFtooC+OuRRoE0Oo+tM4cNlvt+kaUEO8/v9otD2qzmBaHTsYvzEMqJwqtQdQJD 3SS4S1vuuHsxorM67Hxn2z1akEkA4ZOQPOjg9n5Ydc9lMFrNubobHrRXE5BPeVgFKl0Vrwu uj/vCXXU0Mf2cIvl9mVHd3gisWBJHEz7yoYprRgXD57bwHqBZ8TCMLGdiJrtDtBS6nhnVES vyeiXE0olLxdf2whff5lN/9OqbR7vg7eDgwvdVCZaN+FpelLVCfcn59rONwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764175664; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=DB+7he4y5P/e0FmTzirDMgOK0Q+YyPsBgy5CqxqfR7M=; b=tZLS1tS+rViz2dvGbXN4gwFV+MW4LQQ9vdkw+1sEHHRsfLz+5EfG14LUyWEkIdIHeiwDZ PJqo/uVMhzCWNo5cOqVpwa5hfss8tEos8+1PiAP6a8GykBwvKdUTyAlQyapJQk+eXPtHbI5 CvpDma8jDNoedYRoyoPU3KLAiu8dynr5k2eiHMWwOoCabvWOBgViR/lUGAU2DnxpKx9u5Hb nUYVUt6tZTjLG/30HhGVf8zS2QzyI8XvLpp7CvYBynlo8cSj03/3UdlQKLIWHr/fBROjlLW fLGVF+Om2Pqw0xfNtAEEXE1Tz0qhIrmt9c5cRJ2A58jhJTSuPlxz+8koZkmg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764175657; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=aPHR7hrhGJFkBoGpV9xnE/sKYtXhnQwxnwy58Fe/mOA=; b=vwTrblrO0yvCDGGaWpESG3dfZOZiCJunrWu03PpxqC7OdkuoxwWQijDj8xBrTBcgZPsEy CesxeBN1eu4QVVRuA6QMQWj+pjGScq4FhcVf/O17A6rT+QUTqPjY2Bx2iwIxB+Mz9L97f8i i4pJP/YyD8Ro0/dtH3Henc9h1GtIDTz5TRd+WF7lR7fVL+kacEJTmnm5mW7S9iLoL4FIOlM ay5RBUZpSShB8JaRM2YtZFbhvKTWktna1lvamEQA46P5+InBDLDgJz/i3AtkgZg9bgz4Fub LqkOlpMRipPqI3HNniPdSDL3QzYmNBAhgc5zFt6PAKmFaIML8A8UFuHFhtVQ== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7FFC8690172 for ; Wed, 26 Nov 2025 18:47:37 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 26 Nov 2025 16:47:37 -0000 Message-ID: <176417565766.39.806299892393289832@2cb04c0e5124> Message-ID-Hash: GYTLCA77U3UPU6SCHRCPNRLXE4YXNH35 X-Message-ID-Hash: GYTLCA77U3UPU6SCHRCPNRLXE4YXNH35 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/yadif_videotoolbox: Add missing include (PR #21025) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Amyspark via ffmpeg-devel Cc: Amyspark Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21025 opened by Amyspark (amyspark) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21025 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21025.patch Hi all, This PR is to fix a little hidden corner case regarding VideoToolbox support. The macro `NULL_IF_CONFIG_SMALL` is declared in libavutil/internal.h, which is not included previously in yadif_videotoolbox.m. This is only revealed when targeting ISO C99 or later (e.g. `-std=c17` as is used in GStreamer's Meson port) under Xcode 26, because it causes a hard build error: ``` ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: call to undeclared function 'NULL_IF_CONFIG_SMALL'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^ ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: incompatible integer to pointer conversion initializing 'const char *' with an expression of type 'int' [-Wint-conversion] 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: initializer element is not a compile-time constant 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` All feedback is appreciated. >>From ba95d2c1f1e441a01ed668ff3c7e4d4709dc2d38 Mon Sep 17 00:00:00 2001 From: "L. E. Segovia" Date: Wed, 26 Nov 2025 16:31:54 +0000 Subject: [PATCH] avfilter/yadif_videotoolbox: Add missing include NULL_IF_CONFIG_SMALL is declared in libavutil/internal.h, which is not included previously. When targeting ISO C99 or later (e.g. `-std=c17` as is used in GStreamer's Meson port) under Xcode 26, this causes a hard build error: ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: call to undeclared function 'NULL_IF_CONFIG_SMALL'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^ ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: incompatible integer to pointer conversion initializing 'const char *' with an expression of type 'int' [-Wint-conversion] 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../libavfilter/vf_yadif_videotoolbox.m:437:23: error: initializer element is not a compile-time constant 437 | .p.description = NULL_IF_CONFIG_SMALL("YADIF for VideoToolbox frames using Metal compute"), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- libavfilter/vf_yadif_videotoolbox.m | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_yadif_videotoolbox.m b/libavfilter/vf_yadif_videotoolbox.m index f8eb0c6bfa..89f0e3b32e 100644 --- a/libavfilter/vf_yadif_videotoolbox.m +++ b/libavfilter/vf_yadif_videotoolbox.m @@ -25,6 +25,7 @@ #include "libavutil/avassert.h" #include "libavutil/hwcontext.h" #include "libavutil/hwcontext_videotoolbox.h" +#include "libavutil/internal.h" #include "libavutil/objc.h" #include -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org