From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id F12944D680 for ; Mon, 24 Nov 2025 18:20:51 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'LI0uMqvpqrh+ppNQsX9rVKLesHC4ceAaDdvhZM+rYk0=', expected b'yUwJS6tYb9Ohp87ErZUuy9qIn13BHp0uaK0t6lhTJVA=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764008442; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=LI0uMqvpqrh+ppNQsX9rVKLesHC4ceAaDdvhZM+rYk0=; b=YLzMYEpBn28myyJq0FYok7fSWEkQt0H5qB2mLlYglpbTM56Mb73QfdIlCu2d6caCmu2d0 +LzUs1cmv9d085lMN3ooTlCzN8uvuU1BV2nhr6l1YUF90/Oz4YHEWB7XzARF7c8oPBo7MOH mGH1N4D6A9ADEoZ7KenZmU/ziii5kAmloVJOHWXSdxImlRwqYSfHV3qPfW8IvP7wGa52XzM HPRCv9VWrS3G0Oj69GzLDfCzjMsIKXH1NrOHLqPRIgB+tGKUtZVgm6GdCtIIoiG1SF4jRdH lI6Wd4NqYuVqMn0cGImvwiNuzFitk5TQHCHMGviO6U0wbTbm7hQxokdWZK/Q== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 17BBC6901BE; Mon, 24 Nov 2025 20:20:42 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764008423; b=sF5dnninB32GzOLKEuIwTgzc4WYSQSOjQTNgXeq+05swJ/1SUkeds8SBkTbZ692i89Mi2 yJNDJp83mhx2ioSVZRQdumJzV4WoFy02eMPxLCMj5b3PNa2CyXNZBICE6V7Sh/Hq9m3yUjB yLmqxCua1rvIld2Y42w26WG9VdYYhm6VLKvJMvKy3JBF34maLDI8ewtQBJPJPWHcwn1COJm P1geQTKK9maU9R8IB6nabZ830nvUSAls2AuxeWYxvMCmEilGs10MmWZ32xkF1Z0wnXUC6JB T7DxbPLQI5oJi5nVk4VYAqWUHY87qU68Knrro5VkQiAVlqJ9jzZT7HekKlOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764008423; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=BHYimR5T4t7hyt2BPjDdoNe3Jl1iygaM1fqpxcexiEg=; b=UVbqdae8GN4mm87rWALUNVFhZlwhDrxzehH/hRYjZn+1DxgcShDS0QWHIKD73Lsz/xEw7 2zL7Pv73mL4VryCYz95LkLUxYS58Ix1I75hZYw9IgPCGrqEoZ4kw/OoEvR8JmMcHQfXw3xS /b6aXm2AwLDuqBKzMJkR50kF3Eo/QllRdnmAkMHqjchO7zOOdcBGcHuzFv3xj7o8SSbQWFU rSEXNLKWpOpGABk1Z6R1J78HiLmMlonSkr7Gh9jmRPYZG7PnU1borHnHaLvrT3hvYxMqbmQ US5hStJQL6emx37Mo6aMsbciw4OnULPkb5EV1xktmmfmjbP4sPslFJa1Ahag== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764008416; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=yUwJS6tYb9Ohp87ErZUuy9qIn13BHp0uaK0t6lhTJVA=; b=BxIIgaVCsx0o4uI73hzurWxdiFYSX9vsTpry0nS21bch1SGUzzxfULkZyBj0qZHPMATCw XGRL9MoapitUkMDSNkxna2Z6/elUkamoQqFn7Pjq0G/ZxymGMHjn7icx0NCSCtbSUxRG1YU n3TxE8EhWwA9tr1u5wNBHJw6vv1h57SRxdbHo+V4kbW1Pd3Sb0/9foY/AsgVpCZFPYkGZPd VI0QI9cHFEE4QreFNgXSvEU7kTYOyhtpX3ZbK7L+81PDHsJ3XDYTfAhuXyxg8C1eEO3VrSy 0jwELIW8B0qp05WKsTTaCJBlgmQRAzm/InTLsLn+Wbv6BPOYrTM6zsTE+1Ig== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 16AE5690140 for ; Mon, 24 Nov 2025 20:20:16 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 24 Nov 2025 18:20:15 -0000 Message-ID: <176400841619.39.6187131157016456655@2cb04c0e5124> Message-ID-Hash: H66ICM4262NAG3UW4TDMKKFRVZJB2XMX X-Message-ID-Hash: H66ICM4262NAG3UW4TDMKKFRVZJB2XMX X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter, avcodec: Finish gating empty X86ASM-OBJS files for Nasm (PR #21007) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Amyspark via ffmpeg-devel Cc: Amyspark Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21007 opened by Amyspark (amyspark) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21007 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21007.patch Hi all, This MR comes from the GStreamer Meson port of FFmpeg. The files gated here are empty on all platforms but x86_64; these cause Nasm to panic when generating debug information, and MSVC < 2022 17.6 to hang when attempting to link them. See e.g. - https://bugzilla.nasm.us/show_bug.cgi?id=3392738 - https://developercommunity.visualstudio.com/t/MSVC-Hangs-when-compiling-ffmpeg-When-l/10233953 The original 262e7439c6 only addressed simple_idct*.asm on avcodec, on GStreamer we found a few more that were looked over. All feedback is really appreciated. >>From a03c7a560a8c33977ac93022ad64901c7427ce7e Mon Sep 17 00:00:00 2001 From: "L. E. Segovia" Date: Mon, 24 Nov 2025 17:58:08 +0000 Subject: [PATCH 1/2] avcodec/Makefile: Finish gating empty X86ASM-OBJS files for Nasm The files gated here are empty on all platforms but x86_64; these cause Nasm to panic when generating debug information, and MSVC < 2022 17.6 to hang when attempting to link them. See e.g. - https://bugzilla.nasm.us/show_bug.cgi?id=3392738 - https://developercommunity.visualstudio.com/t/MSVC-Hangs-when-compiling-ffmpeg-When-l/10233953 The original 262e7439c6d58564d21ffffb05ade84bac4482ef only addressed simple_idct*.asm, on GStreamer we found a few more that were looked over. --- libavcodec/x86/Makefile | 16 ++++++++++++---- libavcodec/x86/hevc/Makefile | 6 ++++-- libavcodec/x86/vvc/Makefile | 2 ++ 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile index 1c1e14b4b8..80f1e72ce1 100644 --- a/libavcodec/x86/Makefile +++ b/libavcodec/x86/Makefile @@ -150,9 +150,13 @@ X86ASM-OBJS-$(CONFIG_ADPCM_G722_DECODER) += x86/g722dsp.o X86ASM-OBJS-$(CONFIG_ADPCM_G722_ENCODER) += x86/g722dsp.o X86ASM-OBJS-$(CONFIG_ALAC_DECODER) += x86/alacdsp.o X86ASM-OBJS-$(CONFIG_APNG_DECODER) += x86/pngdsp.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_APV_DECODER) += x86/apv_dsp.o +endif X86ASM-OBJS-$(CONFIG_CAVS_DECODER) += x86/cavsidct.o x86/cavs_qpel.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_CFHD_ENCODER) += x86/cfhdencdsp.o +endif X86ASM-OBJS-$(CONFIG_CFHD_DECODER) += x86/cfhddsp.o X86ASM-OBJS-$(CONFIG_DCA_DECODER) += x86/dcadsp.o x86/synth_filter.o X86ASM-OBJS-$(CONFIG_DIRAC_DECODER) += x86/diracdsp.o \ @@ -165,16 +169,19 @@ X86ASM-OBJS-$(CONFIG_FLAC_ENCODER) += x86/flac_dsp_gpl.o endif X86ASM-OBJS-$(CONFIG_JPEG2000_DECODER) += x86/jpeg2000dsp.o X86ASM-OBJS-$(CONFIG_LSCR_DECODER) += x86/pngdsp.o -X86ASM-OBJS-$(CONFIG_MLP_DECODER) += x86/mlpdsp.o X86ASM-OBJS-$(CONFIG_MPEG4_DECODER) += x86/xvididct.o X86ASM-OBJS-$(CONFIG_PNG_DECODER) += x86/pngdsp.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_PRORES_DECODER) += x86/proresdsp.o X86ASM-OBJS-$(CONFIG_PRORES_RAW_DECODER) += x86/proresdsp.o +endif X86ASM-OBJS-$(CONFIG_RV40_DECODER) += x86/rv40dsp.o X86ASM-OBJS-$(CONFIG_SBC_ENCODER) += x86/sbcdsp.o X86ASM-OBJS-$(CONFIG_SVQ1_ENCODER) += x86/svq1enc.o X86ASM-OBJS-$(CONFIG_TAK_DECODER) += x86/takdsp.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_TRUEHD_DECODER) += x86/mlpdsp.o +endif X86ASM-OBJS-$(CONFIG_TTA_DECODER) += x86/ttadsp.o X86ASM-OBJS-$(CONFIG_TTA_ENCODER) += x86/ttaencdsp.o X86ASM-OBJS-$(CONFIG_UTVIDEO_DECODER) += x86/utvideodsp.o @@ -185,12 +192,13 @@ X86ASM-OBJS-$(CONFIG_VP6_DECODER) += x86/vp6dsp.o X86ASM-OBJS-$(CONFIG_VP9_DECODER) += x86/vp9intrapred.o \ x86/vp9intrapred_16bpp.o \ x86/vp9itxfm.o \ - x86/vp9itxfm_avx2.o \ - x86/vp9itxfm_avx512.o \ x86/vp9itxfm_16bpp.o \ - x86/vp9itxfm_16bpp_avx512.o \ x86/vp9lpf.o \ x86/vp9lpf_16bpp.o \ x86/vp9mc.o \ x86/vp9mc_16bpp.o +ifdef ARCH_X86_64 +X86ASM-OBJS-$(CONFIG_VP9_DECODER) += x86/vp9itxfm_avx512.o \ + x86/vp9itxfm_16bpp_avx512.o +endif X86ASM-OBJS-$(CONFIG_WEBP_DECODER) += x86/vp8dsp.o diff --git a/libavcodec/x86/hevc/Makefile b/libavcodec/x86/hevc/Makefile index 8f1c88c569..b36715d503 100644 --- a/libavcodec/x86/hevc/Makefile +++ b/libavcodec/x86/hevc/Makefile @@ -8,5 +8,7 @@ X86ASM-OBJS-$(CONFIG_HEVC_DECODER) += x86/hevc/add_res.o \ x86/hevc/idct.o \ x86/hevc/mc.o \ x86/hevc/sao.o \ - x86/hevc/sao_10bit.o \ - x86/h26x/h2656_inter.o + x86/hevc/sao_10bit.o +ifdef ARCH_X86_64 +X86ASM-OBJS-$(CONFIG_HEVC_DECODER) += x86/h26x/h2656_inter.o +endif diff --git a/libavcodec/x86/vvc/Makefile b/libavcodec/x86/vvc/Makefile index c426b156c1..1fd76b2155 100644 --- a/libavcodec/x86/vvc/Makefile +++ b/libavcodec/x86/vvc/Makefile @@ -3,6 +3,7 @@ clean:: OBJS-$(CONFIG_VVC_DECODER) += x86/vvc/dsp_init.o \ x86/h26x/h2656dsp.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_VVC_DECODER) += x86/vvc/alf.o \ x86/vvc/dmvr.o \ x86/vvc/mc.o \ @@ -11,3 +12,4 @@ X86ASM-OBJS-$(CONFIG_VVC_DECODER) += x86/vvc/alf.o \ x86/vvc/sao.o \ x86/vvc/sao_10bit.o \ x86/h26x/h2656_inter.o +endif -- 2.49.1 >>From 5fc9eb97a96e8212835df801e59b4c5cfecb38d6 Mon Sep 17 00:00:00 2001 From: "L. E. Segovia" Date: Mon, 24 Nov 2025 17:58:08 +0000 Subject: [PATCH 2/2] avfilter/x86/Makefile: Finish gating empty X86ASM-OBJS files for Nasm The files gated here are empty on all platforms but x86_64; these cause Nasm to panic when generating debug information, and MSVC < 2022 17.6 to hang when attempting to link them. See e.g. - https://bugzilla.nasm.us/show_bug.cgi?id=3392738 - https://developercommunity.visualstudio.com/t/MSVC-Hangs-when-compiling-ffmpeg-When-l/10233953 The original 262e7439c6d58564d21ffffb05ade84bac4482ef only addressed simple_idct*.asm on avcodec, on GStreamer we found a few more that were looked over. --- libavfilter/x86/Makefile | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/libavfilter/x86/Makefile b/libavfilter/x86/Makefile index b485c10fbe..aae0a4305f 100644 --- a/libavfilter/x86/Makefile +++ b/libavfilter/x86/Makefile @@ -50,29 +50,41 @@ X86ASM-OBJS-$(CONFIG_SCENE_SAD) += x86/scene_sad.o X86ASM-OBJS-$(CONFIG_AFIR_FILTER) += x86/af_afir.o X86ASM-OBJS-$(CONFIG_ANLMDN_FILTER) += x86/af_anlmdn.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_ATADENOISE_FILTER) += x86/vf_atadenoise.o X86ASM-OBJS-$(CONFIG_BLACKDETECT_FILTER) += x86/vf_blackdetect.o +endif X86ASM-OBJS-$(CONFIG_BLEND_FILTER) += x86/vf_blend.o X86ASM-OBJS-$(CONFIG_BWDIF_FILTER) += x86/vf_bwdif.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_COLORDETECT_FILTER) += x86/vf_colordetect.o +endif X86ASM-OBJS-$(CONFIG_COLORSPACE_FILTER) += x86/colorspacedsp.o X86ASM-OBJS-$(CONFIG_CONVOLUTION_FILTER) += x86/vf_convolution.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_EBUR128_FILTER) += x86/f_ebur128.o +endif X86ASM-OBJS-$(CONFIG_EQ_FILTER) += x86/vf_eq.o X86ASM-OBJS-$(CONFIG_FRAMERATE_FILTER) += x86/vf_framerate.o X86ASM-OBJS-$(CONFIG_FSPP_FILTER) += x86/vf_fspp.o X86ASM-OBJS-$(CONFIG_GBLUR_FILTER) += x86/vf_gblur.o X86ASM-OBJS-$(CONFIG_GRADFUN_FILTER) += x86/vf_gradfun.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_HALDCLUT_FILTER) += x86/vf_lut3d.o +endif X86ASM-OBJS-$(CONFIG_HFLIP_FILTER) += x86/vf_hflip.o X86ASM-OBJS-$(CONFIG_HQDN3D_FILTER) += x86/vf_hqdn3d.o X86ASM-OBJS-$(CONFIG_IDET_FILTER) += x86/vf_idetdsp.o X86ASM-OBJS-$(CONFIG_INTERLACE_FILTER) += x86/vf_interlace.o X86ASM-OBJS-$(CONFIG_LIMITER_FILTER) += x86/vf_limiter.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_LUT3D_FILTER) += x86/vf_lut3d.o +endif X86ASM-OBJS-$(CONFIG_MASKEDCLAMP_FILTER) += x86/vf_maskedclamp.o X86ASM-OBJS-$(CONFIG_MASKEDMERGE_FILTER) += x86/vf_maskedmerge.o +ifdef ARCH_X86_64 X86ASM-OBJS-$(CONFIG_NLMEANS_FILTER) += x86/vf_nlmeans.o +endif X86ASM-OBJS-$(CONFIG_OVERLAY_FILTER) += x86/vf_overlay.o X86ASM-OBJS-$(CONFIG_PP7_FILTER) += x86/vf_pp7.o X86ASM-OBJS-$(CONFIG_PSNR_FILTER) += x86/vf_psnr.o -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org